From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: malureau@redhat.com, kwolf@redhat.com, hreitz@redhat.com,
stefanha@redhat.com, qemu-block@nongnu.org
Subject: [PATCH 00/19] block: fix coroutine_fn annotations
Date: Fri, 15 Apr 2022 15:18:34 +0200 [thread overview]
Message-ID: <20220415131900.793161-1-pbonzini@redhat.com> (raw)
This is the initial result of reviving Marc-André's series at
https://patchew.org/QEMU/20170704220346.29244-1-marcandre.lureau@redhat.com/.
A lot of the patches are similar to the ones that Marc-André wrote,
but due to the changes in the code it was easier to redo them.
For nbd, the patch is on top of "nbd: mark more coroutine_fns" that
I sent a few days ago and that (AIUI) Eric has already queued; only
one function was missing, much to my surprise.
Apart from this, I also identified the following functions that
can be called both in coroutine context and outside:
- qmp_dispatch
- schedule_next_request
- nvme_get_free_req
- bdrv_create
- bdrv_remove_persistent_dirty_bitmap
- bdrv_can_store_new_dirty_bitmap
- bdrv_do_drained_begin
- bdrv_do_drained_end
- bdrv_drain_all_begin
- qcow2_open
- qcow2_has_zero_init
- bdrv_qed_open
- qio_channel_readv_full_all_eof
- qio_channel_writev_full_all
besides, of course, everything that is generated by
scripts/block-coroutine-wrapper.py.
Thanks,
Paolo
Supersedes: <20170704220346.29244-1-marcandre.lureau@redhat.com>
Marc-André Lureau (3):
9p: add missing coroutine_fn annotations
migration: add missing coroutine_fn annotations
test-coroutine: add missing coroutine_fn annotations
Paolo Bonzini (23):
block: remove incorrect coroutine_fn annotations
qcow2: remove incorrect coroutine_fn annotations
nbd: remove incorrect coroutine_fn annotations
coroutine: remove incorrect coroutine_fn annotations
blkdebug: add missing coroutine_fn annotations
blkverify: add missing coroutine_fn annotations
block: add missing coroutine_fn annotations
file-posix: add missing coroutine_fn annotations
iscsi: add missing coroutine_fn annotations
nbd: add missing coroutine_fn annotations
nfs: add missing coroutine_fn annotations
nvme: add missing coroutine_fn annotations
parallels: add missing coroutine_fn annotations
qcow2: add missing coroutine_fn annotations
copy-before-write: add missing coroutine_fn annotations
curl: add missing coroutine_fn annotations
qed: add missing coroutine_fn annotations
quorum: add missing coroutine_fn annotations
throttle: add missing coroutine_fn annotations
vmdk: add missing coroutine_fn annotations
job: add missing coroutine_fn annotations
coroutine-lock: add missing coroutine_fn annotations
raw-format: add missing coroutine_fn annotations
block/blkdebug.c | 14 +++++++-------
block/blkverify.c | 2 +-
block/block-backend.c | 26 +++++++++++++-------------
block/copy-before-write.c | 8 ++++----
block/curl.c | 2 +-
block/file-posix.c | 2 +-
block/io.c | 24 ++++++++++++------------
block/iscsi.c | 2 +-
block/nbd.c | 10 +++++-----
block/nfs.c | 2 +-
block/nvme.c | 5 +++--
block/parallels.c | 5 +++--
block/qcow2-cluster.c | 18 +++++++++---------
block/qcow2-refcount.c | 6 +++---
block/qcow2.c | 4 ++--
block/qcow2.h | 18 +++++++++---------
block/qed.c | 4 ++--
block/quorum.c | 35 ++++++++++++++++++-----------------
block/raw-format.c | 2 +-
block/throttle.c | 2 +-
block/vmdk.c | 20 ++++++++++----------
hw/9pfs/9p.h | 9 ++++++---
include/block/nbd.h | 2 +-
include/qemu/coroutine.h | 2 +-
include/qemu/job.h | 2 +-
job.c | 2 +-
migration/migration.c | 3 ++-
tests/unit/test-coroutine.c | 2 +-
util/qemu-coroutine-lock.c | 14 +++++++-------
util/qemu-coroutine.c | 2 +-
30 files changed, 128 insertions(+), 121 deletions(-)
--
2.35.1
next reply other threads:[~2022-04-15 13:22 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 13:18 Paolo Bonzini [this message]
2022-04-15 13:18 ` [PATCH 01/26] block: remove incorrect coroutine_fn annotations Paolo Bonzini
2022-04-19 17:57 ` Eric Blake
2022-04-21 10:21 ` Stefan Hajnoczi
2022-04-15 13:18 ` [PATCH 02/26] qcow2: " Paolo Bonzini
2022-04-19 18:07 ` Eric Blake
2022-04-21 10:24 ` Stefan Hajnoczi
2022-04-27 12:36 ` Paolo Bonzini
2022-04-27 14:18 ` Paolo Bonzini
2022-04-15 13:18 ` [PATCH 03/26] nbd: " Paolo Bonzini
2022-04-19 18:08 ` Eric Blake
2022-04-20 14:07 ` Paolo Bonzini
2022-04-15 13:18 ` [PATCH 04/26] coroutine: " Paolo Bonzini
2022-04-19 18:25 ` Eric Blake
2022-04-21 10:26 ` Stefan Hajnoczi
2022-04-15 13:18 ` [PATCH 05/26] blkdebug: add missing " Paolo Bonzini
2022-04-19 18:46 ` Eric Blake
2022-04-15 13:18 ` [PATCH 06/26] blkverify: " Paolo Bonzini
2022-04-19 18:47 ` Eric Blake
2022-04-15 13:18 ` [PATCH 07/26] block: " Paolo Bonzini
2022-04-19 18:50 ` Eric Blake
2022-04-20 14:08 ` Paolo Bonzini
2022-04-15 13:18 ` [PATCH 08/26] file-posix: " Paolo Bonzini
2022-04-19 19:30 ` Eric Blake
2022-04-15 13:18 ` [PATCH 09/26] iscsi: " Paolo Bonzini
2022-04-19 19:43 ` Eric Blake
2022-04-15 13:18 ` [PATCH 10/26] nbd: " Paolo Bonzini
2022-04-26 20:26 ` Eric Blake
2022-04-15 13:18 ` [PATCH 11/26] nfs: " Paolo Bonzini
2022-04-15 13:18 ` [PATCH 12/26] nvme: " Paolo Bonzini
2022-04-15 13:18 ` [PATCH 13/26] parallels: " Paolo Bonzini
2022-04-15 13:18 ` [PATCH 14/26] qcow2: " Paolo Bonzini
2022-04-15 13:18 ` [PATCH 15/26] copy-before-write: " Paolo Bonzini
2022-04-15 13:18 ` [PATCH 16/26] curl: " Paolo Bonzini
2022-04-15 13:18 ` [PATCH 17/26] qed: " Paolo Bonzini
2022-04-15 13:18 ` [PATCH 18/26] quorum: " Paolo Bonzini
2022-04-15 13:18 ` [PATCH 19/26] throttle: " Paolo Bonzini
2022-04-15 13:18 ` [PATCH 20/26] vmdk: " Paolo Bonzini
2022-04-15 13:18 ` [PATCH 21/26] job: " Paolo Bonzini
2022-04-15 13:18 ` [PATCH 22/26] coroutine-lock: " Paolo Bonzini
2022-04-15 13:18 ` [PATCH 23/26] raw-format: " Paolo Bonzini
2022-04-15 13:18 ` [PATCH 24/26] 9p: " Paolo Bonzini
2022-04-18 11:08 ` Christian Schoenebeck
2022-04-15 13:18 ` [PATCH 25/26] migration: " Paolo Bonzini
2022-04-15 13:19 ` [PATCH 26/26] test-coroutine: " Paolo Bonzini
2022-04-21 10:35 ` [PATCH 00/19] block: fix " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220415131900.793161-1-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=malureau@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).