qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: i@yvt.jp, ysato@users.sourceforge.jp
Subject: [PATCH 4/4] target/rx: Swap stack pointers on clrpsw/setpsw instruction
Date: Sun, 17 Apr 2022 09:51:30 -0700	[thread overview]
Message-ID: <20220417165130.695085-5-richard.henderson@linaro.org> (raw)
In-Reply-To: <20220417165130.695085-1-richard.henderson@linaro.org>

We properly perform this swap in helper_set_psw for MVTC,
but we missed doing so for the CLRPSW/SETPSW of the U bit.

Reported-by: Tomoaki Kawada <i@yvt.jp>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/rx/translate.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/target/rx/translate.c b/target/rx/translate.c
index d8b9ef635c..b34f238790 100644
--- a/target/rx/translate.c
+++ b/target/rx/translate.c
@@ -2165,7 +2165,12 @@ static inline void clrsetpsw(DisasContext *ctx, int cb, int val)
             ctx->base.is_jmp = DISAS_UPDATE;
             break;
         case PSW_U:
-            tcg_gen_movi_i32(cpu_psw_u, val);
+            if (FIELD_EX32(ctx->tb_flags, PSW, U) != val) {
+                ctx->tb_flags = FIELD_DP32(ctx->tb_flags, PSW, U, val);
+                tcg_gen_movi_i32(cpu_psw_u, val);
+                tcg_gen_mov_i32(val ? cpu_isp : cpu_usp, cpu_sp);
+                tcg_gen_mov_i32(cpu_sp, val ? cpu_usp : cpu_isp);
+            }
             break;
         default:
             qemu_log_mask(LOG_GUEST_ERROR, "Invalid distination %d", cb);
-- 
2.25.1



  parent reply	other threads:[~2022-04-17 16:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-17 16:51 [PATCH 0/4] target/rx: Track PSW.U in tb->flags Richard Henderson
2022-04-17 16:51 ` [PATCH 1/4] target/rx: Put tb_flags into DisasContext Richard Henderson
2022-04-17 16:51 ` [PATCH 2/4] target/rx: Store PSW.U in tb->flags Richard Henderson
2022-04-17 16:51 ` [PATCH 3/4] target/rx: Move DISAS_UPDATE check for write to PSW Richard Henderson
2022-04-17 16:51 ` Richard Henderson [this message]
2022-04-19  7:40 ` [PATCH 0/4] target/rx: Track PSW.U in tb->flags Yoshinori Sato
2022-04-21 17:05   ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220417165130.695085-5-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=i@yvt.jp \
    --cc=qemu-devel@nongnu.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).