From: Sam Li <faithilikerun@gmail.com>
To: qemu-devel <qemu-devel@nongnu.org>
Cc: Dmitry Fomichev <Dmitry.Fomichev@wdc.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
Damien Le Moal <Damien.LeMoal@wdc.com>,
Sam Li <faithilikerun@gmail.com>, Hannes Reinecke <hare@suse.de>
Subject: [PATCH v3] Use io_uring_register_ring_fd() to skip fd operations
Date: Tue, 19 Apr 2022 07:33:31 +0800 [thread overview]
Message-ID: <20220418233331.7528-1-faithilikerun@gmail.com> (raw)
Linux recently added a new io_uring(7) optimization API that QEMU
doesn't take advantage of yet. The liburing library that QEMU uses
has added a corresponding new API calling io_uring_register_ring_fd().
When this API is called after creating the ring, the io_uring_submit()
library function passes a flag to the io_uring_enter(2) syscall
allowing it to skip the ring file descriptor fdget()/fdput()
operations. This saves some CPU cycles.
Signed-off-by: Sam Li <faithilikerun@gmail.com>
---
block/io_uring.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/block/io_uring.c b/block/io_uring.c
index 782afdb433..51f4834b69 100644
--- a/block/io_uring.c
+++ b/block/io_uring.c
@@ -435,8 +435,16 @@ LuringState *luring_init(Error **errp)
}
ioq_init(&s->io_q);
- return s;
+ if (io_uring_register_ring_fd(&s->ring) < 0) {
+ /*
+ * Only warn about this error: we will fallback to the non-optimized
+ * io_uring operations.
+ */
+ error_setg_errno(errp, errno,
+ "failed to register linux io_uring ring file descriptor");
+ }
+ return s;
}
void luring_cleanup(LuringState *s)
--
2.35.1
next reply other threads:[~2022-04-18 23:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-18 23:33 Sam Li [this message]
2022-04-21 13:36 ` [PATCH v3] Use io_uring_register_ring_fd() to skip fd operations Fam Zheng
2022-04-21 16:18 ` olc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220418233331.7528-1-faithilikerun@gmail.com \
--to=faithilikerun@gmail.com \
--cc=Damien.LeMoal@wdc.com \
--cc=Dmitry.Fomichev@wdc.com \
--cc=hare@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).