From: Eric Blake <eblake@redhat.com>
To: "Dirk Müller" <dmueller@suse.de>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH] Only advertise aio=io_uring if support is actually available
Date: Tue, 19 Apr 2022 14:23:08 -0500 [thread overview]
Message-ID: <20220419192308.bkcd2g7xah5ustfz@redhat.com> (raw)
In-Reply-To: <20220419171931.26192-1-dmueller@suse.de>
On Tue, Apr 19, 2022 at 07:19:31PM +0200, Dirk Müller wrote:
> This allows $qemu --help runtime configure checks for detecting
> the host support.
--help is human-parseable, and thus not stable text. Relying on it
for detecting host support is not always ideal, but anything is better
than nothing, so I'm not opposed to this patch.
Reviewed-by: Eric Blake <eblake@redhat.com>
Since qemu-nbd is affected, I'm happy to queue this through my NBD
tree now that 7.1 development has opened, if no one else queues it
elsewhere first.
>
> Signed-off-by: Dirk Müller <dmueller@suse.de>
> ---
> block/file-posix.c | 4 ++++
> qemu-nbd.c | 4 ++++
> qemu-options.hx | 6 +++++-
> 3 files changed, 13 insertions(+), 1 deletion(-)
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2022-04-19 19:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 17:19 [PATCH] Only advertise aio=io_uring if support is actually available Dirk Müller
2022-04-19 19:23 ` Eric Blake [this message]
2022-04-20 8:33 ` Daniel P. Berrangé
2022-04-21 16:51 ` Dirk Müller
2022-04-25 11:06 ` Dirk Müller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220419192308.bkcd2g7xah5ustfz@redhat.com \
--to=eblake@redhat.com \
--cc=dmueller@suse.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).