From: Alistair Francis <alistair.francis@opensource.wdc.com>
To: qemu-riscv@nongnu.org, qemu-devel@nongnu.org
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
Alistair Francis <alistair@alistair23.me>,
alistair23@gmail.com, Bin Meng <bin.meng@windriver.com>,
Alistair Francis <alistair.francis@wdc.com>,
qemu-arm@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
bmeng.cn@gmail.com,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Subject: [PATCH v4 6/6] hw/riscv: Enable TPM backends
Date: Wed, 20 Apr 2022 15:52:48 +1000 [thread overview]
Message-ID: <20220420055248.960491-7-alistair.francis@opensource.wdc.com> (raw)
In-Reply-To: <20220420055248.960491-1-alistair.francis@opensource.wdc.com>
From: Alistair Francis <alistair.francis@wdc.com>
Imply the TPM sysbus devices. This allows users to add TPM devices to
the RISC-V virt board.
This was tested by first creating an emulated TPM device:
swtpm socket --tpm2 -t -d --tpmstate dir=/tmp/tpm \
--ctrl type=unixio,path=swtpm-sock
Then launching QEMU with:
-chardev socket,id=chrtpm,path=swtpm-sock \
-tpmdev emulator,id=tpm0,chardev=chrtpm \
-device tpm-tis-device,tpmdev=tpm0
The TPM device can be seen in the memory tree and the generated device
tree.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/942
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@amd.com>
---
hw/riscv/virt.c | 4 ++++
hw/riscv/Kconfig | 1 +
2 files changed, 5 insertions(+)
diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c
index 6eed1f4d70..b62fd66a49 100644
--- a/hw/riscv/virt.c
+++ b/hw/riscv/virt.c
@@ -43,6 +43,7 @@
#include "sysemu/device_tree.h"
#include "sysemu/sysemu.h"
#include "sysemu/kvm.h"
+#include "sysemu/tpm.h"
#include "hw/pci/pci.h"
#include "hw/pci-host/gpex.h"
#include "hw/display/ramfb.h"
@@ -1612,6 +1613,9 @@ static void virt_machine_class_init(ObjectClass *oc, void *data)
hc->plug = virt_machine_device_plug_cb;
machine_class_allow_dynamic_sysbus_dev(mc, TYPE_RAMFB_DEVICE);
+#ifdef CONFIG_TPM
+ machine_class_allow_dynamic_sysbus_dev(mc, TYPE_TPM_TIS_SYSBUS);
+#endif
object_class_property_add_bool(oc, "aclint", virt_get_aclint,
virt_set_aclint);
diff --git a/hw/riscv/Kconfig b/hw/riscv/Kconfig
index da790f5936..79ff61c464 100644
--- a/hw/riscv/Kconfig
+++ b/hw/riscv/Kconfig
@@ -34,6 +34,7 @@ config RISCV_VIRT
imply PCI_DEVICES
imply VIRTIO_VGA
imply TEST_DEVICES
+ imply TPM_TIS_SYSBUS
select RISCV_NUMA
select GOLDFISH_RTC
select MSI_NONBROKEN
--
2.35.1
next prev parent reply other threads:[~2022-04-20 6:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 5:52 [PATCH v4 0/6] hw/riscv: Add TPM support to the virt board Alistair Francis
2022-04-20 5:52 ` [PATCH v4 1/6] hw/riscv: virt: Add a machine done notifier Alistair Francis
2022-04-21 8:33 ` Bin Meng
2022-04-20 5:52 ` [PATCH v4 2/6] hw/core: Move the ARM sysbus-fdt to core Alistair Francis
2022-04-21 8:39 ` Bin Meng
2022-04-20 5:52 ` [PATCH v4 3/6] hw/riscv: virt: Create a platform bus Alistair Francis
2022-04-22 1:42 ` Bin Meng
2022-04-20 5:52 ` [PATCH v4 4/6] hw/riscv: virt: Add support for generating platform FDT entries Alistair Francis
2022-04-22 1:50 ` Bin Meng
2022-04-20 5:52 ` [PATCH v4 5/6] hw/riscv: virt: Add device plug support Alistair Francis
2022-04-22 2:07 ` Bin Meng
2022-04-20 5:52 ` Alistair Francis [this message]
2022-04-22 2:13 ` [PATCH v4 6/6] hw/riscv: Enable TPM backends Bin Meng
2023-06-19 20:32 ` Guenter Roeck
2023-06-21 6:34 ` Guenter Roeck
2023-07-03 3:10 ` Alistair Francis
2022-04-21 2:19 ` [PATCH v4 0/6] hw/riscv: Add TPM support to the virt board Bin Meng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220420055248.960491-7-alistair.francis@opensource.wdc.com \
--to=alistair.francis@opensource.wdc.com \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=alistair@alistair23.me \
--cc=bin.meng@windriver.com \
--cc=bmeng.cn@gmail.com \
--cc=edgar.iglesias@gmail.com \
--cc=palmer@dabbelt.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).