From: Christoph Hellwig <hch@lst.de>
To: Klaus Jensen <its@irrelevant.dk>
Cc: qemu-block@nongnu.org, Klaus Jensen <k.jensen@samsung.com>,
qemu-devel@nongnu.org, Luis Chamberlain <mcgrof@kernel.org>,
Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 4/5] hw/nvme: do not auto-generate uuid
Date: Wed, 20 Apr 2022 08:53:34 +0200 [thread overview]
Message-ID: <20220420065334.GA3651@lst.de> (raw)
In-Reply-To: <Yl+fZI5kGW2wQ1DO@apples>
On Wed, Apr 20, 2022 at 07:51:32AM +0200, Klaus Jensen wrote:
> > So unlike the EUI, UUIDs are designed to be autogenerated even if the
> > current algorithm is completely broken. We'd just need to persist them.
> > Note that NVMe at least in theory requires providing at least on of
> > the unique identifiers, and the UUID is the only one designed to be
> > autogenerated in a distributed fashion.
>
> I understand, but it boils down to the fact that we do not have a
> general method of storing "metadata" like this persistently.
>
> But maybe it is time that we come up with something to do this.
If we can't make the persistent uniqueue identifiers persistent and
unique, we should not provide them. While NVMe does require a
namespace to report at least one of the three identifies, the failure
mode for now having one is much more graceful than providing one that
is not unique or not persistent.
next prev parent reply other threads:[~2022-04-20 6:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 12:10 [PATCH 0/5] hw/nvme: fix namespace identifiers Klaus Jensen
2022-04-19 12:10 ` [PATCH 1/5] hw/nvme: enforce common serial per subsystem Klaus Jensen
2022-04-20 5:20 ` Christoph Hellwig
2022-04-19 12:10 ` [PATCH 2/5] hw/nvme: always set eui64 Klaus Jensen
2022-04-20 5:30 ` Christoph Hellwig
2022-04-20 5:48 ` Klaus Jensen
2022-04-20 6:02 ` Klaus Jensen
2022-04-19 12:10 ` [PATCH 3/5] hw/nvme: do not report null uuid Klaus Jensen
2022-04-20 5:31 ` Christoph Hellwig
2022-04-19 12:10 ` [PATCH 4/5] hw/nvme: do not auto-generate uuid Klaus Jensen
2022-04-20 5:33 ` Christoph Hellwig
2022-04-20 5:51 ` Klaus Jensen
2022-04-20 6:53 ` Christoph Hellwig [this message]
2022-04-20 6:58 ` Klaus Jensen
2022-04-19 12:10 ` [PATCH 5/5] hw/nvme: bump firmware revision Klaus Jensen
2022-04-19 14:32 ` [PATCH 0/5] hw/nvme: fix namespace identifiers Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220420065334.GA3651@lst.de \
--to=hch@lst.de \
--cc=its@irrelevant.dk \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=mcgrof@kernel.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).