From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7EE73C433F5 for ; Wed, 20 Apr 2022 11:28:38 +0000 (UTC) Received: from localhost ([::1]:39912 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nh8Vh-000252-HJ for qemu-devel@archiver.kernel.org; Wed, 20 Apr 2022 07:28:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37806) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nh8GF-0005rA-AE for qemu-devel@nongnu.org; Wed, 20 Apr 2022 07:12:39 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:48622) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nh8GC-0005Sj-Dg for qemu-devel@nongnu.org; Wed, 20 Apr 2022 07:12:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650453155; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MoH1F68Nio/ptpxO0hniiNJtvPdodRrKSzA2Re64LVQ=; b=J8bOoG5OZGmyo0I0UYcv3qHBpCWb5lHVyi20AJvmJMyN1JKiT7bj9eMef36h+py/1OZWez 1f0Xy5/sdWr6+cEcs4y6l3AwTJVrVmJrxvaJA+lfMTNabaXYPM85XC+gQDh+EiTShA5Ckt 0vwXALtuU0SvnibEc5rM22jmgMtj++s= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-110-FSwpAa3PM1iLNZWTJj7hlA-1; Wed, 20 Apr 2022 07:12:30 -0400 X-MC-Unique: FSwpAa3PM1iLNZWTJj7hlA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AD3BF29AA3AF; Wed, 20 Apr 2022 11:12:29 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.9]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6A7BE40CFD06; Wed, 20 Apr 2022 11:12:29 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id DEBB1180009C; Wed, 20 Apr 2022 13:12:27 +0200 (CEST) Date: Wed, 20 Apr 2022 13:12:27 +0200 From: Gerd Hoffmann To: Ani Sinha Subject: Re: [PATCH] hw/i386/e820: remove legacy reserved entries for e820 Message-ID: <20220420111227.hc44fsmnlcpr5bof@sirius.home.kraxel.org> References: <20220420043904.1225153-1-ani@anisinha.ca> <20220420082636.jugea2h24qajh3zt@sirius.home.kraxel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 Received-SPF: pass client-ip=170.10.133.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , Sergio Lopez , "Michael S. Tsirkin" , Richard Henderson , qemu-devel@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Apr 20, 2022 at 02:25:54PM +0530, Ani Sinha wrote: > On Wed, Apr 20, 2022 at 1:57 PM Gerd Hoffmann wrote: > > > > On Wed, Apr 20, 2022 at 10:09:04AM +0530, Ani Sinha wrote: > > > e820 reserved entries were used before the dynamic entries with fw config files > > > were intoduced. Please see the following change: > > > 7d67110f2d9a6("pc: add etc/e820 fw_cfg file") > > > > > > Identical support was introduced into seabios as well with the following commit: > > > ce39bd4031820 ("Add support for etc/e820 fw_cfg file") > > > > > > Both the above commits are now quite old. QEMU machines 1.7 and newer no longer > > > use the reserved entries. Seabios uses fw config files and > > > > We still support machine types 1.6 & older (although they are > > deprecated already), so I think this has to wait until the 1.7 + older > > machine types are actually dropped. > > How much time does it need to pass before something is dropped after > depreciation? Two releases. Deprecated in January: f59fb1889f48 ("hw/i386/pc_piix: Mark the machine types from version 1.4 to 1.7 as deprecated"), so 7.0 and 7.1, in the 7.2 devel cycle they can be removed. Plus a bunch of followup cleanups like this patch. I think we can also drop the 128k seabios images then. take care, Gerd