From: Hanna Reitz <hreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Hanna Reitz <hreitz@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org
Subject: [PULL 1/8] tests/qemu-iotests/meson.build: Improve the indentation
Date: Wed, 20 Apr 2022 14:40:57 +0200 [thread overview]
Message-ID: <20220420124104.795836-2-hreitz@redhat.com> (raw)
In-Reply-To: <20220420124104.795836-1-hreitz@redhat.com>
From: Thomas Huth <thuth@redhat.com>
By using subdir_done(), we can get rid of one level of indentation
in this file. This will make it easier to add more conditions to
skip the iotests in future patches.
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20220223093840.2515281-3-thuth@redhat.com>
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
---
tests/qemu-iotests/meson.build | 61 ++++++++++++++++++----------------
1 file changed, 32 insertions(+), 29 deletions(-)
diff --git a/tests/qemu-iotests/meson.build b/tests/qemu-iotests/meson.build
index 9747bb68a5..92f09251a6 100644
--- a/tests/qemu-iotests/meson.build
+++ b/tests/qemu-iotests/meson.build
@@ -1,30 +1,33 @@
-if have_tools and targetos != 'windows' and not get_option('gprof')
- qemu_iotests_binaries = [qemu_img, qemu_io, qemu_nbd, qsd]
- qemu_iotests_env = {'PYTHON': python.full_path()}
- qemu_iotests_formats = {
- 'qcow2': 'quick',
- 'raw': 'slow',
- 'qed': 'thorough',
- 'vmdk': 'thorough',
- 'vpc': 'thorough'
- }
-
- foreach k, v : emulators
- if k.startswith('qemu-system-')
- qemu_iotests_binaries += v
- endif
- endforeach
- foreach format, speed: qemu_iotests_formats
- if speed == 'quick'
- suites = 'block'
- else
- suites = ['block-' + speed, speed]
- endif
- test('qemu-iotests ' + format, sh, args: [files('../check-block.sh'), format],
- depends: qemu_iotests_binaries, env: qemu_iotests_env,
- protocol: 'tap',
- suite: suites,
- timeout: 0,
- is_parallel: false)
- endforeach
+if not have_tools or targetos == 'windows' or get_option('gprof')
+ subdir_done()
endif
+
+qemu_iotests_binaries = [qemu_img, qemu_io, qemu_nbd, qsd]
+qemu_iotests_env = {'PYTHON': python.full_path()}
+qemu_iotests_formats = {
+ 'qcow2': 'quick',
+ 'raw': 'slow',
+ 'qed': 'thorough',
+ 'vmdk': 'thorough',
+ 'vpc': 'thorough'
+}
+
+foreach k, v : emulators
+ if k.startswith('qemu-system-')
+ qemu_iotests_binaries += v
+ endif
+endforeach
+
+foreach format, speed: qemu_iotests_formats
+ if speed == 'quick'
+ suites = 'block'
+ else
+ suites = ['block-' + speed, speed]
+ endif
+ test('qemu-iotests ' + format, sh, args: [files('../check-block.sh'), format],
+ depends: qemu_iotests_binaries, env: qemu_iotests_env,
+ protocol: 'tap',
+ suite: suites,
+ timeout: 0,
+ is_parallel: false)
+endforeach
--
2.35.1
next prev parent reply other threads:[~2022-04-20 12:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 12:40 [PULL 0/8] Block patches Hanna Reitz
2022-04-20 12:40 ` Hanna Reitz [this message]
2022-04-20 12:40 ` [PULL 2/8] tests/qemu-iotests: Move the bash and sanitizer checks to meson.build Hanna Reitz
2022-04-20 12:40 ` [PULL 3/8] iotests.py: Add supports_qcow2_zstd_compression() Hanna Reitz
2022-04-20 12:41 ` [PULL 4/8] iotests/065: Check for zstd support Hanna Reitz
2022-04-20 12:41 ` [PULL 5/8] iotests/303: " Hanna Reitz
2022-04-20 12:41 ` [PULL 6/8] qcow2: Improve refcount structure rebuilding Hanna Reitz
2022-04-20 12:41 ` [PULL 7/8] iotests/108: Test new refcount rebuild algorithm Hanna Reitz
2022-04-20 12:41 ` [PULL 8/8] qcow2: Add errp to rebuild_refcount_structure() Hanna Reitz
2022-04-20 18:12 ` [PULL 0/8] Block patches Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220420124104.795836-2-hreitz@redhat.com \
--to=hreitz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).