qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Hanna Reitz <hreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Hanna Reitz <hreitz@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	qemu-devel@nongnu.org
Subject: [PULL 3/8] iotests.py: Add supports_qcow2_zstd_compression()
Date: Wed, 20 Apr 2022 14:40:59 +0200	[thread overview]
Message-ID: <20220420124104.795836-4-hreitz@redhat.com> (raw)
In-Reply-To: <20220420124104.795836-1-hreitz@redhat.com>

Suggested-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
Message-Id: <20220323105522.53660-2-hreitz@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <v.sementsov-og@mail.ru>
---
 tests/qemu-iotests/iotests.py | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index fcec3e51e5..fe10a6cf05 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -1471,6 +1471,26 @@ def verify_working_luks():
     if not working:
         notrun(reason)
 
+def supports_qcow2_zstd_compression() -> bool:
+    img_file = f'{test_dir}/qcow2-zstd-test.qcow2'
+    res = qemu_img('create', '-f', 'qcow2', '-o', 'compression_type=zstd',
+                   img_file, '0',
+                   check=False)
+    try:
+        os.remove(img_file)
+    except OSError:
+        pass
+
+    if res.returncode == 1 and \
+            "'compression-type' does not accept value 'zstd'" in res.stdout:
+        return False
+    else:
+        return True
+
+def verify_qcow2_zstd_compression():
+    if not supports_qcow2_zstd_compression():
+        notrun('zstd compression not supported')
+
 def qemu_pipe(*args: str) -> str:
     """
     Run qemu with an option to print something and exit (e.g. a help option).
-- 
2.35.1



  parent reply	other threads:[~2022-04-20 12:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-20 12:40 [PULL 0/8] Block patches Hanna Reitz
2022-04-20 12:40 ` [PULL 1/8] tests/qemu-iotests/meson.build: Improve the indentation Hanna Reitz
2022-04-20 12:40 ` [PULL 2/8] tests/qemu-iotests: Move the bash and sanitizer checks to meson.build Hanna Reitz
2022-04-20 12:40 ` Hanna Reitz [this message]
2022-04-20 12:41 ` [PULL 4/8] iotests/065: Check for zstd support Hanna Reitz
2022-04-20 12:41 ` [PULL 5/8] iotests/303: " Hanna Reitz
2022-04-20 12:41 ` [PULL 6/8] qcow2: Improve refcount structure rebuilding Hanna Reitz
2022-04-20 12:41 ` [PULL 7/8] iotests/108: Test new refcount rebuild algorithm Hanna Reitz
2022-04-20 12:41 ` [PULL 8/8] qcow2: Add errp to rebuild_refcount_structure() Hanna Reitz
2022-04-20 18:12 ` [PULL 0/8] Block patches Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220420124104.795836-4-hreitz@redhat.com \
    --to=hreitz@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).