qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: peter.maydell@linaro.org, richard.henderson@linaro.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	qemu-devel@nongnu.org, "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [PULL 14/25] tests/tcg: remove CONFIG_USER_ONLY from config-target.mak
Date: Wed, 20 Apr 2022 19:08:21 +0100	[thread overview]
Message-ID: <20220420180832.3812543-15-alex.bennee@linaro.org> (raw)
In-Reply-To: <20220420180832.3812543-1-alex.bennee@linaro.org>

From: Paolo Bonzini <pbonzini@redhat.com>

Just check the target name instead.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20220401141326.1244422-12-pbonzini@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220419091020.3008144-15-alex.bennee@linaro.org>

diff --git a/tests/tcg/Makefile.target b/tests/tcg/Makefile.target
index acda5bcec2..c75e8d983f 100644
--- a/tests/tcg/Makefile.target
+++ b/tests/tcg/Makefile.target
@@ -34,7 +34,7 @@ all:
 -include ../config-$(TARGET).mak
 
 # Get semihosting definitions for user-mode emulation
-ifeq ($(CONFIG_USER_ONLY),y)
+ifeq ($(filter %-softmmu, $(TARGET)),)
 -include $(SRC_PATH)/configs/targets/$(TARGET).mak
 endif
 
@@ -44,7 +44,7 @@ COMMA := ,
 quiet-command = $(if $(V),$1,$(if $(2),@printf "  %-7s %s\n" $2 $3 && $1, @$1))
 
 # $1 = test name, $2 = cmd, $3 = desc
-ifdef CONFIG_USER_ONLY
+ifeq ($(filter %-softmmu, $(TARGET)),)
 run-test = $(call quiet-command, timeout --foreground $(TIMEOUT) $2 > $1.out, \
 	"TEST",$3)
 else
@@ -91,7 +91,7 @@ QEMU_OPTS=
 #   90s    with --enable-tcg-interpreter
 TIMEOUT=90
 
-ifdef CONFIG_USER_ONLY
+ifeq ($(filter %-softmmu, $(TARGET)),)
 # The order we include is important. We include multiarch first and
 # then the target. If there are common tests shared between
 # sub-targets (e.g. ARM & AArch64) then it is up to
@@ -153,7 +153,7 @@ extract-plugin = $(wordlist 2, 2, $(subst -with-, ,$1))
 
 RUN_TESTS+=$(EXTRA_RUNS)
 
-ifdef CONFIG_USER_ONLY
+ifeq ($(filter %-softmmu, $(TARGET)),)
 run-%: %
 	$(call run-test, $<, $(QEMU) $(QEMU_OPTS) $<, "$< on $(TARGET_NAME)")
 
diff --git a/tests/tcg/configure.sh b/tests/tcg/configure.sh
index 57026b5899..0d864c24fc 100755
--- a/tests/tcg/configure.sh
+++ b/tests/tcg/configure.sh
@@ -225,18 +225,12 @@ for target in $target_list; do
   echo "TARGET_NAME=$arch" >> $config_target_mak
   echo "target=$target" >> $config_target_mak
   case $target in
-    *-linux-user)
-      echo "CONFIG_USER_ONLY=y" >> $config_target_mak
-      echo "QEMU=$PWD/qemu-$arch" >> $config_target_mak
-      ;;
-    *-bsd-user)
-      echo "CONFIG_USER_ONLY=y" >> $config_target_mak
-      echo "QEMU=$PWD/qemu-$arch" >> $config_target_mak
-      ;;
     *-softmmu)
-      echo "CONFIG_SOFTMMU=y" >> $config_target_mak
       echo "QEMU=$PWD/qemu-system-$arch" >> $config_target_mak
       ;;
+    *-linux-user|*-bsd-user)
+      echo "QEMU=$PWD/qemu-$arch" >> $config_target_mak
+      ;;
   esac
 
   eval "target_compiler_cflags=\${cross_cc_cflags_$arch}"
-- 
2.30.2



  parent reply	other threads:[~2022-04-20 19:03 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-20 18:08 [PULL 00/25] Various testing, doc and gdbstub fixes Alex Bennée
2022-04-20 18:08 ` [PULL 01/25] tests/avocado: update aarch64_virt test to exercise -cpu max Alex Bennée
2022-04-20 18:08 ` [PULL 02/25] docs/devel: add some notes on the binfmt-image-debian targets Alex Bennée
2022-04-20 18:08 ` [PULL 03/25] docs/devel: drop :hidden: and :includehidden: tags Alex Bennée
2022-04-20 18:08 ` [PULL 04/25] tests/docker: remove dead code for linux-user containers Alex Bennée
2022-04-20 18:08 ` [PULL 05/25] tests/docker: remove test targets Alex Bennée
2022-04-20 18:08 ` [PULL 06/25] tests/docker: remove dead variable Alex Bennée
2022-04-20 18:08 ` [PULL 07/25] tests/docker: remove unnecessary default definitions Alex Bennée
2022-04-20 18:08 ` [PULL 08/25] tests/docker: inline variable definitions or move close to use Alex Bennée
2022-04-20 18:08 ` [PULL 09/25] tests/docker: remove unnecessary filtering of $(DOCKER_IMAGES) Alex Bennée
2022-04-20 18:08 ` [PULL 10/25] tests/docker: simplify docker-TEST@IMAGE targets Alex Bennée
2022-04-20 18:08 ` [PULL 11/25] tests/docker: do not duplicate rules for hexagon-cross Alex Bennée
2022-04-20 18:08 ` [PULL 12/25] tests/tcg: add compiler test variables when using containers Alex Bennée
2022-04-20 18:08 ` [PULL 13/25] tests/tcg: remove CONFIG_LINUX_USER from config-target.mak Alex Bennée
2022-04-20 18:08 ` Alex Bennée [this message]
2022-04-20 18:08 ` [PULL 15/25] tests/tcg: prepare Makefile.prereqs at configure time Alex Bennée
2022-04-20 18:08 ` [PULL 16/25] tests/tcg: list test targets in Makefile.prereqs Alex Bennée
2022-04-20 18:08 ` [PULL 17/25] tests/tcg: invoke Makefile.target directly from QEMU's makefile Alex Bennée
2022-04-20 18:08 ` [PULL 18/25] tests/tcg: isolate from QEMU's config-host.mak Alex Bennée
2022-04-20 18:08 ` [PULL 19/25] tests/docker: remove SKIP_DOCKER_BUILD Alex Bennée
2022-04-20 18:08 ` [PULL 20/25] tests/tcg: fix non-static build Alex Bennée
2022-04-20 18:08 ` [PULL 21/25] tests/tcg: remove duplicate sha512-sse case Alex Bennée
2022-04-20 18:08 ` [PULL 22/25] tests/tcg: add float_convd test Alex Bennée
2022-04-20 18:08 ` [PULL 23/25] tests/tcg: add missing reference files for float_convs Alex Bennée
2022-04-20 18:08 ` [PULL 24/25] target/i386: fix byte swap issue with XMM register access Alex Bennée
2022-04-20 18:08 ` [PULL 25/25] tests/guest-debug: better handle gdb crashes Alex Bennée
2022-04-20 19:46 ` [PULL 00/25] Various testing, doc and gdbstub fixes Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220420180832.3812543-15-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=f4bug@amsat.org \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).