From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, peterx@redhat.com, berrange@redhat.com
Cc: quintela@redhat.com
Subject: [PULL 02/18] tests: support QTEST_TRACE env variable
Date: Thu, 21 Apr 2022 17:40:27 +0100 [thread overview]
Message-ID: <20220421164043.209703-3-dgilbert@redhat.com> (raw)
In-Reply-To: <20220421164043.209703-1-dgilbert@redhat.com>
From: Daniel P. Berrangé <berrange@redhat.com>
When debugging failing qtests it is useful to be able to turn on trace
output to stderr. The QTEST_TRACE env variable contents get injected
as a '-trace <str>' command line arg
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220310171821.3724080-4-berrange@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
tests/qtest/libqtest.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c
index 7b5890dcc4..ac89b80d11 100644
--- a/tests/qtest/libqtest.c
+++ b/tests/qtest/libqtest.c
@@ -259,6 +259,9 @@ QTestState *qtest_init_without_qmp_handshake(const char *extra_args)
gchar *qmp_socket_path;
gchar *command;
const char *qemu_binary = qtest_qemu_binary();
+ const char *trace = g_getenv("QTEST_TRACE");
+ g_autofree char *tracearg = trace ?
+ g_strdup_printf("-trace %s ", trace) : g_strdup("");
s = g_new(QTestState, 1);
@@ -281,14 +284,15 @@ QTestState *qtest_init_without_qmp_handshake(const char *extra_args)
qtest_add_abrt_handler(kill_qemu_hook_func, s);
- command = g_strdup_printf("exec %s "
+ command = g_strdup_printf("exec %s %s"
"-qtest unix:%s "
"-qtest-log %s "
"-chardev socket,path=%s,id=char0 "
"-mon chardev=char0,mode=control "
"-display none "
"%s"
- " -accel qtest", qemu_binary, socket_path,
+ " -accel qtest",
+ qemu_binary, tracearg, socket_path,
getenv("QTEST_LOG") ? "/dev/fd/2" : "/dev/null",
qmp_socket_path,
extra_args ?: "");
--
2.35.1
next prev parent reply other threads:[~2022-04-21 17:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 16:40 [PULL 00/18] migration queue Dr. David Alan Gilbert (git)
2022-04-21 16:40 ` [PULL 01/18] tests: improve error message when saving TLS PSK file fails Dr. David Alan Gilbert (git)
2022-04-21 16:40 ` Dr. David Alan Gilbert (git) [this message]
2022-04-21 16:40 ` [PULL 03/18] tests: print newline after QMP response in qtest logs Dr. David Alan Gilbert (git)
2022-04-21 16:40 ` [PULL 04/18] migration: fix use of TLS PSK credentials with a UNIX socket Dr. David Alan Gilbert (git)
2022-04-21 16:40 ` [PULL 05/18] tests: switch MigrateStart struct to be stack allocated Dr. David Alan Gilbert (git)
2022-04-21 16:40 ` [PULL 06/18] tests: merge code for UNIX and TCP migration pre-copy tests Dr. David Alan Gilbert (git)
2022-04-21 16:40 ` [PULL 07/18] tests: introduce ability to provide hooks for migration precopy test Dr. David Alan Gilbert (git)
2022-04-21 16:40 ` [PULL 08/18] tests: switch migration FD passing test to use common precopy helper Dr. David Alan Gilbert (git)
2022-04-21 16:40 ` [PULL 09/18] tests: expand the migration precopy helper to support failures Dr. David Alan Gilbert (git)
2022-04-21 16:40 ` [PULL 10/18] migration: Postpone releasing MigrationState.hostname Dr. David Alan Gilbert (git)
2022-04-21 16:40 ` [PULL 11/18] migration: Drop multifd tls_hostname cache Dr. David Alan Gilbert (git)
2022-04-21 16:40 ` [PULL 12/18] migration: Add pss.postcopy_requested status Dr. David Alan Gilbert (git)
2022-04-21 16:40 ` [PULL 13/18] migration: Move migrate_allow_multifd and helpers into migration.c Dr. David Alan Gilbert (git)
2022-04-21 16:40 ` [PULL 14/18] migration: Export ram_load_postcopy() Dr. David Alan Gilbert (git)
2022-04-21 16:40 ` [PULL 15/18] migration: Move channel setup out of postcopy_try_recover() Dr. David Alan Gilbert (git)
2022-04-21 16:40 ` [PULL 16/18] migration: Allow migrate-recover to run multiple times Dr. David Alan Gilbert (git)
2022-04-21 16:40 ` [PULL 17/18] migration: Fix operator type Dr. David Alan Gilbert (git)
2022-04-21 16:40 ` [PULL 18/18] migration: Read state once Dr. David Alan Gilbert (git)
2022-04-21 18:44 ` [PULL 00/18] migration queue Dr. David Alan Gilbert
-- strict thread matches above, loose matches on Subject: below --
2022-04-21 18:40 Dr. David Alan Gilbert (git)
2022-04-21 18:40 ` [PULL 02/18] tests: support QTEST_TRACE env variable Dr. David Alan Gilbert (git)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220421164043.209703-3-dgilbert@redhat.com \
--to=dgilbert@redhat.com \
--cc=berrange@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).