From: Eric Blake <eblake@redhat.com>
To: "Dirk Müller" <dmueller@suse.de>
Cc: berrange@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH v2] Only advertise aio=io_uring if support is actually available
Date: Thu, 21 Apr 2022 14:27:55 -0500 [thread overview]
Message-ID: <20220421192755.eksb7rfapjsw7qmb@redhat.com> (raw)
In-Reply-To: <20220421165048.12608-1-dmueller@suse.de>
On Thu, Apr 21, 2022 at 06:50:48PM +0200, Dirk Müller wrote:
> Change --help output for aio option to only list the aio backend options that
> are actually available. io_uring is an optional, linux only backend
> option so hide it for cases where it isn't there.
As pointed out by Dan, this commit message is not quite accurate. It
hides only one of the two conditional options, but 'native' is also a
Linux-only optional backend (CONFIG_LINUX_AIO).
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Dirk Müller <dmueller@suse.de>
> ---
> block/file-posix.c | 4 ++++
> qemu-nbd.c | 4 ++++
> qemu-options.hx | 6 +++++-
> 3 files changed, 13 insertions(+), 1 deletion(-)
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2022-04-21 19:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 16:50 [PATCH v2] Only advertise aio=io_uring if support is actually available Dirk Müller
2022-04-21 19:27 ` Eric Blake [this message]
2022-04-22 20:30 ` Eric Blake
2022-04-25 11:19 ` Daniel P. Berrangé
2022-04-25 22:04 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220421192755.eksb7rfapjsw7qmb@redhat.com \
--to=eblake@redhat.com \
--cc=berrange@redhat.com \
--cc=dmueller@suse.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).