From: Igor Mammedov <imammedo@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: marcel@redhat.com, qemu-devel@nongnu.org,
Eric Ren <renzhengeek@gmail.com>
Subject: Re: Is it possible to support hotplug device to PXB bridge?
Date: Fri, 22 Apr 2022 10:57:45 +0200 [thread overview]
Message-ID: <20220422105745.7a20256e@redhat.com> (raw)
In-Reply-To: <YmJnYCMxG1S9pt4U@redhat.com>
On Fri, 22 Apr 2022 09:29:20 +0100
Daniel P. Berrangé <berrange@redhat.com> wrote:
> On Fri, Apr 22, 2022 at 03:17:11PM +0800, Eric Ren wrote:
> > Hi Marcel and all,
> >
> > It fails when I want to hotplug device to PXB bus. Then, I find this
> > commit that explicitely declares the fact that PXB bus does not support
> > hotplug device onto it.
> >
> > 7b346c742cd9 ("hw/pxb: declare pxb devices as not hot-pluggable")
> >
> > Could you please help confirm the possibility to make PXB bus hotpluggable,
> > and the main work to achieve it if possible?
>
> Instead of trying to hotplug into the PXB, attach a 'pci-bridge' to the
> PXB and then you can hotplug into the latter instead.
there is no ACPI based hotplug for devices on pxb if I'm not mistaken, so
you'll likely need to enable shpc on pci-bridge.
> > Yes, pxb-pcie with Q35 do support hotplug, but we use i440 machine a long way,
> > not willing to change machine type to have it.
>
> With regards,
> Daniel
next prev parent reply other threads:[~2022-04-22 9:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 7:17 Is it possible to support hotplug device to PXB bridge? Eric Ren
2022-04-22 8:29 ` Daniel P. Berrangé
2022-04-22 8:57 ` Igor Mammedov [this message]
2022-04-22 9:33 ` Eric Ren
2022-04-22 11:51 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220422105745.7a20256e@redhat.com \
--to=imammedo@redhat.com \
--cc=berrange@redhat.com \
--cc=marcel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=renzhengeek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).