qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gavin Shan <gshan@redhat.com>
To: qemu-arm@nongnu.org
Cc: lvivier@redhat.com, eduardo@habkost.net, thuth@redhat.com,
	berrange@redhat.com, peter.maydell@linaro.org, armbru@redhat.com,
	mst@redhat.com, qemu-devel@nongnu.org, zhenyzha@redhat.com,
	drjones@redhat.com, pbonzini@redhat.com, shan.gavin@gmail.com,
	Jonathan.Cameron@Huawei.com, ani@anisinha.ca,
	imammedo@redhat.com, wangyanan55@huawei.com, eblake@redhat.com,
	f4bug@amsat.org
Subject: [PATCH v8 0/5] hw/arm/virt: Fix CPU's default NUMA node ID
Date: Mon, 25 Apr 2022 11:27:57 +0800	[thread overview]
Message-ID: <20220425032802.365061-1-gshan@redhat.com> (raw)

When the CPU-to-NUMA association isn't provided by user, the default NUMA
node ID for the specific CPU is returned from virt_get_default_cpu_node_id().
Unfortunately, the default NUMA node ID breaks socket boundary and leads to
the broken CPU topology warning message in Linux guest. This series intends
to fix the issue.

  PATCH[1/5] Add cluster-id to CPU instance property
  PATCH[2/5] Fixes test failure in qtest/numa-test/aarch64_numa_cpu()
  PATCH[3/5] Uses SMP configuration to populate CPU topology
  PATCH[4/5] Fixes the broken CPU topology by considering the socket boundary
             when the default NUMA node ID is given
  PATCH[5/5] Uses the populated CPU topology to build PPTT table, instead of
             calculate it again

Changelog
=========
v8:
   * Separate PATCH[v8 2/5] to fix test failure in qtest/
     numa-test/aarch64_numa_cpu()                               (Igor)
   * Improvents to coding style, changelog and comments         (Yanan)
v6/v7:
   * Fixed description for 'cluster-id' and 'core-id'           (Yanan)
   * Remove '% ms->smp.sockets' in socket ID calculation        (Yanan)
   * Fixed tests/qtest/numa-test/aarch64_numa_cpu()             (Yanan)
   * Initialized offset variables in build_pptt()               (Jonathan)
   * Added comments about the expected and sorted layout of
     cpus[n].props.*_id and assert() on the exceptional cases   (Igor)
v4/v5:
   * Split PATCH[v3 1/3] to PATCH[v5 1/4] and PATCH[v5 2/4].
     Verify or dump 'clsuter-id' in various spots               (Yanan)
   * s/within cluster/within cluster\/die/ for 'core-id' in
     qapi/machine.json                                          (Igor)
   * Apply '% ms->smp.{sockets, clusters, cores, threads} in
     virt_possible_cpu_arch_ids() as x86 does                   (Igor)
   * Use [0 - possible_cpus->len] as ACPI processor UID to
     build PPTT table and PATCH[v3 4/4] is dropped              (Igor)
   * Simplified build_pptt() to add all entries in one loop
     on ms->possible_cpus                                       (Igor)
v3:
   * Split PATCH[v2 1/3] to PATCH[v3 1/4] and PATCH[v3 2/4]     (Yanan)
   * Don't take account of die ID in CPU topology population
     and added assert(!mc->smp_props.dies_supported)            (Yanan/Igor)
   * Assign cluster_id and use it when building PPTT table      (Yanan/Igor)
v2:
   * Populate the CPU topology in virt_possible_cpu_arch_ids()
     so that it can be reused in virt_get_default_cpu_node_id() (Igor)
   * Added PATCH[2/3] to use the existing CPU topology when the
     PPTT table is built                                        (Igor)
   * Added PATCH[3/3] to take thread ID as ACPI processor ID
     in MADT and SRAT table                                     (Gavin)

Gavin Shan (5):
  qapi/machine.json: Add cluster-id
  qtest/numa-test: Specify CPU topology in aarch64_numa_cpu()
  hw/arm/virt: Consider SMP configuration in CPU topology
  hw/arm/virt: Fix CPU's default NUMA node ID
  hw/acpi/aml-build: Use existing CPU topology to build PPTT table

 hw/acpi/aml-build.c        | 111 ++++++++++++++++---------------------
 hw/arm/virt.c              |  19 ++++++-
 hw/core/machine-hmp-cmds.c |   4 ++
 hw/core/machine.c          |  16 ++++++
 qapi/machine.json          |   6 +-
 tests/qtest/numa-test.c    |   3 +-
 6 files changed, 91 insertions(+), 68 deletions(-)

-- 
2.23.0



             reply	other threads:[~2022-04-25  3:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-25  3:27 Gavin Shan [this message]
2022-04-25  3:27 ` [PATCH v8 1/5] qapi/machine.json: Add cluster-id Gavin Shan
2022-05-03  8:54   ` Igor Mammedov
2022-04-25  3:27 ` [PATCH v8 2/5] qtest/numa-test: Specify CPU topology in aarch64_numa_cpu() Gavin Shan
2022-05-02  8:52   ` Igor Mammedov
2022-05-02 10:07     ` Gavin Shan
2022-05-03  8:54       ` Igor Mammedov
2022-05-03 13:47         ` Gavin Shan
2022-04-25  3:28 ` [PATCH v8 3/5] hw/arm/virt: Consider SMP configuration in CPU topology Gavin Shan
2022-05-03  8:56   ` Igor Mammedov
2022-04-25  3:28 ` [PATCH v8 4/5] hw/arm/virt: Fix CPU's default NUMA node ID Gavin Shan
2022-04-25  3:28 ` [PATCH v8 5/5] hw/acpi/aml-build: Use existing CPU topology to build PPTT table Gavin Shan
2022-05-02  7:43 ` [PATCH v8 0/5] hw/arm/virt: Fix CPU's default NUMA node ID Gavin Shan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220425032802.365061-1-gshan@redhat.com \
    --to=gshan@redhat.com \
    --cc=Jonathan.Cameron@Huawei.com \
    --cc=ani@anisinha.ca \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=drjones@redhat.com \
    --cc=eblake@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=f4bug@amsat.org \
    --cc=imammedo@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=shan.gavin@gmail.com \
    --cc=thuth@redhat.com \
    --cc=wangyanan55@huawei.com \
    --cc=zhenyzha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).