From: Hanna Reitz <hreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Hanna Reitz <hreitz@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org
Subject: [PULL 05/14] iotests/040: Don't check image pattern on zero-length image
Date: Mon, 25 Apr 2022 16:08:12 +0200 [thread overview]
Message-ID: <20220425140821.957511-6-hreitz@redhat.com> (raw)
In-Reply-To: <20220425140821.957511-1-hreitz@redhat.com>
From: John Snow <jsnow@redhat.com>
qemu-io fails on read/write beyond end-of-file on raw images, so skip
these invocations when running the zero-length image tests.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
Message-Id: <20220418211504.943969-5-jsnow@redhat.com>
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
---
tests/qemu-iotests/040 | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/040 b/tests/qemu-iotests/040
index adf5815781..c4a90937dc 100755
--- a/tests/qemu-iotests/040
+++ b/tests/qemu-iotests/040
@@ -86,8 +86,10 @@ class TestSingleDrive(ImageCommitTestCase):
qemu_img('create', '-f', iotests.imgfmt,
'-o', 'backing_file=%s' % mid_img,
'-F', iotests.imgfmt, test_img)
- qemu_io('-f', 'raw', '-c', 'write -P 0xab 0 524288', backing_img)
- qemu_io('-f', iotests.imgfmt, '-c', 'write -P 0xef 524288 524288', mid_img)
+ if self.image_len:
+ qemu_io('-f', 'raw', '-c', 'write -P 0xab 0 524288', backing_img)
+ qemu_io('-f', iotests.imgfmt, '-c', 'write -P 0xef 524288 524288',
+ mid_img)
self.vm = iotests.VM().add_drive(test_img, "node-name=top,backing.node-name=mid,backing.backing.node-name=base", interface="none")
self.vm.add_device('virtio-scsi')
self.vm.add_device("scsi-hd,id=scsi0,drive=drive0")
@@ -101,11 +103,15 @@ class TestSingleDrive(ImageCommitTestCase):
def test_commit(self):
self.run_commit_test(mid_img, backing_img)
+ if not self.image_len:
+ return
qemu_io('-f', 'raw', '-c', 'read -P 0xab 0 524288', backing_img)
qemu_io('-f', 'raw', '-c', 'read -P 0xef 524288 524288', backing_img)
def test_commit_node(self):
self.run_commit_test("mid", "base", node_names=True)
+ if not self.image_len:
+ return
qemu_io('-f', 'raw', '-c', 'read -P 0xab 0 524288', backing_img)
qemu_io('-f', 'raw', '-c', 'read -P 0xef 524288 524288', backing_img)
@@ -192,11 +198,15 @@ class TestSingleDrive(ImageCommitTestCase):
def test_top_is_active(self):
self.run_commit_test(test_img, backing_img, need_ready=True)
+ if not self.image_len:
+ return
qemu_io('-f', 'raw', '-c', 'read -P 0xab 0 524288', backing_img)
qemu_io('-f', 'raw', '-c', 'read -P 0xef 524288 524288', backing_img)
def test_top_is_default_active(self):
self.run_default_commit_test()
+ if not self.image_len:
+ return
qemu_io('-f', 'raw', '-c', 'read -P 0xab 0 524288', backing_img)
qemu_io('-f', 'raw', '-c', 'read -P 0xef 524288 524288', backing_img)
--
2.35.1
next prev parent reply other threads:[~2022-04-25 14:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 14:08 [PULL 00/14] Block patches Hanna Reitz
2022-04-25 14:08 ` [PULL 01/14] block: add 'force' parameter to 'blockdev-change-medium' command Hanna Reitz
2022-04-25 14:08 ` [PULL 02/14] iotests: replace calls to log(qemu_io(...)) with qemu_io_log() Hanna Reitz
2022-04-25 14:08 ` [PULL 03/14] iotests/163: Fix broken qemu-io invocation Hanna Reitz
2022-04-25 14:08 ` [PULL 04/14] iotests: Don't check qemu_io() output for specific error strings Hanna Reitz
2022-04-25 14:08 ` Hanna Reitz [this message]
2022-04-25 14:08 ` [PULL 06/14] iotests/040: Fix TestCommitWithFilters test Hanna Reitz
2022-04-25 14:08 ` [PULL 07/14] iotests: create generic qemu_tool() function Hanna Reitz
2022-04-25 14:08 ` [PULL 08/14] iotests: rebase qemu_io() on top of qemu_tool() Hanna Reitz
2022-04-25 14:08 ` [PULL 09/14] iotests/migration-permissions: use assertRaises() for qemu_io() negative test Hanna Reitz
2022-04-25 14:08 ` [PULL 10/14] iotests/image-fleecing: switch to qemu_io() Hanna Reitz
2022-04-25 14:08 ` [PULL 11/14] iotests: remove qemu_io_pipe_and_status() Hanna Reitz
2022-04-25 14:08 ` [PULL 12/14] iotests: remove qemu_io_silent() and qemu_io_silent_check() Hanna Reitz
2022-04-25 14:08 ` [PULL 13/14] iotests: make qemu_io_log() check return codes by default Hanna Reitz
2022-04-25 14:08 ` [PULL 14/14] iotests/108: Fix when missing user_allow_other Hanna Reitz
2022-04-25 23:32 ` [PULL 00/14] Block patches Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220425140821.957511-6-hreitz@redhat.com \
--to=hreitz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).