From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Thomas Huth" <thuth@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Beraldo Leal" <bleal@redhat.com>,
libvir-list@redhat.com,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: [PULL 3/3] github: fix config mistake preventing repo lockdown commenting
Date: Tue, 26 Apr 2022 16:13:23 +0100 [thread overview]
Message-ID: <20220426151323.729982-4-berrange@redhat.com> (raw)
In-Reply-To: <20220426151323.729982-1-berrange@redhat.com>
The previous commit updated the repo lockdown config to the new
format:
commit 9b89cdb2a5064a87b8a7172fa1748d46aa37a9df
Author: Alex Bennée <alex.bennee@linaro.org>
Date: Mon Oct 4 16:43:08 2021 +0100
.github: move repo lockdown to the v2 configuration
Unfortunately the config key names used were wrong, resulting in
the repo lockdown throwing warnings:
Unexpected input(s) 'pull-comment', 'lock-pull', 'close-pull',
valid inputs are ['github-token', 'exclude-issue-created-before',
'exclude-issue-labels', 'issue-labels', 'issue-comment',
'skip-closed-issue-comment', 'close-issue', 'lock-issue',
'issue-lock-reason', 'exclude-pr-created-before', 'exclude-pr-labels',
'pr-labels', 'pr-comment', 'skip-closed-pr-comment', 'close-pr',
'lock-pr', 'pr-lock-reason', 'process-only', 'log-output']
It still locked down the pull requests, due to its default config,
but didn't leave the friendly message explaining why.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
.github/workflows/lockdown.yml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/.github/workflows/lockdown.yml b/.github/workflows/lockdown.yml
index ad8b8f7e30..d5e1265cff 100644
--- a/.github/workflows/lockdown.yml
+++ b/.github/workflows/lockdown.yml
@@ -15,7 +15,7 @@ jobs:
steps:
- uses: dessant/repo-lockdown@v2
with:
- pull-comment: |
+ pr-comment: |
Thank you for your interest in the QEMU project.
This repository is a read-only mirror of the project's repostories hosted
@@ -26,5 +26,5 @@ jobs:
functionality). However, we get a lot of patches, and so we have some
guidelines about contributing on the project website:
https://www.qemu.org/contribute/
- lock-pull: true
- close-pull: true
+ lock-pr: true
+ close-pr: true
--
2.35.1
next prev parent reply other threads:[~2022-04-26 15:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 15:13 [PULL 0/3] Misc next patches Daniel P. Berrangé
2022-04-26 15:13 ` [PULL 1/3] softmmu: remove deprecated --enable-fips option Daniel P. Berrangé
2022-04-26 15:13 ` [PULL 2/3] hw/char: fix qcode array bounds check in ESCC impl Daniel P. Berrangé
2022-04-26 15:13 ` Daniel P. Berrangé [this message]
2022-04-26 20:12 ` [PULL 0/3] Misc next patches Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220426151323.729982-4-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=bleal@redhat.com \
--cc=f4bug@amsat.org \
--cc=kraxel@redhat.com \
--cc=libvir-list@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).