From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A86BAC433F5 for ; Wed, 27 Apr 2022 13:23:09 +0000 (UTC) Received: from localhost ([::1]:48940 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njhdM-00008Z-Ko for qemu-devel@archiver.kernel.org; Wed, 27 Apr 2022 09:23:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40750) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njhcV-0006yP-VI for qemu-devel@nongnu.org; Wed, 27 Apr 2022 09:22:15 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:24194) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njhcU-0004qi-Cr for qemu-devel@nongnu.org; Wed, 27 Apr 2022 09:22:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651065733; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2ckfhVhBLiMJ9Sywvnz7hqGxGxUB/RN7XHO8epgFHUo=; b=g6kiwmXMr+klTJOY9W73LyAUk2u9ij2QJgPEK8M0vQhgBrrHWjdbWbbsVJuBHNpjQ2BpTP Zcy+RFxuaZh+UxVbFAkNCgLon4cuDoKz0PXrmdh79mAdgoXRamOIu4tcWTWQK4ZbtJ/BpM R+sdCR0PkD/ekb8tYp1oissr8uiNqbE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-86-iME_wu2gOPmgnesFTrX3Bw-1; Wed, 27 Apr 2022 09:22:12 -0400 X-MC-Unique: iME_wu2gOPmgnesFTrX3Bw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B740894EC40; Wed, 27 Apr 2022 13:22:11 +0000 (UTC) Received: from redhat.com (unknown [10.2.16.160]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2DF08401A992; Wed, 27 Apr 2022 13:22:11 +0000 (UTC) Date: Wed, 27 Apr 2022 08:22:09 -0500 From: Eric Blake To: Hanna Reitz Subject: Re: [PATCH 3/4] Revert "main-loop: Disable GLOBAL_STATE_CODE() assertions" Message-ID: <20220427132209.ckzrv27kc242ffld@redhat.com> References: <20220427114057.36651-1-hreitz@redhat.com> <20220427114057.36651-4-hreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220427114057.36651-4-hreitz@redhat.com> User-Agent: NeoMutt/20220415-26-c08bba X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Received-SPF: pass client-ip=170.10.133.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Emanuele Giuseppe Esposito , qemu-devel@nongnu.org, qemu-block@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Apr 27, 2022 at 01:40:56PM +0200, Hanna Reitz wrote: > This reverts commit b1c073490553f80594b903ceedfc7c1aef6b1b19. (We > wanted to do so once the 7.1 tree opens, which has happened. The issue > reported in https://gitlab.com/qemu-project/qemu/-/issues/945 should be > fixed by the preceding patches.) > > Signed-off-by: Hanna Reitz > --- > include/qemu/main-loop.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Eric Blake [Here's hoping we don't have to re-disable it because it finds more bugs - but maximizing the soak time during development with it enabled is good] -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org