qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Nir Soffer <nsoffer@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	qemu-stable@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: [PATCH 3/6] virtio-scsi: clean up virtio_scsi_handle_event_vq()
Date: Wed, 27 Apr 2022 15:35:38 +0100	[thread overview]
Message-ID: <20220427143541.119567-4-stefanha@redhat.com> (raw)
In-Reply-To: <20220427143541.119567-1-stefanha@redhat.com>

virtio_scsi_handle_event_vq() is only called from hw/scsi/virtio-scsi.c
now and its return value is no longer used. Remove the function
prototype from virtio-scsi.h and drop the return value.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 include/hw/virtio/virtio-scsi.h | 1 -
 hw/scsi/virtio-scsi.c           | 4 +---
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virtio/virtio-scsi.h
index 543681bc18..5957597825 100644
--- a/include/hw/virtio/virtio-scsi.h
+++ b/include/hw/virtio/virtio-scsi.h
@@ -151,7 +151,6 @@ void virtio_scsi_common_realize(DeviceState *dev,
                                 Error **errp);
 
 void virtio_scsi_common_unrealize(DeviceState *dev);
-bool virtio_scsi_handle_event_vq(VirtIOSCSI *s, VirtQueue *vq);
 bool virtio_scsi_handle_cmd_vq(VirtIOSCSI *s, VirtQueue *vq);
 bool virtio_scsi_handle_ctrl_vq(VirtIOSCSI *s, VirtQueue *vq);
 void virtio_scsi_init_req(VirtIOSCSI *s, VirtQueue *vq, VirtIOSCSIReq *req);
diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c
index 417fbc71d6..aa03a713d8 100644
--- a/hw/scsi/virtio-scsi.c
+++ b/hw/scsi/virtio-scsi.c
@@ -856,13 +856,11 @@ void virtio_scsi_push_event(VirtIOSCSI *s, SCSIDevice *dev,
     virtio_scsi_complete_req(req);
 }
 
-bool virtio_scsi_handle_event_vq(VirtIOSCSI *s, VirtQueue *vq)
+static void virtio_scsi_handle_event_vq(VirtIOSCSI *s, VirtQueue *vq)
 {
     if (s->events_dropped) {
         virtio_scsi_push_event(s, NULL, VIRTIO_SCSI_T_NO_EVENT, 0);
-        return true;
     }
-    return false;
 }
 
 static void virtio_scsi_handle_event(VirtIODevice *vdev, VirtQueue *vq)
-- 
2.35.1



  parent reply	other threads:[~2022-04-27 14:41 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-27 14:35 [PATCH 0/6] virtio-scsi: fix 100% CPU consumption in IOThread Stefan Hajnoczi
2022-04-27 14:35 ` [PATCH 1/6] virtio-scsi: fix ctrl and event handler functions in dataplane mode Stefan Hajnoczi
2022-04-27 19:47   ` Michael Tokarev
2022-04-28  9:05     ` Stefan Hajnoczi
2022-04-28 23:18   ` Paolo Bonzini
2022-04-27 14:35 ` [PATCH 2/6] virtio-scsi: don't waste CPU polling the event virtqueue Stefan Hajnoczi
2022-04-27 20:12   ` Nir Soffer
2022-04-28  9:05     ` Stefan Hajnoczi
2022-04-28 23:17   ` Paolo Bonzini
2022-04-30  5:52     ` Stefan Hajnoczi
2022-04-27 14:35 ` Stefan Hajnoczi [this message]
2022-04-28 23:17   ` [PATCH 3/6] virtio-scsi: clean up virtio_scsi_handle_event_vq() Paolo Bonzini
2022-04-27 14:35 ` [PATCH 4/6] virtio-scsi: clean up virtio_scsi_handle_ctrl_vq() Stefan Hajnoczi
2022-04-28 23:17   ` Paolo Bonzini
2022-04-27 14:35 ` [PATCH 5/6] virtio-scsi: clean up virtio_scsi_handle_cmd_vq() Stefan Hajnoczi
2022-04-28 23:17   ` Paolo Bonzini
2022-04-27 14:35 ` [PATCH 6/6] virtio-scsi: move request-related items from .h to .c Stefan Hajnoczi
2022-04-28 23:17   ` Paolo Bonzini
2022-05-09  9:45 ` [PATCH 0/6] virtio-scsi: fix 100% CPU consumption in IOThread Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220427143541.119567-4-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=nsoffer@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).