qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>
Subject: [PULL 10/18] configure: move --enable/--disable-debug-info to second option parsing pass
Date: Thu, 28 Apr 2022 08:53:27 +0200	[thread overview]
Message-ID: <20220428065335.189795-11-pbonzini@redhat.com> (raw)
In-Reply-To: <20220428065335.189795-1-pbonzini@redhat.com>

$debug_info is not needed anywhere except in the final meson invocation,
no need to special case it.

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 configure | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/configure b/configure
index e404b55da5..d704029284 100755
--- a/configure
+++ b/configure
@@ -244,7 +244,6 @@ audio_drv_list="default"
 block_drv_rw_whitelist=""
 block_drv_ro_whitelist=""
 host_cc="cc"
-debug_info="yes"
 lto="false"
 stack_protector=""
 safe_stack=""
@@ -304,6 +303,7 @@ vhost_user_fs="$default_feature"
 vhost_vdpa="$default_feature"
 rdma="$default_feature"
 pvrdma="$default_feature"
+debug_info="yes"
 debug_tcg="no"
 debug="no"
 sanitizers="no"
@@ -379,10 +379,6 @@ for opt do
   ;;
   --extra-ldflags=*) EXTRA_LDFLAGS="$EXTRA_LDFLAGS $optarg"
   ;;
-  --enable-debug-info) debug_info="yes"
-  ;;
-  --disable-debug-info) debug_info="no"
-  ;;
   --cross-cc-*[!a-zA-Z0-9_-]*=*) error_exit "Passed bad --cross-cc-FOO option"
   ;;
   --cross-cc-cflags-*) cc_arch=${opt#--cross-cc-cflags-}; cc_arch=${cc_arch%%=*}
@@ -759,12 +755,12 @@ for opt do
   ;;
   --extra-ldflags=*)
   ;;
-  --enable-debug-info)
-  ;;
-  --disable-debug-info)
-  ;;
   --cross-cc-*)
   ;;
+  --enable-debug-info) debug_info="yes"
+  ;;
+  --disable-debug-info) debug_info="no"
+  ;;
   --enable-modules)
       modules="yes"
   ;;
-- 
2.35.1




  parent reply	other threads:[~2022-04-28  7:30 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-28  6:53 [PULL 00/18] Misc QEMU patches for 2022-04-28 Paolo Bonzini
2022-04-28  6:53 ` [PULL 01/18] error-report: fix g_date_time_format assertion Paolo Bonzini
2022-04-28  6:53 ` [PULL 02/18] configure: make fortify_source=yes by default Paolo Bonzini
2022-04-28  6:53 ` [PULL 03/18] remove -writeconfig Paolo Bonzini
2022-04-28  6:53 ` [PULL 04/18] i386: pcmpestr 64-bit sign extension bug Paolo Bonzini
2022-04-28  6:53 ` [PULL 05/18] meson: show final set of compiler flags Paolo Bonzini
2022-04-28  6:53 ` [PULL 06/18] configure: remove dead code Paolo Bonzini
2022-04-28  6:53 ` [PULL 07/18] qga: wixl: get path to sysroot from pkg-config as intended Paolo Bonzini
2022-04-28  6:53 ` [PULL 08/18] configure: pc-bios/qemu-icon.bmp does not exist Paolo Bonzini
2022-04-28  6:53 ` [PULL 09/18] configure: gcov should not exclude fortify-source Paolo Bonzini
2022-04-28  6:53 ` Paolo Bonzini [this message]
2022-04-28  6:53 ` [PULL 11/18] configure, meson: move OpenGL check to meson Paolo Bonzini
2022-04-28  6:53 ` [PULL 12/18] meson, configure: move RDMA options " Paolo Bonzini
2022-04-28  6:53 ` [PULL 13/18] meson, configure: move keyctl test " Paolo Bonzini
2022-04-28  6:53 ` [PULL 14/18] meson, configure: move usbfs " Paolo Bonzini
2022-04-28  6:53 ` [PULL 15/18] meson, configure: move libgio " Paolo Bonzini
2022-04-28  6:53 ` [PULL 16/18] meson: remove CONFIG_XEN_PCI_PASSTHROUGH from config-target.h Paolo Bonzini
2022-04-28  6:53 ` [PULL 17/18] meson, configure: move --enable-module-upgrades to meson Paolo Bonzini
2022-04-28  6:53 ` [PULL 18/18] qemu-options: Limit the -enable-kvm option to the targets that support it Paolo Bonzini
2022-04-28 15:33 ` [PULL 00/18] Misc QEMU patches for 2022-04-28 Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220428065335.189795-11-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).