From: Dongwon Kim <dongwon.kim@intel.com>
To: qemu-devel@nongnu.org, dongwon.kim@intel.com, philmd@redhat.com,
kraxel@redhat.com, pbonzini@redhat.com
Cc: Vivek Kasireddy <vivek.kasireddy@intel.com>
Subject: [PATCH 1/3] ui/gtk: new param monitor to specify target monitor for launching QEMU
Date: Thu, 28 Apr 2022 16:13:02 -0700 [thread overview]
Message-ID: <20220428231304.19472-2-dongwon.kim@intel.com> (raw)
In-Reply-To: <20220428231304.19472-1-dongwon.kim@intel.com>
Introducing a new integer parameter to specify the monitor where the
Qemu window is placed upon launching.
Monitor can be any number between 0 and (total number of monitors - 1).
It can be used together with full-screen=on, which will make the QEMU
window full-screened on the targeted monitor.
v2: fixed typos and updated commit subject and msg
(Philippe Mathieu-Daudé)
changed param name to monitor, removed unnecessary condition check
on the parameter
(Paolo Bonzini)
v3: updated Since version to 7.1 for monitor parameter
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Vivek Kasireddy <vivek.kasireddy@intel.com>
Signed-off-by: Dongwon Kim <dongwon.kim@intel.com>
---
qapi/ui.json | 6 +++++-
qemu-options.hx | 2 +-
ui/gtk.c | 8 ++++++++
3 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/qapi/ui.json b/qapi/ui.json
index 059302a5ef..ddcea7349b 100644
--- a/qapi/ui.json
+++ b/qapi/ui.json
@@ -1204,13 +1204,17 @@
# assuming the guest will resize the display to match
# the window size then. Otherwise it defaults to "off".
# Since 3.1
+# @monitor: Indicate monitor where QEMU window is lauched. monitor
+# could be any number from 0 to (total num of monitors - 1).
+# since 7.1
#
# Since: 2.12
#
##
{ 'struct' : 'DisplayGTK',
'data' : { '*grab-on-hover' : 'bool',
- '*zoom-to-fit' : 'bool' } }
+ '*zoom-to-fit' : 'bool',
+ '*monitor' : 'uint32' } }
##
# @DisplayEGLHeadless:
diff --git a/qemu-options.hx b/qemu-options.hx
index 5f69b94b8e..dbf9b223dd 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -1908,7 +1908,7 @@ DEF("display", HAS_ARG, QEMU_OPTION_display,
#endif
#if defined(CONFIG_GTK)
"-display gtk[,full-screen=on|off][,gl=on|off][,grab-on-hover=on|off]\n"
- " [,show-cursor=on|off][,window-close=on|off]\n"
+ " [,monitor=<value>][,show-cursor=on|off][,window-close=on|off]\n"
#endif
#if defined(CONFIG_VNC)
"-display vnc=<display>[,<optargs>]\n"
diff --git a/ui/gtk.c b/ui/gtk.c
index c57c36749e..d9971d65ac 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -2375,6 +2375,14 @@ static void gtk_display_init(DisplayState *ds, DisplayOptions *opts)
vc && vc->type == GD_VC_VTE);
#endif
+ if (opts->u.gtk.has_monitor &&
+ opts->u.gtk.monitor < gdk_display_get_n_monitors(window_display)) {
+ GdkRectangle mon_dest;
+ gdk_monitor_get_geometry(
+ gdk_display_get_monitor(window_display, opts->u.gtk.monitor),
+ &mon_dest);
+ gtk_window_move(GTK_WINDOW(s->window), mon_dest.x, mon_dest.y);
+ }
if (opts->has_full_screen &&
opts->full_screen) {
gtk_menu_item_activate(GTK_MENU_ITEM(s->full_screen_item));
--
2.30.2
next prev parent reply other threads:[~2022-04-28 23:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 23:13 [PATCH 0/3] ui/gtk: new options, monitor and detach-all Dongwon Kim
2022-04-28 23:13 ` Dongwon Kim [this message]
2022-05-03 9:15 ` [PATCH 1/3] ui/gtk: new param monitor to specify target monitor for launching QEMU Daniel P. Berrangé
2022-05-03 23:14 ` Dongwon Kim
2022-05-09 21:31 ` Dongwon Kim
2022-05-10 10:58 ` Gerd Hoffmann
2022-05-17 7:46 ` Markus Armbruster
2022-04-28 23:13 ` [PATCH 2/3] ui/gtk: detach_all option for making all VCs detached upon starting Dongwon Kim
2022-05-03 9:12 ` Daniel P. Berrangé
2022-05-03 23:21 ` Dongwon Kim
2022-05-04 8:28 ` Daniel P. Berrangé
2022-04-28 23:13 ` [PATCH 3/3] ui/gtk: specify detached window's size and location Dongwon Kim
2022-05-03 9:17 ` Daniel P. Berrangé
2022-05-03 23:33 ` Dongwon Kim
2022-05-06 16:34 ` Daniel P. Berrangé
2022-05-06 17:05 ` Dongwon Kim
2022-05-31 20:33 ` [PATCH 0/3] ui/gtk: new options, monitor and detach-all Dongwon Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220428231304.19472-2-dongwon.kim@intel.com \
--to=dongwon.kim@intel.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vivek.kasireddy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).