From: Alistair Francis <alistair.francis@opensource.wdc.com>
To: qemu-devel@nongnu.org
Cc: alistair23@gmail.com, Alistair Francis <alistair.francis@wdc.com>,
"Edgar E . Iglesias" <edgar.iglesias@amd.com>,
Bin Meng <bmeng.cn@gmail.com>
Subject: [PULL 25/25] hw/riscv: Enable TPM backends
Date: Fri, 29 Apr 2022 14:31:19 +1000 [thread overview]
Message-ID: <20220429043119.1478881-26-alistair.francis@opensource.wdc.com> (raw)
In-Reply-To: <20220429043119.1478881-1-alistair.francis@opensource.wdc.com>
From: Alistair Francis <alistair.francis@wdc.com>
Imply the TPM sysbus devices. This allows users to add TPM devices to
the RISC-V virt board.
This was tested by first creating an emulated TPM device:
swtpm socket --tpm2 -t -d --tpmstate dir=/tmp/tpm \
--ctrl type=unixio,path=swtpm-sock
Then launching QEMU with:
-chardev socket,id=chrtpm,path=swtpm-sock \
-tpmdev emulator,id=tpm0,chardev=chrtpm \
-device tpm-tis-device,tpmdev=tpm0
The TPM device can be seen in the memory tree and the generated device
tree.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/942
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@amd.com>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Message-Id: <20220427234146.1130752-7-alistair.francis@opensource.wdc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
---
docs/system/riscv/virt.rst | 20 ++++++++++++++++++++
hw/riscv/virt.c | 4 ++++
hw/riscv/Kconfig | 1 +
3 files changed, 25 insertions(+)
diff --git a/docs/system/riscv/virt.rst b/docs/system/riscv/virt.rst
index 1272b6659e..f8ecec95f3 100644
--- a/docs/system/riscv/virt.rst
+++ b/docs/system/riscv/virt.rst
@@ -162,3 +162,23 @@ The minimal QEMU commands to run U-Boot SPL are:
To test 32-bit U-Boot images, switch to use qemu-riscv32_smode_defconfig and
riscv32_spl_defconfig builds, and replace ``qemu-system-riscv64`` with
``qemu-system-riscv32`` in the command lines above to boot the 32-bit U-Boot.
+
+Enabling TPM
+------------
+
+A TPM device can be connected to the virt board by following the steps below.
+
+First launch the TPM emulator
+
+ swtpm socket --tpm2 -t -d --tpmstate dir=/tmp/tpm \
+ --ctrl type=unixio,path=swtpm-sock
+
+Then launch QEMU with:
+
+ ...
+ -chardev socket,id=chrtpm,path=swtpm-sock \
+ -tpmdev emulator,id=tpm0,chardev=chrtpm \
+ -device tpm-tis-device,tpmdev=tpm0
+
+The TPM device can be seen in the memory tree and the generated device
+tree and should be accessible from the guest software.
diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c
index 035c6fb581..3326f4db96 100644
--- a/hw/riscv/virt.c
+++ b/hw/riscv/virt.c
@@ -43,6 +43,7 @@
#include "sysemu/device_tree.h"
#include "sysemu/sysemu.h"
#include "sysemu/kvm.h"
+#include "sysemu/tpm.h"
#include "hw/pci/pci.h"
#include "hw/pci-host/gpex.h"
#include "hw/display/ramfb.h"
@@ -1617,6 +1618,9 @@ static void virt_machine_class_init(ObjectClass *oc, void *data)
hc->plug = virt_machine_device_plug_cb;
machine_class_allow_dynamic_sysbus_dev(mc, TYPE_RAMFB_DEVICE);
+#ifdef CONFIG_TPM
+ machine_class_allow_dynamic_sysbus_dev(mc, TYPE_TPM_TIS_SYSBUS);
+#endif
object_class_property_add_bool(oc, "aclint", virt_get_aclint,
virt_set_aclint);
diff --git a/hw/riscv/Kconfig b/hw/riscv/Kconfig
index da790f5936..79ff61c464 100644
--- a/hw/riscv/Kconfig
+++ b/hw/riscv/Kconfig
@@ -34,6 +34,7 @@ config RISCV_VIRT
imply PCI_DEVICES
imply VIRTIO_VGA
imply TEST_DEVICES
+ imply TPM_TIS_SYSBUS
select RISCV_NUMA
select GOLDFISH_RTC
select MSI_NONBROKEN
--
2.35.1
next prev parent reply other threads:[~2022-04-29 5:00 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 4:30 [PULL 00/25] riscv-to-apply queue Alistair Francis
2022-04-29 4:30 ` [PULL 01/25] hw/riscv: spike: Add '/chosen/stdout-path' in device tree unconditionally Alistair Francis
2022-04-29 4:30 ` [PULL 02/25] hw/riscv: Don't add empty bootargs to device tree Alistair Francis
2022-04-29 4:30 ` [PULL 03/25] target/riscv: Support configuarable marchid, mvendorid, mipid CSR values Alistair Francis
2022-04-29 4:30 ` [PULL 04/25] target/riscv: rvk: add cfg properties for zbk* and zk* Alistair Francis
2022-04-29 4:30 ` [PULL 05/25] target/riscv: rvk: add support for zbkb extension Alistair Francis
2022-04-29 4:31 ` [PULL 06/25] target/riscv: rvk: add support for zbkc extension Alistair Francis
2022-04-29 4:31 ` [PULL 07/25] target/riscv: rvk: add support for zbkx extension Alistair Francis
2022-04-29 4:31 ` [PULL 08/25] crypto: move sm4_sbox from target/arm Alistair Francis
2022-04-29 4:31 ` [PULL 09/25] target/riscv: rvk: add support for zknd/zkne extension in RV32 Alistair Francis
2022-04-29 4:31 ` [PULL 10/25] target/riscv: rvk: add support for zkne/zknd extension in RV64 Alistair Francis
2022-04-29 4:31 ` [PULL 11/25] target/riscv: rvk: add support for sha256 related instructions in zknh extension Alistair Francis
2022-04-29 4:31 ` [PULL 12/25] target/riscv: rvk: add support for sha512 related instructions for RV32 " Alistair Francis
2022-04-29 4:31 ` [PULL 13/25] target/riscv: rvk: add support for sha512 related instructions for RV64 " Alistair Francis
2022-04-29 4:31 ` [PULL 14/25] target/riscv: rvk: add support for zksed/zksh extension Alistair Francis
2022-04-29 4:31 ` [PULL 15/25] target/riscv: rvk: add CSR support for Zkr Alistair Francis
2022-04-29 4:31 ` [PULL 16/25] disas/riscv.c: rvk: add disas support for Zbk* and Zk* instructions Alistair Francis
2022-04-29 4:31 ` [PULL 17/25] target/riscv: rvk: expose zbk* and zk* properties Alistair Francis
2022-04-29 4:31 ` [PULL 18/25] target/riscv: Fix incorrect PTE merge in walk_pte Alistair Francis
2022-04-29 4:31 ` [PULL 19/25] target/riscv: add scalar crypto related extenstion strings to isa_string Alistair Francis
2022-04-29 4:31 ` [PULL 20/25] hw/riscv: virt: Add a machine done notifier Alistair Francis
2022-04-29 4:31 ` [PULL 21/25] hw/core: Move the ARM sysbus-fdt to core Alistair Francis
2022-04-29 4:31 ` [PULL 22/25] hw/riscv: virt: Create a platform bus Alistair Francis
2022-04-29 4:31 ` [PULL 23/25] hw/riscv: virt: Add support for generating platform FDT entries Alistair Francis
2022-04-29 4:31 ` [PULL 24/25] hw/riscv: virt: Add device plug support Alistair Francis
2022-04-29 4:31 ` Alistair Francis [this message]
2022-04-29 21:51 ` [PULL 00/25] riscv-to-apply queue Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220429043119.1478881-26-alistair.francis@opensource.wdc.com \
--to=alistair.francis@opensource.wdc.com \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=bmeng.cn@gmail.com \
--cc=edgar.iglesias@amd.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).