qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1 0/1] aspeed/hace: Support AST1030 HACE
@ 2022-05-03  2:27 Steven Lee
  2022-05-03  2:27 ` [PATCH v1 1/1] " Steven Lee
  0 siblings, 1 reply; 3+ messages in thread
From: Steven Lee @ 2022-05-03  2:27 UTC (permalink / raw)
  To: Cédric Le Goater, Peter Maydell, Andrew Jeffery,
	Joel Stanley, open list:ASPEED BMCs,
	open list:All patches CC here
  Cc: steven_lee, troy_lee, jamin_lin

Per ast1030_v7.pdf, AST1030 HACE engine is identical to AST2600's HACE
engine.

Please help to review.

Thanks,
Steven

Based-on: 20220426021120.28255-3-steven_lee@aspeedtech.com
([v6,2/3] aspeed/hace: Support AST2600 HACE)

Steven Lee (1):
  aspeed/hace: Support AST1030 HACE

 hw/misc/aspeed_hace.c         | 20 ++++++++++++++++++++
 include/hw/misc/aspeed_hace.h |  2 ++
 2 files changed, 22 insertions(+)

-- 
2.17.1



^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v1 1/1] aspeed/hace: Support AST1030 HACE
  2022-05-03  2:27 [PATCH v1 0/1] aspeed/hace: Support AST1030 HACE Steven Lee
@ 2022-05-03  2:27 ` Steven Lee
  2022-05-03  5:15   ` Cédric Le Goater
  0 siblings, 1 reply; 3+ messages in thread
From: Steven Lee @ 2022-05-03  2:27 UTC (permalink / raw)
  To: Cédric Le Goater, Peter Maydell, Andrew Jeffery,
	Joel Stanley, open list:ASPEED BMCs,
	open list:All patches CC here
  Cc: steven_lee, troy_lee, jamin_lin

Per ast1030_v7.pdf, AST1030 HACE engine is identical to AST2600's HACE
engine.

Signed-off-by: Steven Lee <steven_lee@aspeedtech.com>
---
 hw/misc/aspeed_hace.c         | 20 ++++++++++++++++++++
 include/hw/misc/aspeed_hace.h |  2 ++
 2 files changed, 22 insertions(+)

diff --git a/hw/misc/aspeed_hace.c b/hw/misc/aspeed_hace.c
index 10f00e65f4..91f3c0b208 100644
--- a/hw/misc/aspeed_hace.c
+++ b/hw/misc/aspeed_hace.c
@@ -378,11 +378,31 @@ static const TypeInfo aspeed_ast2600_hace_info = {
     .class_init = aspeed_ast2600_hace_class_init,
 };
 
+static void aspeed_ast1030_hace_class_init(ObjectClass *klass, void *data)
+{
+    DeviceClass *dc = DEVICE_CLASS(klass);
+    AspeedHACEClass *ahc = ASPEED_HACE_CLASS(klass);
+
+    dc->desc = "AST1030 Hash and Crypto Engine";
+
+    ahc->src_mask = 0x7FFFFFFF;
+    ahc->dest_mask = 0x7FFFFFF8;
+    ahc->key_mask = 0x7FFFFFF8;
+    ahc->hash_mask = 0x00147FFF;
+}
+
+static const TypeInfo aspeed_ast1030_hace_info = {
+    .name = TYPE_ASPEED_AST1030_HACE,
+    .parent = TYPE_ASPEED_HACE,
+    .class_init = aspeed_ast1030_hace_class_init,
+};
+
 static void aspeed_hace_register_types(void)
 {
     type_register_static(&aspeed_ast2400_hace_info);
     type_register_static(&aspeed_ast2500_hace_info);
     type_register_static(&aspeed_ast2600_hace_info);
+    type_register_static(&aspeed_ast1030_hace_info);
     type_register_static(&aspeed_hace_info);
 }
 
diff --git a/include/hw/misc/aspeed_hace.h b/include/hw/misc/aspeed_hace.h
index 94d5ada95f..e9d3563a05 100644
--- a/include/hw/misc/aspeed_hace.h
+++ b/include/hw/misc/aspeed_hace.h
@@ -15,6 +15,8 @@
 #define TYPE_ASPEED_AST2400_HACE TYPE_ASPEED_HACE "-ast2400"
 #define TYPE_ASPEED_AST2500_HACE TYPE_ASPEED_HACE "-ast2500"
 #define TYPE_ASPEED_AST2600_HACE TYPE_ASPEED_HACE "-ast2600"
+#define TYPE_ASPEED_AST1030_HACE TYPE_ASPEED_HACE "-ast1030"
+
 OBJECT_DECLARE_TYPE(AspeedHACEState, AspeedHACEClass, ASPEED_HACE)
 
 #define ASPEED_HACE_NR_REGS (0x64 >> 2)
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v1 1/1] aspeed/hace: Support AST1030 HACE
  2022-05-03  2:27 ` [PATCH v1 1/1] " Steven Lee
@ 2022-05-03  5:15   ` Cédric Le Goater
  0 siblings, 0 replies; 3+ messages in thread
From: Cédric Le Goater @ 2022-05-03  5:15 UTC (permalink / raw)
  To: Steven Lee, Peter Maydell, Andrew Jeffery, Joel Stanley,
	open list:ASPEED BMCs, open list:All patches CC here
  Cc: troy_lee, jamin_lin

On 5/3/22 04:27, Steven Lee wrote:
> Per ast1030_v7.pdf, AST1030 HACE engine is identical to AST2600's HACE
> engine.
> 
> Signed-off-by: Steven Lee <steven_lee@aspeedtech.com>

Reviewed-by: Cédric Le Goater <clg@kaod.org>

Thanks

C.

> ---
>   hw/misc/aspeed_hace.c         | 20 ++++++++++++++++++++
>   include/hw/misc/aspeed_hace.h |  2 ++
>   2 files changed, 22 insertions(+)
> 
> diff --git a/hw/misc/aspeed_hace.c b/hw/misc/aspeed_hace.c
> index 10f00e65f4..91f3c0b208 100644
> --- a/hw/misc/aspeed_hace.c
> +++ b/hw/misc/aspeed_hace.c
> @@ -378,11 +378,31 @@ static const TypeInfo aspeed_ast2600_hace_info = {
>       .class_init = aspeed_ast2600_hace_class_init,
>   };
>   
> +static void aspeed_ast1030_hace_class_init(ObjectClass *klass, void *data)
> +{
> +    DeviceClass *dc = DEVICE_CLASS(klass);
> +    AspeedHACEClass *ahc = ASPEED_HACE_CLASS(klass);
> +
> +    dc->desc = "AST1030 Hash and Crypto Engine";
> +
> +    ahc->src_mask = 0x7FFFFFFF;
> +    ahc->dest_mask = 0x7FFFFFF8;
> +    ahc->key_mask = 0x7FFFFFF8;
> +    ahc->hash_mask = 0x00147FFF;
> +}
> +
> +static const TypeInfo aspeed_ast1030_hace_info = {
> +    .name = TYPE_ASPEED_AST1030_HACE,
> +    .parent = TYPE_ASPEED_HACE,
> +    .class_init = aspeed_ast1030_hace_class_init,
> +};
> +
>   static void aspeed_hace_register_types(void)
>   {
>       type_register_static(&aspeed_ast2400_hace_info);
>       type_register_static(&aspeed_ast2500_hace_info);
>       type_register_static(&aspeed_ast2600_hace_info);
> +    type_register_static(&aspeed_ast1030_hace_info);
>       type_register_static(&aspeed_hace_info);
>   }
>   
> diff --git a/include/hw/misc/aspeed_hace.h b/include/hw/misc/aspeed_hace.h
> index 94d5ada95f..e9d3563a05 100644
> --- a/include/hw/misc/aspeed_hace.h
> +++ b/include/hw/misc/aspeed_hace.h
> @@ -15,6 +15,8 @@
>   #define TYPE_ASPEED_AST2400_HACE TYPE_ASPEED_HACE "-ast2400"
>   #define TYPE_ASPEED_AST2500_HACE TYPE_ASPEED_HACE "-ast2500"
>   #define TYPE_ASPEED_AST2600_HACE TYPE_ASPEED_HACE "-ast2600"
> +#define TYPE_ASPEED_AST1030_HACE TYPE_ASPEED_HACE "-ast1030"
> +
>   OBJECT_DECLARE_TYPE(AspeedHACEState, AspeedHACEClass, ASPEED_HACE)
>   
>   #define ASPEED_HACE_NR_REGS (0x64 >> 2)



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-05-03  5:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-03  2:27 [PATCH v1 0/1] aspeed/hace: Support AST1030 HACE Steven Lee
2022-05-03  2:27 ` [PATCH v1 1/1] " Steven Lee
2022-05-03  5:15   ` Cédric Le Goater

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).