From: Hanna Reitz <hreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Hanna Reitz <hreitz@redhat.com>,
Kevin Wolf <kwolf@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Eric Blake <eblake@redhat.com>
Subject: [PATCH 2/4] block: Add protocol-specific image info
Date: Tue, 3 May 2022 16:55:27 +0200 [thread overview]
Message-ID: <20220503145529.37070-3-hreitz@redhat.com> (raw)
In-Reply-To: <20220503145529.37070-1-hreitz@redhat.com>
The ImageInfo object currently only contains (optional) format-specific
image information. However, perhaps the protocol node can provide some
additional information, so add a new field presenting it.
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
---
qapi/block-core.json | 6 +++++-
block/qapi.c | 19 +++++++++++++++++++
2 files changed, 24 insertions(+), 1 deletion(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index beeb91952a..e7d6c2e0cc 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -236,6 +236,9 @@
# @format-specific: structure supplying additional format-specific
# information (since 1.7)
#
+# @protocol-specific: structure supplying additional protocol-specific
+# information (since 7.1)
+#
# Since: 1.3
#
##
@@ -246,7 +249,8 @@
'*backing-filename': 'str', '*full-backing-filename': 'str',
'*backing-filename-format': 'str', '*snapshots': ['SnapshotInfo'],
'*backing-image': 'ImageInfo',
- '*format-specific': 'ImageInfoSpecific' } }
+ '*format-specific': 'ImageInfoSpecific',
+ '*protocol-specific': 'ImageInfoSpecific' } }
##
# @ImageCheck:
diff --git a/block/qapi.c b/block/qapi.c
index 51202b470a..293983cf82 100644
--- a/block/qapi.c
+++ b/block/qapi.c
@@ -262,6 +262,7 @@ void bdrv_query_image_info(BlockDriverState *bs,
int64_t size;
const char *backing_filename;
BlockDriverInfo bdi;
+ BlockDriverState *protocol_bs;
int ret;
Error *err = NULL;
ImageInfo *info;
@@ -303,6 +304,24 @@ void bdrv_query_image_info(BlockDriverState *bs,
}
info->has_format_specific = info->format_specific != NULL;
+ /* Try to look for an unambiguous protocol node */
+ protocol_bs = bs;
+ while (protocol_bs && !QLIST_EMPTY(&protocol_bs->children)) {
+ protocol_bs = bdrv_primary_bs(protocol_bs);
+ }
+ if (protocol_bs) {
+ /* Assert that this is a protocol node */
+ assert(QLIST_EMPTY(&protocol_bs->children));
+
+ info->protocol_specific = bdrv_get_specific_info(protocol_bs, &err);
+ if (err) {
+ error_propagate(errp, err);
+ qapi_free_ImageInfo(info);
+ goto out;
+ }
+ info->has_protocol_specific = info->protocol_specific != NULL;
+ }
+
backing_filename = bs->backing_file;
if (backing_filename[0] != '\0') {
char *backing_filename2;
--
2.35.1
next prev parent reply other threads:[~2022-05-03 22:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 14:55 [PATCH 0/4] block/file: Show extent size in qemu-img info Hanna Reitz
2022-05-03 14:55 ` [PATCH 1/4] block: Improve empty format-specific info dump Hanna Reitz
2022-05-03 18:44 ` Eric Blake
2022-05-04 8:18 ` Kevin Wolf
2022-05-03 14:55 ` Hanna Reitz [this message]
2022-05-03 18:47 ` [PATCH 2/4] block: Add protocol-specific image info Eric Blake
2022-05-04 8:36 ` Kevin Wolf
2022-05-04 11:25 ` Hanna Reitz
2022-05-03 14:55 ` [PATCH 3/4] block: Print protocol-specific information Hanna Reitz
2022-05-03 18:48 ` Eric Blake
2022-05-03 14:55 ` [PATCH 4/4] block/file: Add file-specific image info Hanna Reitz
2022-05-03 18:50 ` Eric Blake
2022-05-04 7:10 ` Hanna Reitz
2022-05-04 8:46 ` Kevin Wolf
2022-05-04 11:26 ` Hanna Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220503145529.37070-3-hreitz@redhat.com \
--to=hreitz@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).