From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: "Andrea Bolognani" <abologna@redhat.com>,
qemu-devel@nongnu.org, "Juan Quintela" <quintela@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Vladimir Sementsov-Ogievskiy" <v.sementsov-og@mail.ru>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
qemu-block@nongnu.org, "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Pavel Dovgalyuk" <pavel.dovgaluk@ispras.ru>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"John Snow" <jsnow@redhat.com>
Subject: Re: [PATCH v2 6/8] qapi: Drop unnecessary whitespace in comments
Date: Tue, 3 May 2022 11:23:05 -0500 [thread overview]
Message-ID: <20220503162305.ul4yssy7fyl4ivs6@redhat.com> (raw)
In-Reply-To: <87ilqndn5o.fsf@pond.sub.org>
On Tue, May 03, 2022 at 10:40:35AM +0200, Markus Armbruster wrote:
> Andrea Bolognani <abologna@redhat.com> writes:
>
> > The only instances that get changed are those in which the
> > additional whitespace was not (or couldn't possibly be) used for
> > alignment purposes.
> >
> > Signed-off-by: Andrea Bolognani <abologna@redhat.com>
>
> This mixes complete no-brainers with "I consider it an improvement, but
> folks might disagree" (a few examples marked below for illustration).
>
> Well, folks, if you disagree, speak up! I don't:
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>
No complaints from me for the changes made in this patch.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2022-05-03 16:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 7:37 [PATCH v2 0/8] qapi: Primarily whitespace tweaks Andrea Bolognani
2022-05-03 7:37 ` [PATCH v2 1/8] qapi: Drop stray trailing symbol Andrea Bolognani
2022-05-03 7:37 ` [PATCH v2 2/8] qapi: Fix comment indentation Andrea Bolognani
2022-05-03 7:37 ` [PATCH v2 3/8] qapi: Add missing separators between sections Andrea Bolognani
2022-05-03 7:37 ` [PATCH v2 4/8] qapi: Drop unnecessary empty lines in comments Andrea Bolognani
2022-05-03 7:37 ` [PATCH v2 5/8] qapi: Drop unnecessary empty lines outside of comments Andrea Bolognani
2022-05-03 7:37 ` [PATCH v2 6/8] qapi: Drop unnecessary whitespace in comments Andrea Bolognani
2022-05-03 8:40 ` Markus Armbruster
2022-05-03 16:23 ` Eric Blake [this message]
2022-05-03 7:37 ` [PATCH v2 7/8] qapi: Reduce whitespace used for alignment " Andrea Bolognani
2022-05-03 7:37 ` [PATCH v2 8/8] qapi: Stop using whitespace " Andrea Bolognani
2022-05-03 16:25 ` Eric Blake
2022-05-12 11:23 ` Markus Armbruster
2022-05-16 5:28 ` Markus Armbruster
2022-05-16 5:46 ` [PATCH v2 0/8] qapi: Primarily whitespace tweaks Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220503162305.ul4yssy7fyl4ivs6@redhat.com \
--to=eblake@redhat.com \
--cc=abologna@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eduardo@habkost.net \
--cc=f4bug@amsat.org \
--cc=jsnow@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=v.sementsov-og@mail.ru \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).