qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PATCH v2 32/74] semihosting: Create semihost_sys_{stat,fstat}
Date: Tue,  3 May 2022 12:48:01 -0700	[thread overview]
Message-ID: <20220503194843.1379101-33-richard.henderson@linaro.org> (raw)
In-Reply-To: <20220503194843.1379101-1-richard.henderson@linaro.org>

These syscalls will be used by m68k and nios2 semihosting.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 include/semihosting/syscalls.h |   7 ++
 semihosting/syscalls.c         | 137 +++++++++++++++++++++++++++++++++
 2 files changed, 144 insertions(+)

diff --git a/include/semihosting/syscalls.h b/include/semihosting/syscalls.h
index c9f9e66be1..ecc97751a9 100644
--- a/include/semihosting/syscalls.h
+++ b/include/semihosting/syscalls.h
@@ -49,6 +49,13 @@ void semihost_sys_flen(CPUState *cs, gdb_syscall_complete_cb fstat_cb,
                        gdb_syscall_complete_cb flen_cb,
                        int fd, target_ulong fstat_addr);
 
+void semihost_sys_fstat(CPUState *cs, gdb_syscall_complete_cb complete,
+                        int fd, target_ulong addr);
+
+void semihost_sys_stat(CPUState *cs, gdb_syscall_complete_cb complete,
+                       target_ulong fname, target_ulong fname_len,
+                       target_ulong addr);
+
 void semihost_sys_remove(CPUState *cs, gdb_syscall_complete_cb complete,
                          target_ulong fname, target_ulong fname_len);
 
diff --git a/semihosting/syscalls.c b/semihosting/syscalls.c
index b6c395af22..7bc2640512 100644
--- a/semihosting/syscalls.c
+++ b/semihosting/syscalls.c
@@ -93,6 +93,52 @@ static int errno_for_gdb(void)
 #undef E
 }
 
+/*
+ * TODO: Note that gdb always stores the stat structure big-endian.
+ * So far, that's ok, as the only two targets using this are also
+ * big-endian.  Until we do something with gdb, also produce the
+ * same big-endian result from the host.
+ */
+static int copy_stat_to_user(CPUState *cs, target_ulong addr,
+                             const struct stat *s)
+{
+    CPUArchState *env G_GNUC_UNUSED = cs->env_ptr;
+    struct gdb_stat *p;
+
+    if (s->st_dev != (uint32_t)s->st_dev ||
+        s->st_ino != (uint32_t)s->st_ino) {
+        return -GDB_EOVERFLOW;
+    }
+
+    p = lock_user(VERIFY_WRITE, addr, sizeof(struct gdb_stat), 0);
+    if (!p) {
+        return -GDB_EFAULT;
+    }
+
+    p->gdb_st_dev = cpu_to_be32(s->st_dev);
+    p->gdb_st_ino = cpu_to_be32(s->st_ino);
+    p->gdb_st_mode = cpu_to_be32(s->st_mode);
+    p->gdb_st_nlink = cpu_to_be32(s->st_nlink);
+    p->gdb_st_uid = cpu_to_be32(s->st_uid);
+    p->gdb_st_gid = cpu_to_be32(s->st_gid);
+    p->gdb_st_rdev = cpu_to_be32(s->st_rdev);
+    p->gdb_st_size = cpu_to_be64(s->st_size);
+#ifdef _WIN32
+    /* Windows stat is missing some fields.  */
+    p->gdb_st_blksize = 0;
+    p->gdb_st_blocks = 0;
+#else
+    p->gdb_st_blksize = cpu_to_be64(s->st_blksize);
+    p->gdb_st_blocks = cpu_to_be64(s->st_blocks);
+#endif
+    p->gdb_st_atime = cpu_to_be32(s->st_atime);
+    p->gdb_st_mtime = cpu_to_be32(s->st_mtime);
+    p->gdb_st_ctime = cpu_to_be32(s->st_ctime);
+
+    unlock_user(p, addr, sizeof(struct gdb_stat));
+    return 0;
+}
+
 /*
  * GDB semihosting syscall implementations.
  */
@@ -163,6 +209,19 @@ static void gdb_fstat(CPUState *cs, gdb_syscall_complete_cb complete,
     gdb_do_syscall(complete, "fstat,%x,%x", (target_ulong)gf->hostfd, addr);
 }
 
+static void gdb_stat(CPUState *cs, gdb_syscall_complete_cb complete,
+                     target_ulong fname, target_ulong fname_len,
+                     target_ulong addr)
+{
+    int len = validate_strlen(cs, fname, fname_len);
+    if (len < 0) {
+        complete(cs, -1, -len);
+        return;
+    }
+
+    gdb_do_syscall(complete, "stat,%s,%x", fname, len, addr);
+}
+
 static void gdb_remove(CPUState *cs, gdb_syscall_complete_cb complete,
                        target_ulong fname, target_ulong fname_len)
 {
@@ -351,6 +410,51 @@ static void host_flen(CPUState *cs, gdb_syscall_complete_cb complete,
     }
 }
 
+static void host_fstat(CPUState *cs, gdb_syscall_complete_cb complete,
+                       GuestFD *gf, target_ulong addr)
+{
+    struct stat buf;
+    int ret;
+
+    ret = fstat(gf->hostfd, &buf);
+    if (ret) {
+        complete(cs, -1, errno_for_gdb());
+        return;
+    }
+    ret = copy_stat_to_user(cs, addr, &buf);
+    complete(cs, ret ? -1 : 0, ret ? -ret : 0);
+}
+
+static void host_stat(CPUState *cs, gdb_syscall_complete_cb complete,
+                      target_ulong fname, target_ulong fname_len,
+                      target_ulong addr)
+{
+    CPUArchState *env G_GNUC_UNUSED = cs->env_ptr;
+    struct stat buf;
+    char *name;
+    int ret, err;
+
+    ret = validate_lock_user_string(&name, cs, fname, fname_len);
+    if (ret < 0) {
+        complete(cs, -1, -ret);
+        return;
+    }
+
+    ret = stat(name, &buf);
+    if (ret) {
+        err = errno_for_gdb();
+    } else {
+        ret = copy_stat_to_user(cs, addr, &buf);
+        err = 0;
+        if (ret < 0) {
+            err = -ret;
+            ret = -1;
+        }
+    }
+    complete(cs, ret, err);
+    unlock_user(name, fname, 0);
+}
+
 static void host_remove(CPUState *cs, gdb_syscall_complete_cb complete,
                         target_ulong fname, target_ulong fname_len)
 {
@@ -659,6 +763,39 @@ void semihost_sys_flen(CPUState *cs, gdb_syscall_complete_cb fstat_cb,
     }
 }
 
+void semihost_sys_fstat(CPUState *cs, gdb_syscall_complete_cb complete,
+                        int fd, target_ulong addr)
+{
+    GuestFD *gf = get_guestfd(fd);
+
+    if (!gf) {
+        complete(cs, -1, GDB_EBADF);
+        return;
+    }
+    switch (gf->type) {
+    case GuestFDGDB:
+        gdb_fstat(cs, complete, gf, addr);
+        break;
+    case GuestFDHost:
+        host_fstat(cs, complete, gf, addr);
+        break;
+    case GuestFDStatic:
+    default:
+        g_assert_not_reached();
+    }
+}
+
+void semihost_sys_stat(CPUState *cs, gdb_syscall_complete_cb complete,
+                       target_ulong fname, target_ulong fname_len,
+                       target_ulong addr)
+{
+    if (use_gdb_syscalls()) {
+        gdb_stat(cs, complete, fname, fname_len, addr);
+    } else {
+        host_stat(cs, complete, fname, fname_len, addr);
+    }
+}
+
 void semihost_sys_remove(CPUState *cs, gdb_syscall_complete_cb complete,
                          target_ulong fname, target_ulong fname_len)
 {
-- 
2.34.1



  parent reply	other threads:[~2022-05-03 20:33 UTC|newest]

Thread overview: 92+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-03 19:47 [PATCH v2 00/74] semihosting cleanup Richard Henderson
2022-05-03 19:47 ` [PATCH v2 01/74] semihosting: Move exec/softmmu-semi.h to semihosting/softmmu-uaccess.h Richard Henderson
2022-05-16 14:36   ` Peter Maydell
2022-05-03 19:47 ` [PATCH v2 02/74] semihosting: Return failure from softmmu-uaccess.h functions Richard Henderson
2022-05-16 14:42   ` Peter Maydell
2022-05-03 19:47 ` [PATCH v2 03/74] semihosting: Improve condition for config.c and console.c Richard Henderson
2022-05-16 15:00   ` Peter Maydell
2022-05-03 19:47 ` [PATCH v2 04/74] semihosting: Move softmmu-uaccess.h functions out of line Richard Henderson
2022-05-16 15:04   ` Peter Maydell
2022-05-03 19:47 ` [PATCH v2 05/74] semihosting: Add target_strlen for softmmu-uaccess.h Richard Henderson
2022-05-16 15:11   ` Peter Maydell
2022-05-17  1:33     ` Richard Henderson
2022-05-03 19:47 ` [PATCH v2 06/74] semihosting: Simplify softmmu_lock_user_string Richard Henderson
2022-05-16 15:12   ` Peter Maydell
2022-05-03 19:47 ` [PATCH v2 07/74] semihosting: Split out guestfd.c Richard Henderson
2022-05-16 15:14   ` Peter Maydell
2022-05-17  1:47     ` Richard Henderson
2022-05-03 19:47 ` [PATCH v2 08/74] semihosting: Generalize GuestFDFeatureFile Richard Henderson
2022-05-16 15:20   ` Peter Maydell
2022-05-03 19:47 ` [PATCH v2 09/74] semihosting: Return void from do_common_semihosting Richard Henderson
2022-05-16 15:31   ` Peter Maydell
2022-05-03 19:47 ` [PATCH v2 10/74] semihosting: Adjust error checking in common_semi_cb Richard Henderson
2022-05-03 19:47 ` [PATCH v2 11/74] semihosting: Move common-semi.h to include/semihosting/ Richard Henderson
2022-05-03 19:47 ` [PATCH v2 12/74] include/exec: Move gdb open flags to gdbstub.h Richard Henderson
2022-05-03 19:47 ` [PATCH v2 13/74] include/exec: Move gdb_stat and gdb_timeval " Richard Henderson
2022-05-03 19:47 ` [PATCH v2 14/74] include/exec: Define errno values in gdbstub.h Richard Henderson
2022-05-03 19:47 ` [PATCH v2 15/74] semihosting: Use struct gdb_stat in common_semi_flen_cb Richard Henderson
2022-05-03 19:47 ` [PATCH v2 16/74] semihosting: Split is_64bit_semihosting per target Richard Henderson
2022-05-04  8:58   ` Alistair Francis
2022-05-03 19:47 ` [PATCH v2 17/74] semihosting: Split common_semi_flen_buf " Richard Henderson
2022-05-04  8:59   ` Alistair Francis
2022-05-03 19:47 ` [PATCH v2 18/74] semihosting: Split out common_semi_has_synccache Richard Henderson
2022-05-04  9:01   ` Alistair Francis
2022-05-03 19:47 ` [PATCH v2 19/74] semihosting: Use env more often in do_common_semihosting Richard Henderson
2022-05-03 19:47 ` [PATCH v2 20/74] semihosting: Move GET_ARG/SET_ARG earlier in the file Richard Henderson
2022-05-03 19:47 ` [PATCH v2 21/74] semihosting: Split out semihost_sys_open Richard Henderson
2022-05-03 19:47 ` [PATCH v2 22/74] semihosting: Split out semihost_sys_close Richard Henderson
2022-05-03 19:47 ` [PATCH v2 23/74] semihosting: Split out semihost_sys_read Richard Henderson
2022-05-03 19:47 ` [PATCH v2 24/74] semihosting: Split out semihost_sys_write Richard Henderson
2022-05-03 19:47 ` [PATCH v2 25/74] semihosting: Bound length for semihost_sys_{read, write} Richard Henderson
2022-05-03 19:47 ` [PATCH v2 26/74] semihosting: Split out semihost_sys_lseek Richard Henderson
2022-05-03 19:47 ` [PATCH v2 27/74] semihosting: Split out semihost_sys_isatty Richard Henderson
2022-05-03 19:47 ` [PATCH v2 28/74] semihosting: Split out semihost_sys_flen Richard Henderson
2022-05-03 19:47 ` [PATCH v2 29/74] semihosting: Split out semihost_sys_remove Richard Henderson
2022-05-03 19:47 ` [PATCH v2 30/74] semihosting: Split out semihost_sys_rename Richard Henderson
2022-05-03 19:48 ` [PATCH v2 31/74] semihosting: Split out semihost_sys_system Richard Henderson
2022-05-03 19:48 ` Richard Henderson [this message]
2022-05-03 19:48 ` [PATCH v2 33/74] semihosting: Create semihost_sys_gettimeofday Richard Henderson
2022-05-03 19:48 ` [PATCH v2 34/74] gdbstub: Widen gdb_syscall_complete_cb return value Richard Henderson
2022-05-03 19:48 ` [PATCH v2 35/74] semihosting: Fix docs comment for qemu_semihosting_console_inc Richard Henderson
2022-05-03 19:48 ` [PATCH v2 36/74] semihosting: Pass CPUState to qemu_semihosting_console_inc Richard Henderson
2022-05-03 19:48 ` [PATCH v2 37/74] semihosting: Expand qemu_semihosting_console_inc to read Richard Henderson
2022-05-03 19:48 ` [PATCH v2 38/74] semihosting: Cleanup chardev init Richard Henderson
2022-05-03 19:48 ` [PATCH v2 39/74] semihosting: Create qemu_semihosting_console_write Richard Henderson
2022-05-03 19:48 ` [PATCH v2 40/74] semihosting: Add GuestFDConsole Richard Henderson
2022-05-03 19:48 ` [PATCH v2 41/74] semihosting: Create qemu_semihosting_guestfd_init Richard Henderson
2022-05-03 19:48 ` [PATCH v2 42/74] semihosting: Use console_in_gf for SYS_READC Richard Henderson
2022-05-03 19:48 ` [PATCH v2 43/74] semihosting: Use console_out_gf for SYS_WRITEC Richard Henderson
2022-05-03 19:48 ` [PATCH v2 44/74] semihosting: Remove qemu_semihosting_console_outc Richard Henderson
2022-05-03 19:48 ` [PATCH v2 45/74] semihosting: Use console_out_gf for SYS_WRITE0 Richard Henderson
2022-05-03 19:48 ` [PATCH v2 46/74] semihosting: Remove qemu_semihosting_console_outs Richard Henderson
2022-05-03 19:48 ` [PATCH v2 47/74] semihosting: Create semihost_sys_poll_one Richard Henderson
2022-05-03 19:48 ` [PATCH v2 48/74] target/m68k: Eliminate m68k_semi_is_fseek Richard Henderson
2022-05-03 19:48 ` [PATCH v2 49/74] target/m68k: Make semihosting system only Richard Henderson
2022-05-03 19:48 ` [PATCH v2 50/74] target/m68k: Use semihosting/syscalls.h Richard Henderson
2022-05-03 19:48 ` [PATCH v2 51/74] target/nios2: Eliminate nios2_semi_is_lseek Richard Henderson
2022-05-03 19:48 ` [PATCH v2 52/74] target/nios2: Move nios2-semi.c to nios2_softmmu_ss Richard Henderson
2022-05-03 19:48 ` [PATCH v2 53/74] target/nios2: Use semihosting/syscalls.h Richard Henderson
2022-05-03 19:48 ` [PATCH v2 54/74] target/mips: Use an exception for semihosting Richard Henderson
2022-05-03 19:48 ` [PATCH v2 55/74] target/mips: Add UHI errno values Richard Henderson
2022-05-03 19:48 ` [PATCH v2 56/74] target/mips: Create report_fault for semihosting Richard Henderson
2022-05-03 19:48 ` [PATCH v2 57/74] target/mips: Drop link syscall from semihosting Richard Henderson
2022-05-03 19:48 ` [PATCH v2 58/74] target/mips: Drop pread and pwrite syscalls " Richard Henderson
2022-05-03 19:48 ` [PATCH v2 59/74] target/mips: Use semihosting/syscalls.h Richard Henderson
2022-05-03 19:48 ` [PATCH v2 60/74] target/mips: Avoid qemu_semihosting_log_out for UHI_plog Richard Henderson
2022-05-03 19:48 ` [PATCH v2 61/74] target/mips: Use error_report for UHI_assert Richard Henderson
2022-05-03 19:48 ` [PATCH v2 62/74] semihosting: Remove qemu_semihosting_log_out Richard Henderson
2022-05-03 19:48 ` [PATCH v2 63/74] target/mips: Simplify UHI_argnlen and UHI_argn Richard Henderson
2022-05-03 19:48 ` [PATCH v2 64/74] target/mips: Remove GET_TARGET_STRING and FREE_TARGET_STRING Richard Henderson
2022-05-03 19:48 ` [PATCH v2 65/74] target/xtensa: Use an exception for semihosting Richard Henderson
2022-05-03 19:48 ` [PATCH v2 66/74] target/xtensa: Use semihosting/syscalls.h Richard Henderson
2022-05-03 19:48 ` [PATCH v2 67/74] tests/docker: Add debian-rx-cross image Richard Henderson
2022-05-03 19:48 ` [PATCH v2 68/74] hw/rx: Handle a kernel file that is ELF Richard Henderson
2022-05-13 15:44   ` Peter Maydell
2022-05-13 15:48     ` Richard Henderson
2022-05-13 16:40       ` Richard Henderson
2022-05-03 19:48 ` [PATCH v2 69/74] target/rx: Fix the base of the fixed vector table Richard Henderson
2022-05-03 19:48 ` [PATCH v2 70/74] target/rx: Name the exceptions Richard Henderson
2022-05-03 19:48 ` [PATCH v2 71/74] target/rx: Consolidate exception helpers Richard Henderson
2022-05-03 19:48 ` [PATCH v2 72/74] target/rx: Cleanup rx_cpu_do_interrupt Richard Henderson
2022-05-03 19:48 ` [PATCH v2 73/74] target/rx: Implement libgloss semihosting Richard Henderson
2022-05-03 19:48 ` [PATCH v2 74/74] tests/tcg/rx: Enable semihosting multiarch tests Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220503194843.1379101-33-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).