From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, John Snow <jsnow@redhat.com>
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Beraldo Leal" <bleal@redhat.com>
Subject: [RFC PATCH] gitlab-ci: Switch the 'check-patch' & 'check-dco' jobs to use python-container
Date: Tue, 3 May 2022 22:36:21 +0200 [thread overview]
Message-ID: <20220503203621.243153-1-thuth@redhat.com> (raw)
The 'check-patch' and 'check-dco' jobs only need Python and git for
checking the patches, so it's not really necessary to use a container
here that has all the other build dependencies installed. By installing
"git" in the python container, we can use this light-weight container
for these jobs instead.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
Mark as RFC since I'm not sure whether we want to have "git" in
the python container or not?
.gitlab-ci.d/static_checks.yml | 8 ++++----
tests/docker/dockerfiles/python.docker | 1 +
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/.gitlab-ci.d/static_checks.yml b/.gitlab-ci.d/static_checks.yml
index 5e955540d3..0e080bd0a0 100644
--- a/.gitlab-ci.d/static_checks.yml
+++ b/.gitlab-ci.d/static_checks.yml
@@ -1,8 +1,8 @@
check-patch:
stage: build
- image: $CI_REGISTRY_IMAGE/qemu/centos8:latest
+ image: $CI_REGISTRY_IMAGE/qemu/python:latest
needs:
- job: amd64-centos8-container
+ job: python-container
script:
- .gitlab-ci.d/check-patch.py
variables:
@@ -15,9 +15,9 @@ check-patch:
check-dco:
stage: build
- image: $CI_REGISTRY_IMAGE/qemu/centos8:latest
+ image: $CI_REGISTRY_IMAGE/qemu/python:latest
needs:
- job: amd64-centos8-container
+ job: python-container
script: .gitlab-ci.d/check-dco.py
variables:
GIT_DEPTH: 1000
diff --git a/tests/docker/dockerfiles/python.docker b/tests/docker/dockerfiles/python.docker
index 56d88417df..b2fb3a306d 100644
--- a/tests/docker/dockerfiles/python.docker
+++ b/tests/docker/dockerfiles/python.docker
@@ -6,6 +6,7 @@ MAINTAINER John Snow <jsnow@redhat.com>
# Please keep this list sorted alphabetically
ENV PACKAGES \
gcc \
+ git \
make \
pipenv \
python3 \
--
2.27.0
next reply other threads:[~2022-05-03 23:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 20:36 Thomas Huth [this message]
2022-05-04 9:12 ` [RFC PATCH] gitlab-ci: Switch the 'check-patch' & 'check-dco' jobs to use python-container Daniel P. Berrangé
2022-05-04 9:18 ` Thomas Huth
2022-05-04 9:20 ` Daniel P. Berrangé
2022-05-16 8:25 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220503203621.243153-1-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=bleal@redhat.com \
--cc=f4bug@amsat.org \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).