qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Bernhard Beschow <shentey@gmail.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Bernhard Beschow <shentey@gmail.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	Eduardo Habkost <eduardo@habkost.net>,
	Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
	Artyom Tarasenko <atar4qemu@gmail.com>
Subject: [PATCH 02/11] hw: Reuse TYPE_I8042 define
Date: Thu,  5 May 2022 18:17:56 +0200	[thread overview]
Message-ID: <20220505161805.11116-3-shentey@gmail.com> (raw)
In-Reply-To: <20220505161805.11116-1-shentey@gmail.com>

TYPE_I8042 is exported, so reuse it for consistency.

Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
 hw/i386/pc.c       | 4 ++--
 hw/sparc64/sun4u.c | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 23bba9d82c..649511a49b 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1042,7 +1042,7 @@ static void pc_superio_init(ISABus *isa_bus, bool create_fdctrl,
         return;
     }
 
-    i8042 = isa_create_simple(isa_bus, "i8042");
+    i8042 = isa_create_simple(isa_bus, TYPE_I8042);
     if (!no_vmport) {
         isa_create_simple(isa_bus, TYPE_VMPORT);
         vmmouse = isa_try_new("vmmouse");
@@ -1050,7 +1050,7 @@ static void pc_superio_init(ISABus *isa_bus, bool create_fdctrl,
         vmmouse = NULL;
     }
     if (vmmouse) {
-        object_property_set_link(OBJECT(vmmouse), "i8042", OBJECT(i8042),
+        object_property_set_link(OBJECT(vmmouse), TYPE_I8042, OBJECT(i8042),
                                  &error_abort);
         isa_realize_and_unref(vmmouse, isa_bus, &error_fatal);
     }
diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c
index 6fd08e2298..77687dc649 100644
--- a/hw/sparc64/sun4u.c
+++ b/hw/sparc64/sun4u.c
@@ -334,7 +334,7 @@ static void ebus_realize(PCIDevice *pci_dev, Error **errp)
     parallel_hds_isa_init(s->isa_bus, MAX_PARALLEL_PORTS);
 
     /* Keyboard */
-    isa_create_simple(s->isa_bus, "i8042");
+    isa_create_simple(s->isa_bus, TYPE_I8042);
 
     /* Floppy */
     for (i = 0; i < MAX_FD; i++) {
-- 
2.36.0



  parent reply	other threads:[~2022-05-05 16:38 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-05 16:17 [PATCH 00/11] Random cleanup patches Bernhard Beschow
2022-05-05 16:17 ` [PATCH 01/11] hw/rtc/mc146818rtc: Inline isa_connect_gpio_out() and remove it Bernhard Beschow
2022-05-09 12:09   ` Philippe Mathieu-Daudé
2022-05-11 10:24   ` Mark Cave-Ayland
2022-05-13 10:34     ` Bernhard Beschow
2022-05-05 16:17 ` Bernhard Beschow [this message]
2022-05-09 12:12   ` [PATCH 02/11] hw: Reuse TYPE_I8042 define Philippe Mathieu-Daudé via
2022-05-05 16:17 ` [PATCH 03/11] hw/audio/cs4231a: Const'ify global tables Bernhard Beschow
2022-05-09 12:13   ` Philippe Mathieu-Daudé via
2022-05-05 16:17 ` [PATCH 04/11] hw/i386/pc: Unexport PC_CPU_MODEL_IDS macro Bernhard Beschow
2022-05-05 16:17 ` [PATCH 05/11] hw/i386/pc: Unexport functions used only internally Bernhard Beschow
2022-05-09 12:14   ` Philippe Mathieu-Daudé via
2022-05-05 16:18 ` [PATCH 06/11] hw/i386/pc: Remove orphan declarations Bernhard Beschow
2022-05-05 16:18 ` [PATCH 07/11] hw/ppc/e500: Remove unused BINARY_DEVICE_TREE_FILE Bernhard Beschow
2022-05-05 16:59   ` Daniel Henrique Barboza
2022-05-05 16:18 ` [PATCH 08/11] hw/net/fsl_etsec/etsec: Remove obsolete and unused etsec_create() Bernhard Beschow
2022-05-09 12:15   ` Philippe Mathieu-Daudé via
2022-05-05 16:18 ` [PATCH 09/11] accel/tcg/cpu-exec: Unexport dump_drift_info() Bernhard Beschow
2022-05-05 16:18 ` [PATCH 10/11] accel/tcg: Inline dump_opcount_info() and remove it Bernhard Beschow
2022-05-05 16:18 ` [PATCH 11/11] docs/devel: Fix link to developer mailing lists Bernhard Beschow
2022-05-13 11:27 ` [PATCH 00/11] Random cleanup patches Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220505161805.11116-3-shentey@gmail.com \
    --to=shentey@gmail.com \
    --cc=atar4qemu@gmail.com \
    --cc=eduardo@habkost.net \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).