qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Bernhard Beschow <shentey@gmail.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Bernhard Beschow <shentey@gmail.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	Eduardo Habkost <eduardo@habkost.net>
Subject: [PATCH 04/11] hw/i386/pc: Unexport PC_CPU_MODEL_IDS macro
Date: Thu,  5 May 2022 18:17:58 +0200	[thread overview]
Message-ID: <20220505161805.11116-5-shentey@gmail.com> (raw)
In-Reply-To: <20220505161805.11116-1-shentey@gmail.com>

The macro seems to be used only internally, so remove it.

Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
 hw/i386/pc.c         | 9 +++++++++
 include/hw/i386/pc.h | 8 --------
 2 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 649511a49b..c2975d7de5 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -95,6 +95,15 @@
 #include "trace.h"
 #include CONFIG_DEVICES
 
+/*
+ * Helper for setting model-id for CPU models that changed model-id
+ * depending on QEMU versions up to QEMU 2.4.
+ */
+#define PC_CPU_MODEL_IDS(v) \
+    { "qemu32-" TYPE_X86_CPU, "model-id", "QEMU Virtual CPU version " v, },\
+    { "qemu64-" TYPE_X86_CPU, "model-id", "QEMU Virtual CPU version " v, },\
+    { "athlon-" TYPE_X86_CPU, "model-id", "QEMU Virtual CPU version " v, },
+
 GlobalProperty pc_compat_7_0[] = {};
 const size_t pc_compat_7_0_len = G_N_ELEMENTS(pc_compat_7_0);
 
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index 637367dc5f..b34c664ff5 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -289,14 +289,6 @@ extern const size_t pc_compat_1_5_len;
 extern GlobalProperty pc_compat_1_4[];
 extern const size_t pc_compat_1_4_len;
 
-/* Helper for setting model-id for CPU models that changed model-id
- * depending on QEMU versions up to QEMU 2.4.
- */
-#define PC_CPU_MODEL_IDS(v) \
-    { "qemu32-" TYPE_X86_CPU, "model-id", "QEMU Virtual CPU version " v, },\
-    { "qemu64-" TYPE_X86_CPU, "model-id", "QEMU Virtual CPU version " v, },\
-    { "athlon-" TYPE_X86_CPU, "model-id", "QEMU Virtual CPU version " v, },
-
 #define DEFINE_PC_MACHINE(suffix, namestr, initfn, optsfn) \
     static void pc_machine_##suffix##_class_init(ObjectClass *oc, void *data) \
     { \
-- 
2.36.0



  parent reply	other threads:[~2022-05-05 16:22 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-05 16:17 [PATCH 00/11] Random cleanup patches Bernhard Beschow
2022-05-05 16:17 ` [PATCH 01/11] hw/rtc/mc146818rtc: Inline isa_connect_gpio_out() and remove it Bernhard Beschow
2022-05-09 12:09   ` Philippe Mathieu-Daudé
2022-05-11 10:24   ` Mark Cave-Ayland
2022-05-13 10:34     ` Bernhard Beschow
2022-05-05 16:17 ` [PATCH 02/11] hw: Reuse TYPE_I8042 define Bernhard Beschow
2022-05-09 12:12   ` Philippe Mathieu-Daudé via
2022-05-05 16:17 ` [PATCH 03/11] hw/audio/cs4231a: Const'ify global tables Bernhard Beschow
2022-05-09 12:13   ` Philippe Mathieu-Daudé via
2022-05-05 16:17 ` Bernhard Beschow [this message]
2022-05-05 16:17 ` [PATCH 05/11] hw/i386/pc: Unexport functions used only internally Bernhard Beschow
2022-05-09 12:14   ` Philippe Mathieu-Daudé via
2022-05-05 16:18 ` [PATCH 06/11] hw/i386/pc: Remove orphan declarations Bernhard Beschow
2022-05-05 16:18 ` [PATCH 07/11] hw/ppc/e500: Remove unused BINARY_DEVICE_TREE_FILE Bernhard Beschow
2022-05-05 16:59   ` Daniel Henrique Barboza
2022-05-05 16:18 ` [PATCH 08/11] hw/net/fsl_etsec/etsec: Remove obsolete and unused etsec_create() Bernhard Beschow
2022-05-09 12:15   ` Philippe Mathieu-Daudé via
2022-05-05 16:18 ` [PATCH 09/11] accel/tcg/cpu-exec: Unexport dump_drift_info() Bernhard Beschow
2022-05-05 16:18 ` [PATCH 10/11] accel/tcg: Inline dump_opcount_info() and remove it Bernhard Beschow
2022-05-05 16:18 ` [PATCH 11/11] docs/devel: Fix link to developer mailing lists Bernhard Beschow
2022-05-13 11:27 ` [PATCH 00/11] Random cleanup patches Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220505161805.11116-5-shentey@gmail.com \
    --to=shentey@gmail.com \
    --cc=eduardo@habkost.net \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).