qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Subject: [PATCH v6 14/24] target/arm: Enable SCR and HCR bits for RAS
Date: Fri,  6 May 2022 13:02:32 -0500	[thread overview]
Message-ID: <20220506180242.216785-15-richard.henderson@linaro.org> (raw)
In-Reply-To: <20220506180242.216785-1-richard.henderson@linaro.org>

Enable writes to the TERR and TEA bits when RAS is enabled.
These bits are otherwise RES0.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/arm/helper.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/target/arm/helper.c b/target/arm/helper.c
index 37c5e42bc0..b6faebf4a7 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -1755,6 +1755,9 @@ static void scr_write(CPUARMState *env, const ARMCPRegInfo *ri, uint64_t value)
         }
         valid_mask &= ~SCR_NET;
 
+        if (cpu_isar_feature(aa64_ras, cpu)) {
+            valid_mask |= SCR_TERR;
+        }
         if (cpu_isar_feature(aa64_lor, cpu)) {
             valid_mask |= SCR_TLOR;
         }
@@ -1769,6 +1772,9 @@ static void scr_write(CPUARMState *env, const ARMCPRegInfo *ri, uint64_t value)
         }
     } else {
         valid_mask &= ~(SCR_RW | SCR_ST);
+        if (cpu_isar_feature(aa32_ras, cpu)) {
+            valid_mask |= SCR_TERR;
+        }
     }
 
     if (!arm_feature(env, ARM_FEATURE_EL2)) {
@@ -5126,6 +5132,9 @@ static void do_hcr_write(CPUARMState *env, uint64_t value, uint64_t valid_mask)
         if (cpu_isar_feature(aa64_vh, cpu)) {
             valid_mask |= HCR_E2H;
         }
+        if (cpu_isar_feature(aa64_ras, cpu)) {
+            valid_mask |= HCR_TERR | HCR_TEA;
+        }
         if (cpu_isar_feature(aa64_lor, cpu)) {
             valid_mask |= HCR_TLOR;
         }
-- 
2.34.1



  parent reply	other threads:[~2022-05-06 18:22 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-06 18:02 [PATCH v6 00/24] target/arm: Cleanups, new features, new cpus Richard Henderson
2022-05-06 18:02 ` [PATCH v6 01/24] target/arm: Handle cpreg registration for missing EL Richard Henderson
2022-05-06 18:02 ` [PATCH v6 02/24] target/arm: Drop EL3 no EL2 fallbacks Richard Henderson
2022-05-06 18:02 ` [PATCH v6 03/24] target/arm: Merge zcr reginfo Richard Henderson
2022-05-06 18:02 ` [PATCH v6 04/24] target/arm: Adjust definition of CONTEXTIDR_EL2 Richard Henderson
2022-05-06 18:02 ` [PATCH v6 05/24] target/arm: Move cortex impdef sysregs to cpu_tcg.c Richard Henderson
2022-05-06 18:02 ` [PATCH v6 06/24] target/arm: Update qemu-system-arm -cpu max to cortex-a57 Richard Henderson
2022-05-06 18:02 ` [PATCH v6 07/24] target/arm: Set ID_DFR0.PerfMon for qemu-system-arm -cpu max Richard Henderson
2022-05-06 18:02 ` [PATCH v6 08/24] target/arm: Split out aa32_max_features Richard Henderson
2022-05-06 18:02 ` [PATCH v6 09/24] target/arm: Annotate arm_max_initfn with FEAT identifiers Richard Henderson
2022-05-06 18:02 ` [PATCH v6 10/24] target/arm: Use field names for manipulating EL2 and EL3 modes Richard Henderson
2022-05-06 18:02 ` [PATCH v6 11/24] target/arm: Enable FEAT_Debugv8p2 for -cpu max Richard Henderson
2022-05-06 18:02 ` [PATCH v6 12/24] target/arm: Enable FEAT_Debugv8p4 " Richard Henderson
2022-05-06 18:02 ` [PATCH v6 13/24] target/arm: Add minimal RAS registers Richard Henderson
2022-05-06 18:02 ` Richard Henderson [this message]
2022-05-06 18:02 ` [PATCH v6 15/24] target/arm: Implement virtual SError exceptions Richard Henderson
2022-05-06 18:02 ` [PATCH v6 16/24] target/arm: Implement ESB instruction Richard Henderson
2022-05-06 18:02 ` [PATCH v6 17/24] target/arm: Enable FEAT_RAS for -cpu max Richard Henderson
2022-05-06 18:02 ` [PATCH v6 18/24] target/arm: Enable FEAT_IESB " Richard Henderson
2022-05-06 18:02 ` [PATCH v6 19/24] target/arm: Enable FEAT_CSV2 " Richard Henderson
2022-05-06 18:02 ` [PATCH v6 20/24] target/arm: Enable FEAT_CSV2_2 " Richard Henderson
2022-05-06 18:02 ` [PATCH v6 21/24] target/arm: Enable FEAT_CSV3 " Richard Henderson
2022-05-06 18:02 ` [PATCH v6 22/24] target/arm: Enable FEAT_DGH " Richard Henderson
2022-05-06 18:02 ` [PATCH v6 23/24] target/arm: Define cortex-a76 Richard Henderson
2022-05-06 18:02 ` [PATCH v6 24/24] target/arm: Define neoverse-n1 Richard Henderson
2022-08-10 13:12   ` Zenghui Yu via
2022-08-10 16:47     ` Peter Maydell
2022-08-11  7:08       ` Zenghui Yu via
2022-05-09  9:37 ` [PATCH v6 00/24] target/arm: Cleanups, new features, new cpus Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220506180242.216785-15-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).