From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: nsaenzju@redhat.com, stefanha@redhat.com
Subject: [PATCH v2 3/3] thread-pool: remove stopping variable
Date: Thu, 12 May 2022 12:43:46 +0200 [thread overview]
Message-ID: <20220512104346.865536-4-pbonzini@redhat.com> (raw)
In-Reply-To: <20220512104346.865536-1-pbonzini@redhat.com>
Just setting the max threads to 0 is enough to stop all workers.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
util/thread-pool.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/util/thread-pool.c b/util/thread-pool.c
index da189d9338..392c7d7843 100644
--- a/util/thread-pool.c
+++ b/util/thread-pool.c
@@ -69,7 +69,6 @@ struct ThreadPool {
int idle_threads;
int new_threads; /* backlog of threads we need to create */
int pending_threads; /* threads created but not running yet */
- bool stopping;
int min_threads;
int max_threads;
};
@@ -82,7 +81,7 @@ static void *worker_thread(void *opaque)
pool->pending_threads--;
do_spawn_thread(pool);
- while (!pool->stopping && pool->cur_threads <= pool->max_threads) {
+ while (pool->cur_threads <= pool->max_threads) {
ThreadPoolElement *req;
int ret;
@@ -366,7 +365,7 @@ void thread_pool_free(ThreadPool *pool)
pool->new_threads = 0;
/* Wait for worker threads to terminate */
- pool->stopping = true;
+ pool->max_threads = 0;
qemu_cond_broadcast(&pool->request_cond);
while (pool->cur_threads > 0) {
qemu_cond_wait(&pool->worker_stopped, &pool->lock);
--
2.36.0
prev parent reply other threads:[~2022-05-12 10:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 10:43 [PATCH v2 0/3] thread-pool: fix performance regression Paolo Bonzini
2022-05-12 10:43 ` [PATCH v2 1/3] thread-pool: optimize scheduling of completion bottom half Paolo Bonzini
2022-05-12 10:43 ` [PATCH v2 2/3] thread-pool: replace semaphore with condition variable Paolo Bonzini
2022-05-13 11:56 ` Nicolas Saenz Julienne
2022-05-13 12:38 ` Paolo Bonzini
2022-05-12 10:43 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220512104346.865536-4-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=nsaenzju@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).