From: Helge Deller <deller@gmx.de>
To: "Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
qemu-devel@nongnu.org,
"Richard Henderson" <richard.henderson@linaro.org>,
"Sven Schnelle" <svens@stackframe.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Helge Deller <deller@gmx.de>, Stefano Repici <rs.rdp@zoho.eu>
Subject: [PATCH v2 2/7] artist: Introduce constant for max cursor size
Date: Mon, 16 May 2022 16:29:02 +0200 [thread overview]
Message-ID: <20220516142907.32827-3-deller@gmx.de> (raw)
In-Reply-To: <20220516142907.32827-1-deller@gmx.de>
Add the constant NGLE_MAX_SPRITE_SIZE which defines the currently
maximum supported cursor size.
Signed-off-by: Helge Deller <deller@gmx.de>
Acked-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
---
hw/display/artist.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/hw/display/artist.c b/hw/display/artist.c
index 39fc0c4ca5..6333ee41db 100644
--- a/hw/display/artist.c
+++ b/hw/display/artist.c
@@ -98,6 +98,9 @@ struct ARTISTState {
int draw_line_pattern;
};
+/* hardware allows up to 64x64, but we emulate 32x32 only. */
+#define NGLE_MAX_SPRITE_SIZE 32
+
typedef enum {
ARTIST_BUFFER_AP = 1,
ARTIST_BUFFER_OVERLAY = 2,
@@ -1325,11 +1328,10 @@ static void artist_realizefn(DeviceState *dev, Error **errp)
framebuffer_update_memory_section(&s->fbsection, &buf->mr, 0,
buf->width, buf->height);
/*
- * no idea whether the cursor is fixed size or not, so assume 32x32 which
- * seems sufficient for HP-UX X11.
+ * Artist cursor max size
*/
- s->cursor_height = 32;
- s->cursor_width = 32;
+ s->cursor_height = NGLE_MAX_SPRITE_SIZE;
+ s->cursor_width = NGLE_MAX_SPRITE_SIZE;
/*
* These two registers are not initialized by seabios's STI implementation.
--
2.35.3
next prev parent reply other threads:[~2022-05-16 14:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 14:29 [PATCH v2 0/7] hppa: Artist graphics driver fixes for HP-UX and keyboard fix in firmware boot console Helge Deller
2022-05-16 14:29 ` [PATCH v2 1/7] seabios-hppa: Update SeaBIOS-hppa to VERSION 5 Helge Deller
2022-05-16 14:29 ` Helge Deller [this message]
2022-05-16 14:29 ` [PATCH v2 3/7] artist: Use human-readable variable names instead of reg_xxx Helge Deller
2022-05-16 14:29 ` [PATCH v2 4/7] artist: Fix vertical X11 cursor position in HP-UX Helge Deller
2022-05-16 14:29 ` [PATCH v2 5/7] artist: Allow to turn cursor on or off Helge Deller
2022-05-16 14:29 ` [PATCH v2 6/7] artist: Emulate screen blanking Helge Deller
2022-05-16 14:29 ` [PATCH v2 7/7] artist: Fix X cursor position calculation in X11 Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220516142907.32827-3-deller@gmx.de \
--to=deller@gmx.de \
--cc=f4bug@amsat.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rs.rdp@zoho.eu \
--cc=svens@stackframe.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).