From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, Richard Henderson <richard.henderson@linaro.org>
Cc: "Daniel P . Berrange" <berrange@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [PATCH 2/3] capstone: Allow version 3.0.5 again
Date: Mon, 16 May 2022 16:58:22 +0200 [thread overview]
Message-ID: <20220516145823.148450-3-thuth@redhat.com> (raw)
In-Reply-To: <20220516145823.148450-1-thuth@redhat.com>
According to
https://lore.kernel.org/qemu-devel/20200921174118.39352-1-richard.henderson@linaro.org/
there was an issue with Capstone 3 from Ubuntu 18. Now that we removed
support for Ubuntu 18.04, that issue should hopefully not bite us
anymore. Compiling with version 3.0.5 seems to work fine on other
systems, so let's allow that version again.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
meson.build | 2 +-
.gitlab-ci.d/buildtest.yml | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index 9b20dcd143..63ea585702 100644
--- a/meson.build
+++ b/meson.build
@@ -2513,7 +2513,7 @@ capstone = not_found
capstone_opt = get_option('capstone')
if capstone_opt in ['enabled', 'auto', 'system']
have_internal = fs.exists(meson.current_source_dir() / 'capstone/Makefile')
- capstone = dependency('capstone', version: '>=4.0',
+ capstone = dependency('capstone', version: '>=3.0.5',
kwargs: static_kwargs, method: 'pkg-config',
required: capstone_opt == 'system' or
capstone_opt == 'enabled' and not have_internal)
diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml
index 0aea7ab84c..a4d43d743b 100644
--- a/.gitlab-ci.d/buildtest.yml
+++ b/.gitlab-ci.d/buildtest.yml
@@ -42,6 +42,7 @@ build-system-ubuntu:
variables:
IMAGE: ubuntu2004
CONFIGURE_ARGS: --enable-docs --enable-fdt=system --enable-slirp=system
+ --enable-capstone=system
TARGETS: aarch64-softmmu alpha-softmmu cris-softmmu hppa-softmmu
microblazeel-softmmu mips64el-softmmu
MAKE_CHECK_ARGS: check-build
--
2.27.0
next prev parent reply other threads:[~2022-05-16 15:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 14:58 [RFC PATCH 0/3] Allow Capstone 3.0.5 again and remove the submodule Thomas Huth
2022-05-16 14:58 ` [PATCH 1/3] tests/vm: Add capstone to the NetBSD and OpenBSD VMs Thomas Huth
2022-05-17 5:37 ` Richard Henderson
2022-05-16 14:58 ` Thomas Huth [this message]
2022-05-16 15:46 ` [PATCH 2/3] capstone: Allow version 3.0.5 again Peter Maydell
2022-05-16 16:46 ` Richard Henderson
2022-05-16 16:53 ` Peter Maydell
2022-05-16 19:14 ` Richard Henderson
2022-05-16 19:22 ` Thomas Huth
2022-05-17 5:35 ` Richard Henderson
2022-05-17 5:40 ` Richard Henderson
2022-05-16 14:58 ` [PATCH 3/3] capstone: Remove the capstone submodule Thomas Huth
2022-05-17 5:42 ` Richard Henderson
2022-05-19 11:41 ` Peter Maydell
2022-05-23 12:15 ` Thomas Huth
2022-06-03 0:03 ` Richard Henderson
2022-06-03 0:56 ` Richard Henderson
2022-06-03 5:21 ` Thomas Huth
2022-06-03 13:48 ` Richard Henderson
2022-06-03 15:05 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220516145823.148450-3-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).