qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: alex.bennee@linaro.org, richard.henderson@linaro.org
Subject: [PATCH 02/16] build: clean up ninja invocation
Date: Tue, 17 May 2022 11:26:02 +0200	[thread overview]
Message-ID: <20220517092616.1272238-3-pbonzini@redhat.com> (raw)
In-Reply-To: <20220517092616.1272238-1-pbonzini@redhat.com>

Fix an incorrect "@@:" and move "-d keepdepfile" to the NINJAFLAGS variable.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Makefile b/Makefile
index b842dbccdb..fad312040f 100644
--- a/Makefile
+++ b/Makefile
@@ -143,7 +143,7 @@ MAKE.q = $(findstring q,$(firstword $(filter-out --%,$(MAKEFLAGS))))
 MAKE.nq = $(if $(word 2, $(MAKE.n) $(MAKE.q)),nq)
 NINJAFLAGS = $(if $V,-v) $(if $(MAKE.n), -n) $(if $(MAKE.k), -k0) \
         $(filter-out -j, $(lastword -j1 $(filter -l% -j%, $(MAKEFLAGS)))) \
-
+        -d keepdepfile
 ninja-cmd-goals = $(or $(MAKECMDGOALS), all)
 ninja-cmd-goals += $(foreach t, $(.check.build-suites), $(.check-$t.deps))
 ninja-cmd-goals += $(foreach t, $(.bench.build-suites), $(.bench-$t.deps))
@@ -160,8 +160,8 @@ $(ninja-targets): run-ninja
 # --output-sync line.
 run-ninja: config-host.mak
 ifneq ($(filter $(ninja-targets), $(ninja-cmd-goals)),)
-	+$(quiet-@)$(if $(MAKE.nq),@:, $(NINJA) -d keepdepfile \
-	   $(NINJAFLAGS) $(sort $(filter $(ninja-targets), $(ninja-cmd-goals))) | cat)
+	+$(if $(MAKE.nq),@:,$(quiet-@)$(NINJA) $(NINJAFLAGS) \
+	   $(sort $(filter $(ninja-targets), $(ninja-cmd-goals))) | cat)
 endif
 endif
 
-- 
2.36.0



  parent reply	other threads:[~2022-05-17  9:29 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-17  9:26 [PATCH 00/16] Cross compilation of embedded firmware Paolo Bonzini
2022-05-17  9:26 ` [PATCH 01/16] configure: do not define or use the CPP variable Paolo Bonzini
2022-05-17 18:07   ` Richard Henderson
2022-05-17 18:47     ` Paolo Bonzini
2022-05-17  9:26 ` Paolo Bonzini [this message]
2022-05-17 18:08   ` [PATCH 02/16] build: clean up ninja invocation Richard Henderson
2022-05-17  9:26 ` [PATCH 03/16] build: add a more generic way to specify make->ninja dependencies Paolo Bonzini
2022-05-17  9:26 ` [PATCH 04/16] build: do a full build before running TCG tests Paolo Bonzini
2022-05-17 18:10   ` Richard Henderson
2022-05-17  9:26 ` [PATCH 05/16] configure, meson: move symlinking of ROMs to meson Paolo Bonzini
2022-05-17  9:26 ` [PATCH 06/16] tests/tcg: correct target CPU for sparc32 Paolo Bonzini
2022-05-17 18:11   ` Richard Henderson
2022-05-17  9:26 ` [PATCH 07/16] tests/tcg: merge configure.sh back into main configure script Paolo Bonzini
2022-05-17 18:15   ` Richard Henderson
2022-05-17  9:26 ` [PATCH 08/16] configure: add missing cross compiler fallbacks Paolo Bonzini
2022-05-17 18:15   ` Richard Henderson
2022-05-17  9:26 ` [PATCH 09/16] configure: handle host compiler in probe_target_compiler Paolo Bonzini
2022-05-17 18:16   ` Richard Henderson
2022-05-17  9:26 ` [PATCH 10/16] configure: introduce --cross-prefix-*= Paolo Bonzini
2022-05-17  9:26 ` [PATCH 11/16] configure: include more binutils in tests/tcg makefile Paolo Bonzini
2022-05-17  9:26 ` [PATCH 12/16] configure: move symlink configuration earlier Paolo Bonzini
2022-05-17  9:26 ` [PATCH 13/16] configure: enable cross-compilation of s390-ccw Paolo Bonzini
2022-05-17  9:26 ` [PATCH 14/16] configure: enable cross-compilation of optionrom Paolo Bonzini
2022-05-17  9:26 ` [PATCH 15/16] configure: enable cross compilation of vof Paolo Bonzini
2022-05-17  9:26 ` [PATCH 16/16] configure: remove unused variables from config-host.mak Paolo Bonzini
2022-05-24 15:53 ` [PATCH 00/16] Cross compilation of embedded firmware Alex Bennée
2022-05-25 13:16   ` Paolo Bonzini
2022-05-26  9:48     ` Paolo Bonzini
2022-05-26 16:49 ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220517092616.1272238-3-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).