From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: Richard Henderson <richard.henderson@linaro.org>
Subject: [PULL 7/8] capstone: Allow version 3.0.5 again
Date: Wed, 18 May 2022 11:04:37 +0200 [thread overview]
Message-ID: <20220518090438.158475-8-thuth@redhat.com> (raw)
In-Reply-To: <20220518090438.158475-1-thuth@redhat.com>
According to
https://lore.kernel.org/qemu-devel/20200921174118.39352-1-richard.henderson@linaro.org/
there was an issue with Capstone 3.0.4 from Ubuntu 18, which was the reason
for bumping our minimum Capstone requirement to version 4.0. And indeed,
compiling with that version 3.0.4 from Ubuntu 18.04 still fails (after
allowing it with a hack in meson.build). But now that we've dropped support
for Ubuntu 18.04, that issue is not relevant anymore. Compiling with Capstone
version 3.0.5 (e.g. used in Ubuntu 20.04) seems to work fine, so let's allow
that version again.
Message-Id: <20220516145823.148450-3-thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
meson.build | 2 +-
.gitlab-ci.d/buildtest.yml | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index 53a4728250..526ff29a86 100644
--- a/meson.build
+++ b/meson.build
@@ -2525,7 +2525,7 @@ capstone = not_found
capstone_opt = get_option('capstone')
if capstone_opt in ['enabled', 'auto', 'system']
have_internal = fs.exists(meson.current_source_dir() / 'capstone/Makefile')
- capstone = dependency('capstone', version: '>=4.0',
+ capstone = dependency('capstone', version: '>=3.0.5',
kwargs: static_kwargs, method: 'pkg-config',
required: capstone_opt == 'system' or
capstone_opt == 'enabled' and not have_internal)
diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml
index 0aea7ab84c..a4d43d743b 100644
--- a/.gitlab-ci.d/buildtest.yml
+++ b/.gitlab-ci.d/buildtest.yml
@@ -42,6 +42,7 @@ build-system-ubuntu:
variables:
IMAGE: ubuntu2004
CONFIGURE_ARGS: --enable-docs --enable-fdt=system --enable-slirp=system
+ --enable-capstone=system
TARGETS: aarch64-softmmu alpha-softmmu cris-softmmu hppa-softmmu
microblazeel-softmmu mips64el-softmmu
MAKE_CHECK_ARGS: check-build
--
2.27.0
next prev parent reply other threads:[~2022-05-18 9:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 9:04 [PULL 0/8] Misc patches (Gitlab-CI, qtest, Capstone, ...) Thomas Huth
2022-05-18 9:04 ` [PULL 1/8] gitlab-ci: Switch the container of the 'check-patch' & 'check-dco' jobs Thomas Huth
2022-05-18 9:04 ` [PULL 2/8] Remove Ubuntu 18.04 container support from the repository Thomas Huth
2022-05-18 9:04 ` [PULL 3/8] tests/qtest: fix registration of ABRT handler for QEMU cleanup Thomas Huth
2022-05-18 9:04 ` [PULL 4/8] tests/qtest: use prctl(PR_SET_PDEATHSIG) as fallback to kill QEMU Thomas Huth
2022-05-18 9:04 ` [PULL 5/8] docs/about: Update the support statement for Windows Thomas Huth
2022-05-18 9:04 ` [PULL 6/8] tests/vm: Add capstone to the NetBSD and OpenBSD VMs Thomas Huth
2022-05-18 9:04 ` Thomas Huth [this message]
2022-05-18 9:04 ` [PULL 8/8] capstone: Remove the capstone submodule Thomas Huth
2022-05-18 16:12 ` [PULL 0/8] Misc patches (Gitlab-CI, qtest, Capstone, ...) Richard Henderson
2022-05-19 6:29 ` Thomas Huth
2022-05-19 11:29 ` Stefan Hajnoczi
2022-05-19 11:43 ` Daniel P. Berrangé
2022-05-19 11:55 ` Peter Maydell
2022-05-20 6:22 ` Thomas Huth
2022-05-20 18:51 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220518090438.158475-8-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).