qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, "Gerd Hoffmann" <kraxel@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	libvir-list@redhat.com,
	"Daniel P . Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser
Date: Wed, 18 May 2022 10:41:00 -0500	[thread overview]
Message-ID: <20220518154100.7yoqrgdsdgnwhepu@redhat.com> (raw)
In-Reply-To: <20220518134446.211632-3-thuth@redhat.com>

On Wed, May 18, 2022 at 03:44:45PM +0200, Thomas Huth wrote:
> The "-display sdl" option still uses a hand-crafted parser for its
> parameters since we didn't want to drag an interface we considered
> somewhat flawed into the QAPI schema. Since the flaws are gone now,
> it's time to QAPIfy.
> 
> This introduces the new "DisplaySDL" QAPI struct that is used to hold
> the parameters that are unique to the SDL display. The only specific
> parameter is currently "grab-mod" that is used to specify the required
> modifier keys to escape from the mouse grabbing mode.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---

> +++ b/qapi/ui.json
> @@ -1295,6 +1295,30 @@
>        '*swap-opt-cmd': 'bool'
>    } }
>  
> +##
> +# @GrabMod:
> +#
> +# Set of modifier keys that need to be hold for shortcut key actions.

s/hold/held/

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



  parent reply	other threads:[~2022-05-18 15:41 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-18 13:44 [PATCH v2 0/3] ui: Remove deprecated sdl parameters and switch to QAPI parser Thomas Huth
2022-05-18 13:44 ` [PATCH v2 1/3] ui: Remove deprecated parameters of the "-display sdl" option Thomas Huth
2022-05-18 15:04   ` Markus Armbruster
2022-05-18 13:44 ` [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser Thomas Huth
2022-05-18 15:08   ` Markus Armbruster
2022-05-19  6:39     ` Thomas Huth
2022-05-19  7:08       ` Thomas Huth
2022-05-19  7:27         ` Thomas Huth
2022-05-19  7:51           ` Daniel P. Berrangé
2022-05-19  8:57             ` Markus Armbruster
2022-05-19  9:09               ` Thomas Huth
2022-05-19  9:13             ` Thomas Huth
2022-05-19 10:48           ` Gerd Hoffmann
2022-05-19 11:00             ` Thomas Huth
2022-05-19 11:19               ` Gerd Hoffmann
2022-05-19  7:33       ` Markus Armbruster
2022-05-18 15:41   ` Eric Blake [this message]
2022-05-19  6:41     ` Thomas Huth
2022-05-18 13:44 ` [PATCH v2 3/3] ui: Remove deprecated options "-sdl" and "-curses" Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220518154100.7yoqrgdsdgnwhepu@redhat.com \
    --to=eblake@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=libvir-list@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).