qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Bernhard Beschow <shentey@gmail.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, "Bernhard Beschow" <shentey@gmail.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Gerd Hoffmann" <kraxel@redhat.com>
Subject: [PATCH v2 02/10] hw/audio/cs4231a: Const'ify global tables
Date: Fri, 20 May 2022 20:01:01 +0200	[thread overview]
Message-ID: <20220520180109.8224-3-shentey@gmail.com> (raw)
In-Reply-To: <20220520180109.8224-1-shentey@gmail.com>

The tables contain spcifically crafted constants for algorithms, so make
them immutable.

Signed-off-by: Bernhard Beschow <shentey@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 hw/audio/cs4231a.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/hw/audio/cs4231a.c b/hw/audio/cs4231a.c
index 0723e39430..7f17a72a9c 100644
--- a/hw/audio/cs4231a.c
+++ b/hw/audio/cs4231a.c
@@ -84,7 +84,7 @@ struct CSState {
     int transferred;
     int aci_counter;
     SWVoiceOut *voice;
-    int16_t *tab;
+    const int16_t *tab;
 };
 
 #define MODE2 (1 << 6)
@@ -142,13 +142,13 @@ enum {
     Capture_Lower_Base_Count
 };
 
-static int freqs[2][8] = {
+static const int freqs[2][8] = {
     { 8000, 16000, 27420, 32000,    -1,    -1, 48000, 9000 },
     { 5510, 11025, 18900, 22050, 37800, 44100, 33075, 6620 }
 };
 
 /* Tables courtesy http://hazelware.luggle.com/tutorials/mulawcompression.html */
-static int16_t MuLawDecompressTable[256] =
+static const int16_t MuLawDecompressTable[256] =
 {
      -32124,-31100,-30076,-29052,-28028,-27004,-25980,-24956,
      -23932,-22908,-21884,-20860,-19836,-18812,-17788,-16764,
@@ -184,7 +184,7 @@ static int16_t MuLawDecompressTable[256] =
          56,    48,    40,    32,    24,    16,     8,     0
 };
 
-static int16_t ALawDecompressTable[256] =
+static const int16_t ALawDecompressTable[256] =
 {
      -5504, -5248, -6016, -5760, -4480, -4224, -4992, -4736,
      -7552, -7296, -8064, -7808, -6528, -6272, -7040, -6784,
-- 
2.36.1



  parent reply	other threads:[~2022-05-20 18:07 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-20 18:00 [PATCH v2 00/10] Random cleanup patches Bernhard Beschow
2022-05-20 18:01 ` [PATCH v2 01/10] hw: Reuse TYPE_I8042 define Bernhard Beschow
2022-05-21  9:46   ` Mark Cave-Ayland
2022-05-20 18:01 ` Bernhard Beschow [this message]
2022-05-20 18:01 ` [PATCH v2 03/10] hw/i386/pc: Unexport PC_CPU_MODEL_IDS macro Bernhard Beschow
2022-05-20 18:01 ` [PATCH v2 04/10] hw/i386/pc: Unexport functions used only internally Bernhard Beschow
2022-05-20 18:01 ` [PATCH v2 05/10] hw/i386/pc: Remove orphan declarations Bernhard Beschow
2022-05-20 18:01 ` [PATCH v2 06/10] hw/ppc/e500: Remove unused BINARY_DEVICE_TREE_FILE Bernhard Beschow
2022-05-26 21:33   ` Daniel Henrique Barboza
2022-05-20 18:01 ` [PATCH v2 07/10] hw/net/fsl_etsec/etsec: Remove obsolete and unused etsec_create() Bernhard Beschow
2022-05-21  9:48   ` Mark Cave-Ayland
2022-05-20 18:01 ` [PATCH v2 08/10] accel/tcg/cpu-exec: Unexport dump_drift_info() Bernhard Beschow
2022-05-20 18:02   ` Bernhard Beschow
2022-05-22 22:38   ` Philippe Mathieu-Daudé via
2022-05-20 18:01 ` [PATCH v2 09/10] accel/tcg: Inline dump_opcount_info() and remove it Bernhard Beschow
2022-05-20 18:03   ` Bernhard Beschow
2022-05-22 22:39   ` Philippe Mathieu-Daudé via
2022-05-20 18:01 ` [PATCH v2 10/10] docs/devel: Fix link to developer mailing lists Bernhard Beschow
2022-05-20 18:03   ` Bernhard Beschow
2022-05-21  9:55 ` [PATCH v2 00/10] Random cleanup patches Mark Cave-Ayland
2022-05-23 19:30   ` Daniel Henrique Barboza
2022-06-03 10:42   ` Bernhard Beschow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220520180109.8224-3-shentey@gmail.com \
    --to=shentey@gmail.com \
    --cc=f4bug@amsat.org \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).