From: Bernhard Beschow <shentey@gmail.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, "Bernhard Beschow" <shentey@gmail.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Jason Wang" <jasowang@redhat.com>,
qemu-ppc@nongnu.org (open list:e500)
Subject: [PATCH v2 07/10] hw/net/fsl_etsec/etsec: Remove obsolete and unused etsec_create()
Date: Fri, 20 May 2022 20:01:06 +0200 [thread overview]
Message-ID: <20220520180109.8224-8-shentey@gmail.com> (raw)
In-Reply-To: <20220520180109.8224-1-shentey@gmail.com>
etsec_create() wraps qdev API which is outdated. It is also unused,
so remove it.
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/net/fsl_etsec/etsec.c | 23 -----------------------
hw/net/fsl_etsec/etsec.h | 7 -------
2 files changed, 30 deletions(-)
diff --git a/hw/net/fsl_etsec/etsec.c b/hw/net/fsl_etsec/etsec.c
index 4e6cc708de..b75d8e3dce 100644
--- a/hw/net/fsl_etsec/etsec.c
+++ b/hw/net/fsl_etsec/etsec.c
@@ -443,26 +443,3 @@ static void etsec_register_types(void)
}
type_init(etsec_register_types)
-
-DeviceState *etsec_create(hwaddr base,
- MemoryRegion * mr,
- NICInfo * nd,
- qemu_irq tx_irq,
- qemu_irq rx_irq,
- qemu_irq err_irq)
-{
- DeviceState *dev;
-
- dev = qdev_new("eTSEC");
- qdev_set_nic_properties(dev, nd);
- sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal);
-
- sysbus_connect_irq(SYS_BUS_DEVICE(dev), 0, tx_irq);
- sysbus_connect_irq(SYS_BUS_DEVICE(dev), 1, rx_irq);
- sysbus_connect_irq(SYS_BUS_DEVICE(dev), 2, err_irq);
-
- memory_region_add_subregion(mr, base,
- SYS_BUS_DEVICE(dev)->mmio[0].memory);
-
- return dev;
-}
diff --git a/hw/net/fsl_etsec/etsec.h b/hw/net/fsl_etsec/etsec.h
index fddf551544..3c625c955c 100644
--- a/hw/net/fsl_etsec/etsec.h
+++ b/hw/net/fsl_etsec/etsec.h
@@ -155,13 +155,6 @@ OBJECT_DECLARE_SIMPLE_TYPE(eTSEC, ETSEC_COMMON)
#define eTSEC_TRANSMIT 1
#define eTSEC_RECEIVE 2
-DeviceState *etsec_create(hwaddr base,
- MemoryRegion *mr,
- NICInfo *nd,
- qemu_irq tx_irq,
- qemu_irq rx_irq,
- qemu_irq err_irq);
-
void etsec_update_irq(eTSEC *etsec);
void etsec_walk_tx_ring(eTSEC *etsec, int ring_nbr);
--
2.36.1
next prev parent reply other threads:[~2022-05-20 18:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 18:00 [PATCH v2 00/10] Random cleanup patches Bernhard Beschow
2022-05-20 18:01 ` [PATCH v2 01/10] hw: Reuse TYPE_I8042 define Bernhard Beschow
2022-05-21 9:46 ` Mark Cave-Ayland
2022-05-20 18:01 ` [PATCH v2 02/10] hw/audio/cs4231a: Const'ify global tables Bernhard Beschow
2022-05-20 18:01 ` [PATCH v2 03/10] hw/i386/pc: Unexport PC_CPU_MODEL_IDS macro Bernhard Beschow
2022-05-20 18:01 ` [PATCH v2 04/10] hw/i386/pc: Unexport functions used only internally Bernhard Beschow
2022-05-20 18:01 ` [PATCH v2 05/10] hw/i386/pc: Remove orphan declarations Bernhard Beschow
2022-05-20 18:01 ` [PATCH v2 06/10] hw/ppc/e500: Remove unused BINARY_DEVICE_TREE_FILE Bernhard Beschow
2022-05-26 21:33 ` Daniel Henrique Barboza
2022-05-20 18:01 ` Bernhard Beschow [this message]
2022-05-21 9:48 ` [PATCH v2 07/10] hw/net/fsl_etsec/etsec: Remove obsolete and unused etsec_create() Mark Cave-Ayland
2022-05-20 18:01 ` [PATCH v2 08/10] accel/tcg/cpu-exec: Unexport dump_drift_info() Bernhard Beschow
2022-05-20 18:02 ` Bernhard Beschow
2022-05-22 22:38 ` Philippe Mathieu-Daudé via
2022-05-20 18:01 ` [PATCH v2 09/10] accel/tcg: Inline dump_opcount_info() and remove it Bernhard Beschow
2022-05-20 18:03 ` Bernhard Beschow
2022-05-22 22:39 ` Philippe Mathieu-Daudé via
2022-05-20 18:01 ` [PATCH v2 10/10] docs/devel: Fix link to developer mailing lists Bernhard Beschow
2022-05-20 18:03 ` Bernhard Beschow
2022-05-21 9:55 ` [PATCH v2 00/10] Random cleanup patches Mark Cave-Ayland
2022-05-23 19:30 ` Daniel Henrique Barboza
2022-06-03 10:42 ` Bernhard Beschow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220520180109.8224-8-shentey@gmail.com \
--to=shentey@gmail.com \
--cc=f4bug@amsat.org \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).