qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Xie Yongji <xieyongji@bytedance.com>
To: mst@redhat.com, jasowang@redhat.com, stefanha@redhat.com,
	sgarzare@redhat.com, kwolf@redhat.com, mreitz@redhat.com,
	mlureau@redhat.com, jsnow@redhat.com, eblake@redhat.com,
	Coiby.Xu@gmail.com, hreitz@redhat.com
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org
Subject: [PATCH v6 2/8] block/export: Fix incorrect length passed to vu_queue_push()
Date: Mon, 23 May 2022 16:46:05 +0800	[thread overview]
Message-ID: <20220523084611.91-3-xieyongji@bytedance.com> (raw)
In-Reply-To: <20220523084611.91-1-xieyongji@bytedance.com>

Now the req->size is set to the correct value only
when handling VIRTIO_BLK_T_GET_ID request. This patch
fixes it.

Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
---
 block/export/vhost-user-blk-server.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/block/export/vhost-user-blk-server.c b/block/export/vhost-user-blk-server.c
index b2e458ade3..19c6ee51d3 100644
--- a/block/export/vhost-user-blk-server.c
+++ b/block/export/vhost-user-blk-server.c
@@ -60,8 +60,7 @@ static void vu_blk_req_complete(VuBlkReq *req)
 {
     VuDev *vu_dev = &req->server->vu_dev;
 
-    /* IO size with 1 extra status byte */
-    vu_queue_push(vu_dev, req->vq, &req->elem, req->size + 1);
+    vu_queue_push(vu_dev, req->vq, &req->elem, req->size);
     vu_queue_notify(vu_dev, req->vq);
 
     free(req);
@@ -207,6 +206,7 @@ static void coroutine_fn vu_blk_virtio_process_req(void *opaque)
         goto err;
     }
 
+    req->size = iov_size(in_iov, in_num);
     /* We always touch the last byte, so just see how big in_iov is.  */
     req->in = (void *)in_iov[in_num - 1].iov_base
               + in_iov[in_num - 1].iov_len
@@ -267,7 +267,6 @@ static void coroutine_fn vu_blk_virtio_process_req(void *opaque)
                           VIRTIO_BLK_ID_BYTES);
         snprintf(elem->in_sg[0].iov_base, size, "%s", "vhost_user_blk");
         req->in->status = VIRTIO_BLK_S_OK;
-        req->size = elem->in_sg[0].iov_len;
         break;
     }
     case VIRTIO_BLK_T_DISCARD:
-- 
2.20.1



  parent reply	other threads:[~2022-05-23  9:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-23  8:46 [PATCH v6 0/8] Support exporting BDSs via VDUSE Xie Yongji
2022-05-23  8:46 ` [PATCH v6 1/8] block: Support passing NULL ops to blk_set_dev_ops() Xie Yongji
2022-05-23  8:46 ` Xie Yongji [this message]
2022-05-23  8:46 ` [PATCH v6 3/8] block/export: Abstract out the logic of virtio-blk I/O process Xie Yongji
2022-05-23  8:46 ` [PATCH v6 4/8] linux-headers: Add vduse.h Xie Yongji
2022-05-23  8:46 ` [PATCH v6 5/8] libvduse: Add VDUSE (vDPA Device in Userspace) library Xie Yongji
2022-06-03 11:25   ` Maxime Coquelin
2022-06-06 12:56     ` Yongji Xie
2022-05-23  8:46 ` [PATCH v6 6/8] vduse-blk: Implement vduse-blk export Xie Yongji
2022-05-27 15:33   ` Kevin Wolf
2022-05-29  8:13     ` Yongji Xie
2022-05-23  8:46 ` [PATCH v6 7/8] vduse-blk: Add vduse-blk resize support Xie Yongji
2022-05-23  8:46 ` [PATCH v6 8/8] libvduse: Add support for reconnecting Xie Yongji
2022-05-25 11:02 ` [PATCH v6 0/8] Support exporting BDSs via VDUSE Stefan Hajnoczi
2022-05-25 12:52   ` Yongji Xie
2022-05-25 12:48 ` Stefan Hajnoczi
2022-05-25 12:51   ` Yongji Xie
2022-05-27 15:48 ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220523084611.91-3-xieyongji@bytedance.com \
    --to=xieyongji@bytedance.com \
    --cc=Coiby.Xu@gmail.com \
    --cc=eblake@redhat.com \
    --cc=hreitz@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mlureau@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sgarzare@redhat.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).