* [PATCH] trivial: qga: Log version on start
@ 2022-05-23 14:56 Konstantin Kostiuk
2022-05-23 17:34 ` Marc-André Lureau
0 siblings, 1 reply; 3+ messages in thread
From: Konstantin Kostiuk @ 2022-05-23 14:56 UTC (permalink / raw)
To: qemu-devel; +Cc: Marc-André Lureau, Michael Roth
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
---
qga/main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/qga/main.c b/qga/main.c
index 3b9546c185..a58368c75e 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -1271,6 +1271,8 @@ static GAState *initialize_agent(GAConfig *config, int socket_activation)
g_log_set_fatal_mask(NULL, G_LOG_LEVEL_ERROR);
ga_enable_logging(s);
+ g_debug("Guest agent version %s started", QEMU_VERSION);
+
#ifdef _WIN32
/* On win32 the state directory is application specific (be it the default
* or a user override). We got past the command line parsing; let's create
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] trivial: qga: Log version on start
2022-05-23 14:56 [PATCH] trivial: qga: Log version on start Konstantin Kostiuk
@ 2022-05-23 17:34 ` Marc-André Lureau
2022-05-23 19:16 ` Konstantin Kostiuk
0 siblings, 1 reply; 3+ messages in thread
From: Marc-André Lureau @ 2022-05-23 17:34 UTC (permalink / raw)
To: Konstantin Kostiuk; +Cc: qemu-devel, Michael Roth
On Mon, May 23, 2022 at 4:56 PM Konstantin Kostiuk <kkostiuk@redhat.com> wrote:
>
> Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
why not, and why not QEMU_FULL_VERSION? :)
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> qga/main.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/qga/main.c b/qga/main.c
> index 3b9546c185..a58368c75e 100644
> --- a/qga/main.c
> +++ b/qga/main.c
> @@ -1271,6 +1271,8 @@ static GAState *initialize_agent(GAConfig *config, int socket_activation)
> g_log_set_fatal_mask(NULL, G_LOG_LEVEL_ERROR);
> ga_enable_logging(s);
>
> + g_debug("Guest agent version %s started", QEMU_VERSION);
> +
> #ifdef _WIN32
> /* On win32 the state directory is application specific (be it the default
> * or a user override). We got past the command line parsing; let's create
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] trivial: qga: Log version on start
2022-05-23 17:34 ` Marc-André Lureau
@ 2022-05-23 19:16 ` Konstantin Kostiuk
0 siblings, 0 replies; 3+ messages in thread
From: Konstantin Kostiuk @ 2022-05-23 19:16 UTC (permalink / raw)
To: Marc-André Lureau; +Cc: qemu-devel, Michael Roth
[-- Attachment #1: Type: text/plain, Size: 1145 bytes --]
On Mon, May 23, 2022 at 8:35 PM Marc-André Lureau <
marcandre.lureau@redhat.com> wrote:
> On Mon, May 23, 2022 at 4:56 PM Konstantin Kostiuk <kkostiuk@redhat.com>
> wrote:
> >
> > Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
>
> why not, and why not QEMU_FULL_VERSION? :)
>
QEMU_FULL_VERSION is good too, no specific reason to use QEMU_VERSION.
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> > ---
> > qga/main.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/qga/main.c b/qga/main.c
> > index 3b9546c185..a58368c75e 100644
> > --- a/qga/main.c
> > +++ b/qga/main.c
> > @@ -1271,6 +1271,8 @@ static GAState *initialize_agent(GAConfig *config,
> int socket_activation)
> > g_log_set_fatal_mask(NULL, G_LOG_LEVEL_ERROR);
> > ga_enable_logging(s);
> >
> > + g_debug("Guest agent version %s started", QEMU_VERSION);
> > +
> > #ifdef _WIN32
> > /* On win32 the state directory is application specific (be it the
> default
> > * or a user override). We got past the command line parsing; let's
> create
> > --
> > 2.25.1
> >
>
>
[-- Attachment #2: Type: text/html, Size: 1960 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-23 19:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-23 14:56 [PATCH] trivial: qga: Log version on start Konstantin Kostiuk
2022-05-23 17:34 ` Marc-André Lureau
2022-05-23 19:16 ` Konstantin Kostiuk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).