From: Matthew Rosato <mjrosato@linux.ibm.com>
To: qemu-s390x@nongnu.org
Cc: alex.williamson@redhat.com, schnelle@linux.ibm.com,
cohuck@redhat.com, thuth@redhat.com, farman@linux.ibm.com,
pmorel@linux.ibm.com, richard.henderson@linaro.org,
david@redhat.com, pasic@linux.ibm.com, borntraeger@linux.ibm.com,
mst@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org,
kvm@vger.kernel.org
Subject: [PATCH v6 5/8] s390x/pci: don't fence interpreted devices without MSI-X
Date: Tue, 24 May 2022 15:03:02 -0400 [thread overview]
Message-ID: <20220524190305.140717-6-mjrosato@linux.ibm.com> (raw)
In-Reply-To: <20220524190305.140717-1-mjrosato@linux.ibm.com>
Lack of MSI-X support is not an issue for interpreted passthrough
devices, so let's let these in. This will allow, for example, ISM
devices to be passed through -- but only when interpretation is
available and being used.
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Pierre Morel <pmorel@linux.ibm.com>
Signed-off-by: Matthew Rosato <mjrosato@linux.ibm.com>
---
hw/s390x/s390-pci-bus.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
index 156051e6e9..816d17af99 100644
--- a/hw/s390x/s390-pci-bus.c
+++ b/hw/s390x/s390-pci-bus.c
@@ -881,6 +881,10 @@ static int s390_pci_msix_init(S390PCIBusDevice *pbdev)
static void s390_pci_msix_free(S390PCIBusDevice *pbdev)
{
+ if (pbdev->msix.entries == 0) {
+ return;
+ }
+
memory_region_del_subregion(&pbdev->iommu->mr, &pbdev->msix_notify_mr);
object_unparent(OBJECT(&pbdev->msix_notify_mr));
}
@@ -1093,7 +1097,7 @@ static void s390_pcihost_plug(HotplugHandler *hotplug_dev, DeviceState *dev,
pbdev->interp = false;
}
- if (s390_pci_msix_init(pbdev)) {
+ if (s390_pci_msix_init(pbdev) && !pbdev->interp) {
error_setg(errp, "MSI-X support is mandatory "
"in the S390 architecture");
return;
--
2.27.0
next prev parent reply other threads:[~2022-05-24 19:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 19:02 [PATCH v6 0/8] s390x/pci: zPCI interpretation support Matthew Rosato
2022-05-24 19:02 ` [PATCH v6 1/8] Update linux headers Matthew Rosato
2022-05-24 19:02 ` [PATCH v6 2/8] target/s390x: add zpci-interp to cpu models Matthew Rosato
2022-06-01 9:52 ` David Hildenbrand
2022-06-01 13:48 ` Matthew Rosato
2022-06-01 14:10 ` David Hildenbrand
2022-06-01 15:11 ` Matthew Rosato
2022-06-02 8:58 ` David Hildenbrand
2022-05-24 19:03 ` [PATCH v6 3/8] s390x/pci: add routine to get host function handle from CLP info Matthew Rosato
2022-05-24 19:03 ` [PATCH v6 4/8] s390x/pci: enable for load/store intepretation Matthew Rosato
2022-05-24 19:03 ` Matthew Rosato [this message]
2022-05-24 19:03 ` [PATCH v6 6/8] s390x/pci: enable adapter event notification for interpreted devices Matthew Rosato
2022-05-24 19:03 ` [PATCH v6 7/8] s390x/pci: let intercept devices have separate PCI groups Matthew Rosato
2022-05-24 19:03 ` [PATCH v6 8/8] s390x/pci: reflect proper maxstbl for groups of interpreted devices Matthew Rosato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220524190305.140717-6-mjrosato@linux.ibm.com \
--to=mjrosato@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=farman@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=pmorel@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=schnelle@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).