From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: Leonardo Bras Soares Passos <lsoaresp@redhat.com>,
"Daniel P . Berrange" <berrange@redhat.com>,
Juan Quintela <quintela@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Manish Mishra <manish.mishra@nutanix.com>,
peterx@redhat.com
Subject: [PATCH v7 13/14] tests: Add postcopy tls recovery migration test
Date: Tue, 24 May 2022 18:11:50 -0400 [thread overview]
Message-ID: <20220524221151.18225-14-peterx@redhat.com> (raw)
In-Reply-To: <20220524221151.18225-1-peterx@redhat.com>
It's easy to build this upon the postcopy tls test. Rename the old
postcopy recovery test to postcopy/recovery/plain.
Signed-off-by: Peter Xu <peterx@redhat.com>
---
tests/qtest/migration-test.c | 38 +++++++++++++++++++++++++++---------
1 file changed, 29 insertions(+), 9 deletions(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index 03f7bb0d96..12f1e3a751 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@@ -1131,17 +1131,15 @@ static void test_postcopy_tls_psk(void)
test_postcopy_common(&args);
}
-static void test_postcopy_recovery(void)
+static void test_postcopy_recovery_common(MigrateCommon *args)
{
- MigrateCommon args = {
- .start = {
- .hide_stderr = true,
- },
- };
QTestState *from, *to;
g_autofree char *uri = NULL;
- if (migrate_postcopy_prepare(&from, &to, &args)) {
+ /* Always hide errors for postcopy recover tests since they're expected */
+ args->start.hide_stderr = true;
+
+ if (migrate_postcopy_prepare(&from, &to, args)) {
return;
}
@@ -1192,7 +1190,24 @@ static void test_postcopy_recovery(void)
/* Restore the postcopy bandwidth to unlimited */
migrate_set_parameter_int(from, "max-postcopy-bandwidth", 0);
- migrate_postcopy_complete(from, to, &args);
+ migrate_postcopy_complete(from, to, args);
+}
+
+static void test_postcopy_recovery(void)
+{
+ MigrateCommon args = { };
+
+ test_postcopy_recovery_common(&args);
+}
+
+static void test_postcopy_recovery_tls_psk(void)
+{
+ MigrateCommon args = {
+ .start_hook = test_migrate_tls_psk_start_match,
+ .finish_hook = test_migrate_tls_psk_finish,
+ };
+
+ test_postcopy_recovery_common(&args);
}
static void test_baddest(void)
@@ -2173,7 +2188,12 @@ int main(int argc, char **argv)
*/
qtest_add_func("/migration/postcopy/tls/psk", test_postcopy_tls_psk);
#endif /* CONFIG_GNUTLS */
- qtest_add_func("/migration/postcopy/recovery", test_postcopy_recovery);
+ qtest_add_func("/migration/postcopy/recovery/plain",
+ test_postcopy_recovery);
+#ifdef CONFIG_GNUTLS
+ qtest_add_func("/migration/postcopy/recovery/tls/psk",
+ test_postcopy_recovery_tls_psk);
+#endif /* CONFIG_GNUTLS */
qtest_add_func("/migration/bad_dest", test_baddest);
qtest_add_func("/migration/precopy/unix/plain", test_precopy_unix_plain);
qtest_add_func("/migration/precopy/unix/xbzrle", test_precopy_unix_xbzrle);
--
2.32.0
next prev parent reply other threads:[~2022-05-24 22:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 22:11 [PATCH v7 00/14] migration: Postcopy Preemption Peter Xu
2022-05-24 22:11 ` [PATCH v7 01/14] migration: Add postcopy-preempt capability Peter Xu
2022-06-21 21:03 ` Juan Quintela
2022-05-24 22:11 ` [PATCH v7 02/14] migration: Postcopy preemption preparation on channel creation Peter Xu
2022-06-22 0:05 ` Juan Quintela
2022-05-24 22:11 ` [PATCH v7 03/14] migration: Postcopy preemption enablement Peter Xu
2022-05-24 22:11 ` [PATCH v7 04/14] migration: Postcopy recover with preempt enabled Peter Xu
2022-05-24 22:11 ` [PATCH v7 05/14] migration: Create the postcopy preempt channel asynchronously Peter Xu
2022-05-24 22:11 ` [PATCH v7 06/14] migration: Add property x-postcopy-preempt-break-huge Peter Xu
2022-05-24 22:11 ` [PATCH v7 07/14] migration: Add helpers to detect TLS capability Peter Xu
2022-05-24 22:11 ` [PATCH v7 08/14] migration: Export tls-[creds|hostname|authz] params to cmdline too Peter Xu
2022-05-24 22:11 ` [PATCH v7 09/14] migration: Enable TLS for preempt channel Peter Xu
2022-05-24 22:11 ` [PATCH v7 10/14] migration: Respect postcopy request order in preemption mode Peter Xu
2022-05-24 22:11 ` [PATCH v7 11/14] tests: Move MigrateCommon upper Peter Xu
2022-05-25 8:26 ` Daniel P. Berrangé
2022-05-24 22:11 ` [PATCH v7 12/14] tests: Add postcopy tls migration test Peter Xu
2022-05-24 22:11 ` Peter Xu [this message]
2022-05-25 14:55 ` [PATCH v7 13/14] tests: Add postcopy tls recovery " Dr. David Alan Gilbert
2022-05-24 22:11 ` [PATCH v7 14/14] tests: Add postcopy preempt tests Peter Xu
2022-06-08 16:26 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220524221151.18225-14-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lsoaresp@redhat.com \
--cc=manish.mishra@nutanix.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).