* [PATCH v2 0/4] hw/gpio Add ASPEED GPIO model for AST1030
@ 2022-05-25 5:34 Jamin Lin
2022-05-25 5:34 ` [PATCH v2 1/4] hw/gpio Add GPIO read/write trace event Jamin Lin
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Jamin Lin @ 2022-05-25 5:34 UTC (permalink / raw)
To: Cédric Le Goater, Peter Maydell, Andrew Jeffery,
Joel Stanley, open list:ASPEED BMCs,
open list:All patches CC here
Cc: steven_lee, troy_lee, jamin_lin
-v2 changes
Create separate patches to support the following features
1. Add GPIO read/write trace event.
2. Support GPIO index mode for write operation.
It did not support GPIO index mode for read operation.
3. AST1030 integrates one set of Parallel GPIO Controller
with maximum 151 control pins, which are 21 groups
(A~U, exclude pin: M6 M7 Q5 Q6 Q7 R0 R1 R4 R5 R6 R7 S0 S3 S4
S5 S6 S7 ) and the group T and U are input only.
4. replace HWADDR_PRIx with PRIx64
Jamin Lin (4):
hw/gpio Add GPIO read/write trace event.
hw/gpio: Add ASPEED GPIO model for AST1030
hw/gpio support GPIO index mode for write operation.
hw/gpio: replace HWADDR_PRIx with PRIx64
hw/arm/aspeed_ast10x0.c | 11 ++
hw/gpio/aspeed_gpio.c | 257 +++++++++++++++++++++++++++++++---
hw/gpio/trace-events | 5 +
include/hw/gpio/aspeed_gpio.h | 16 ++-
4 files changed, 269 insertions(+), 20 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH v2 1/4] hw/gpio Add GPIO read/write trace event. 2022-05-25 5:34 [PATCH v2 0/4] hw/gpio Add ASPEED GPIO model for AST1030 Jamin Lin @ 2022-05-25 5:34 ` Jamin Lin 2022-05-25 5:34 ` [PATCH v2 2/4] hw/gpio: Add ASPEED GPIO model for AST1030 Jamin Lin ` (2 subsequent siblings) 3 siblings, 0 replies; 8+ messages in thread From: Jamin Lin @ 2022-05-25 5:34 UTC (permalink / raw) To: Cédric Le Goater, Peter Maydell, Andrew Jeffery, Joel Stanley, open list:ASPEED BMCs, open list:All patches CC here Cc: steven_lee, troy_lee, jamin_lin Add GPIO read/write trace event for aspeed model. Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com> --- hw/gpio/aspeed_gpio.c | 54 +++++++++++++++++++++++++++++++------------ hw/gpio/trace-events | 5 ++++ 2 files changed, 44 insertions(+), 15 deletions(-) diff --git a/hw/gpio/aspeed_gpio.c b/hw/gpio/aspeed_gpio.c index 9b736e7a9f..4620ea8e8b 100644 --- a/hw/gpio/aspeed_gpio.c +++ b/hw/gpio/aspeed_gpio.c @@ -15,6 +15,7 @@ #include "qapi/visitor.h" #include "hw/irq.h" #include "migration/vmstate.h" +#include "trace.h" #define GPIOS_PER_GROUP 8 @@ -523,11 +524,15 @@ static uint64_t aspeed_gpio_read(void *opaque, hwaddr offset, uint32_t size) uint64_t idx = -1; const AspeedGPIOReg *reg; GPIOSets *set; + uint32_t value = 0; + uint64_t debounce_value; idx = offset >> 2; if (idx >= GPIO_DEBOUNCE_TIME_1 && idx <= GPIO_DEBOUNCE_TIME_3) { idx -= GPIO_DEBOUNCE_TIME_1; - return (uint64_t) s->debounce_regs[idx]; + debounce_value = (uint64_t) s->debounce_regs[idx]; + trace_aspeed_gpio_read(offset, debounce_value); + return debounce_value; } reg = &agc->reg_table[idx]; @@ -540,38 +545,55 @@ static uint64_t aspeed_gpio_read(void *opaque, hwaddr offset, uint32_t size) set = &s->sets[reg->set_idx]; switch (reg->type) { case gpio_reg_data_value: - return set->data_value; + value = set->data_value; + break; case gpio_reg_direction: - return set->direction; + value = set->direction; + break; case gpio_reg_int_enable: - return set->int_enable; + value = set->int_enable; + break; case gpio_reg_int_sens_0: - return set->int_sens_0; + value = set->int_sens_0; + break; case gpio_reg_int_sens_1: - return set->int_sens_1; + value = set->int_sens_1; + break; case gpio_reg_int_sens_2: - return set->int_sens_2; + value = set->int_sens_2; + break; case gpio_reg_int_status: - return set->int_status; + value = set->int_status; + break; case gpio_reg_reset_tolerant: - return set->reset_tol; + value = set->reset_tol; + break; case gpio_reg_debounce_1: - return set->debounce_1; + value = set->debounce_1; + break; case gpio_reg_debounce_2: - return set->debounce_2; + value = set->debounce_2; + break; case gpio_reg_cmd_source_0: - return set->cmd_source_0; + value = set->cmd_source_0; + break; case gpio_reg_cmd_source_1: - return set->cmd_source_1; + value = set->cmd_source_1; + break; case gpio_reg_data_read: - return set->data_read; + value = set->data_read; + break; case gpio_reg_input_mask: - return set->input_mask; + value = set->input_mask; + break; default: qemu_log_mask(LOG_GUEST_ERROR, "%s: no getter for offset 0x%" HWADDR_PRIx"\n", __func__, offset); return 0; } + + trace_aspeed_gpio_read(offset, value); + return value; } static void aspeed_gpio_write(void *opaque, hwaddr offset, uint64_t data, @@ -585,6 +607,8 @@ static void aspeed_gpio_write(void *opaque, hwaddr offset, uint64_t data, GPIOSets *set; uint32_t cleared; + trace_aspeed_gpio_write(offset, data); + idx = offset >> 2; if (idx >= GPIO_DEBOUNCE_TIME_1 && idx <= GPIO_DEBOUNCE_TIME_3) { idx -= GPIO_DEBOUNCE_TIME_1; diff --git a/hw/gpio/trace-events b/hw/gpio/trace-events index 1dab99c560..e9cd4a5662 100644 --- a/hw/gpio/trace-events +++ b/hw/gpio/trace-events @@ -27,3 +27,8 @@ sifive_gpio_read(uint64_t offset, uint64_t r) "offset 0x%" PRIx64 " value 0x%" P sifive_gpio_write(uint64_t offset, uint64_t value) "offset 0x%" PRIx64 " value 0x%" PRIx64 sifive_gpio_set(int64_t line, int64_t value) "line %" PRIi64 " value %" PRIi64 sifive_gpio_update_output_irq(int64_t line, int64_t value) "line %" PRIi64 " value %" PRIi64 + +# aspeed_gpio.c +aspeed_gpio_read(uint64_t offset, uint64_t value) "offset: 0x%" PRIx64 " value 0x%" PRIx64 +aspeed_gpio_write(uint64_t offset, uint64_t value) "offset: 0x%" PRIx64 " value 0x%" PRIx64 + -- 2.17.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2 2/4] hw/gpio: Add ASPEED GPIO model for AST1030 2022-05-25 5:34 [PATCH v2 0/4] hw/gpio Add ASPEED GPIO model for AST1030 Jamin Lin 2022-05-25 5:34 ` [PATCH v2 1/4] hw/gpio Add GPIO read/write trace event Jamin Lin @ 2022-05-25 5:34 ` Jamin Lin 2022-05-25 6:26 ` Cédric Le Goater 2022-05-25 5:34 ` [PATCH v2 3/4] hw/gpio support GPIO index mode for write operation Jamin Lin 2022-05-25 5:34 ` [PATCH v2 4/4] hw/gpio: replace HWADDR_PRIx with PRIx64 Jamin Lin 3 siblings, 1 reply; 8+ messages in thread From: Jamin Lin @ 2022-05-25 5:34 UTC (permalink / raw) To: Cédric Le Goater, Peter Maydell, Andrew Jeffery, Joel Stanley, open list:ASPEED BMCs, open list:All patches CC here Cc: steven_lee, troy_lee, jamin_lin AST1030 integrates one set of Parallel GPIO Controller with maximum 151 control pins, which are 21 groups (A~U, exclude pin: M6 M7 Q5 Q6 Q7 R0 R1 R4 R5 R6 R7 S0 S3 S4 S5 S6 S7 ) and the group T and U are input only. Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com> --- hw/arm/aspeed_ast10x0.c | 11 +++++++++++ hw/gpio/aspeed_gpio.c | 27 +++++++++++++++++++++++++++ 2 files changed, 38 insertions(+) diff --git a/hw/arm/aspeed_ast10x0.c b/hw/arm/aspeed_ast10x0.c index 4271549282..3a6b8122b6 100644 --- a/hw/arm/aspeed_ast10x0.c +++ b/hw/arm/aspeed_ast10x0.c @@ -113,6 +113,9 @@ static void aspeed_soc_ast1030_init(Object *obj) snprintf(typename, sizeof(typename), "aspeed.wdt-%s", socname); object_initialize_child(obj, "wdt[*]", &s->wdt[i], typename); } + + snprintf(typename, sizeof(typename), "aspeed.gpio-%s", socname); + object_initialize_child(obj, "gpio", &s->gpio, typename); } static void aspeed_soc_ast1030_realize(DeviceState *dev_soc, Error **errp) @@ -260,6 +263,14 @@ static void aspeed_soc_ast1030_realize(DeviceState *dev_soc, Error **errp) sysbus_mmio_map(SYS_BUS_DEVICE(&s->wdt[i]), 0, sc->memmap[ASPEED_DEV_WDT] + i * awc->offset); } + + /* GPIO */ + if (!sysbus_realize(SYS_BUS_DEVICE(&s->gpio), errp)) { + return; + } + sysbus_mmio_map(SYS_BUS_DEVICE(&s->gpio), 0, sc->memmap[ASPEED_DEV_GPIO]); + sysbus_connect_irq(SYS_BUS_DEVICE(&s->gpio), 0, + aspeed_soc_get_irq(s, ASPEED_DEV_GPIO)); } static void aspeed_soc_ast1030_class_init(ObjectClass *klass, void *data) diff --git a/hw/gpio/aspeed_gpio.c b/hw/gpio/aspeed_gpio.c index 4620ea8e8b..5138fe812b 100644 --- a/hw/gpio/aspeed_gpio.c +++ b/hw/gpio/aspeed_gpio.c @@ -819,6 +819,15 @@ static GPIOSetProperties ast2600_1_8v_set_props[ASPEED_GPIO_MAX_NR_SETS] = { [1] = {0x0000000f, 0x0000000f, {"18E"} }, }; +static GPIOSetProperties ast1030_set_props[ASPEED_GPIO_MAX_NR_SETS] = { + [0] = {0xffffffff, 0xffffffff, {"A", "B", "C", "D"} }, + [1] = {0xffffffff, 0xffffffff, {"E", "F", "G", "H"} }, + [2] = {0xffffffff, 0xffffffff, {"I", "J", "K", "L"} }, + [3] = {0xffffff3f, 0xffffff3f, {"M", "N", "O", "P"} }, + [4] = {0xff060c1f, 0x00060c1f, {"Q", "R", "S", "T"} }, + [5] = {0x000000ff, 0x00000000, {"U"} }, +}; + static const MemoryRegionOps aspeed_gpio_ops = { .read = aspeed_gpio_read, .write = aspeed_gpio_write, @@ -971,6 +980,16 @@ static void aspeed_gpio_ast2600_1_8v_class_init(ObjectClass *klass, void *data) agc->reg_table = aspeed_1_8v_gpios; } +static void aspeed_gpio_1030_class_init(ObjectClass *klass, void *data) +{ + AspeedGPIOClass *agc = ASPEED_GPIO_CLASS(klass); + + agc->props = ast1030_set_props; + agc->nr_gpio_pins = 151; + agc->nr_gpio_sets = 6; + agc->reg_table = aspeed_3_3v_gpios; +} + static const TypeInfo aspeed_gpio_info = { .name = TYPE_ASPEED_GPIO, .parent = TYPE_SYS_BUS_DEVICE, @@ -1008,6 +1027,13 @@ static const TypeInfo aspeed_gpio_ast2600_1_8v_info = { .instance_init = aspeed_gpio_init, }; +static const TypeInfo aspeed_gpio_ast1030_info = { + .name = TYPE_ASPEED_GPIO "-ast1030", + .parent = TYPE_ASPEED_GPIO, + .class_init = aspeed_gpio_1030_class_init, + .instance_init = aspeed_gpio_init, +}; + static void aspeed_gpio_register_types(void) { type_register_static(&aspeed_gpio_info); @@ -1015,6 +1041,7 @@ static void aspeed_gpio_register_types(void) type_register_static(&aspeed_gpio_ast2500_info); type_register_static(&aspeed_gpio_ast2600_3_3v_info); type_register_static(&aspeed_gpio_ast2600_1_8v_info); + type_register_static(&aspeed_gpio_ast1030_info); } type_init(aspeed_gpio_register_types); -- 2.17.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/4] hw/gpio: Add ASPEED GPIO model for AST1030 2022-05-25 5:34 ` [PATCH v2 2/4] hw/gpio: Add ASPEED GPIO model for AST1030 Jamin Lin @ 2022-05-25 6:26 ` Cédric Le Goater 0 siblings, 0 replies; 8+ messages in thread From: Cédric Le Goater @ 2022-05-25 6:26 UTC (permalink / raw) To: Jamin Lin, Peter Maydell, Andrew Jeffery, Joel Stanley, open list:ASPEED BMCs, open list:All patches CC here Cc: steven_lee, troy_lee On 5/25/22 07:34, Jamin Lin wrote: > AST1030 integrates one set of Parallel GPIO Controller > with maximum 151 control pins, which are 21 groups > (A~U, exclude pin: M6 M7 Q5 Q6 Q7 R0 R1 R4 R5 R6 R7 S0 S3 S4 > S5 S6 S7 ) and the group T and U are input only. > > Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com> Reviewed-by: Cédric Le Goater <clg@kaod.org> Thanks, C. > --- > hw/arm/aspeed_ast10x0.c | 11 +++++++++++ > hw/gpio/aspeed_gpio.c | 27 +++++++++++++++++++++++++++ > 2 files changed, 38 insertions(+) > > diff --git a/hw/arm/aspeed_ast10x0.c b/hw/arm/aspeed_ast10x0.c > index 4271549282..3a6b8122b6 100644 > --- a/hw/arm/aspeed_ast10x0.c > +++ b/hw/arm/aspeed_ast10x0.c > @@ -113,6 +113,9 @@ static void aspeed_soc_ast1030_init(Object *obj) > snprintf(typename, sizeof(typename), "aspeed.wdt-%s", socname); > object_initialize_child(obj, "wdt[*]", &s->wdt[i], typename); > } > + > + snprintf(typename, sizeof(typename), "aspeed.gpio-%s", socname); > + object_initialize_child(obj, "gpio", &s->gpio, typename); > } > > static void aspeed_soc_ast1030_realize(DeviceState *dev_soc, Error **errp) > @@ -260,6 +263,14 @@ static void aspeed_soc_ast1030_realize(DeviceState *dev_soc, Error **errp) > sysbus_mmio_map(SYS_BUS_DEVICE(&s->wdt[i]), 0, > sc->memmap[ASPEED_DEV_WDT] + i * awc->offset); > } > + > + /* GPIO */ > + if (!sysbus_realize(SYS_BUS_DEVICE(&s->gpio), errp)) { > + return; > + } > + sysbus_mmio_map(SYS_BUS_DEVICE(&s->gpio), 0, sc->memmap[ASPEED_DEV_GPIO]); > + sysbus_connect_irq(SYS_BUS_DEVICE(&s->gpio), 0, > + aspeed_soc_get_irq(s, ASPEED_DEV_GPIO)); > } > > static void aspeed_soc_ast1030_class_init(ObjectClass *klass, void *data) > diff --git a/hw/gpio/aspeed_gpio.c b/hw/gpio/aspeed_gpio.c > index 4620ea8e8b..5138fe812b 100644 > --- a/hw/gpio/aspeed_gpio.c > +++ b/hw/gpio/aspeed_gpio.c > @@ -819,6 +819,15 @@ static GPIOSetProperties ast2600_1_8v_set_props[ASPEED_GPIO_MAX_NR_SETS] = { > [1] = {0x0000000f, 0x0000000f, {"18E"} }, > }; > > +static GPIOSetProperties ast1030_set_props[ASPEED_GPIO_MAX_NR_SETS] = { > + [0] = {0xffffffff, 0xffffffff, {"A", "B", "C", "D"} }, > + [1] = {0xffffffff, 0xffffffff, {"E", "F", "G", "H"} }, > + [2] = {0xffffffff, 0xffffffff, {"I", "J", "K", "L"} }, > + [3] = {0xffffff3f, 0xffffff3f, {"M", "N", "O", "P"} }, > + [4] = {0xff060c1f, 0x00060c1f, {"Q", "R", "S", "T"} }, > + [5] = {0x000000ff, 0x00000000, {"U"} }, > +}; > + > static const MemoryRegionOps aspeed_gpio_ops = { > .read = aspeed_gpio_read, > .write = aspeed_gpio_write, > @@ -971,6 +980,16 @@ static void aspeed_gpio_ast2600_1_8v_class_init(ObjectClass *klass, void *data) > agc->reg_table = aspeed_1_8v_gpios; > } > > +static void aspeed_gpio_1030_class_init(ObjectClass *klass, void *data) > +{ > + AspeedGPIOClass *agc = ASPEED_GPIO_CLASS(klass); > + > + agc->props = ast1030_set_props; > + agc->nr_gpio_pins = 151; > + agc->nr_gpio_sets = 6; > + agc->reg_table = aspeed_3_3v_gpios; > +} > + > static const TypeInfo aspeed_gpio_info = { > .name = TYPE_ASPEED_GPIO, > .parent = TYPE_SYS_BUS_DEVICE, > @@ -1008,6 +1027,13 @@ static const TypeInfo aspeed_gpio_ast2600_1_8v_info = { > .instance_init = aspeed_gpio_init, > }; > > +static const TypeInfo aspeed_gpio_ast1030_info = { > + .name = TYPE_ASPEED_GPIO "-ast1030", > + .parent = TYPE_ASPEED_GPIO, > + .class_init = aspeed_gpio_1030_class_init, > + .instance_init = aspeed_gpio_init, > +}; > + > static void aspeed_gpio_register_types(void) > { > type_register_static(&aspeed_gpio_info); > @@ -1015,6 +1041,7 @@ static void aspeed_gpio_register_types(void) > type_register_static(&aspeed_gpio_ast2500_info); > type_register_static(&aspeed_gpio_ast2600_3_3v_info); > type_register_static(&aspeed_gpio_ast2600_1_8v_info); > + type_register_static(&aspeed_gpio_ast1030_info); > } > > type_init(aspeed_gpio_register_types); ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 3/4] hw/gpio support GPIO index mode for write operation. 2022-05-25 5:34 [PATCH v2 0/4] hw/gpio Add ASPEED GPIO model for AST1030 Jamin Lin 2022-05-25 5:34 ` [PATCH v2 1/4] hw/gpio Add GPIO read/write trace event Jamin Lin 2022-05-25 5:34 ` [PATCH v2 2/4] hw/gpio: Add ASPEED GPIO model for AST1030 Jamin Lin @ 2022-05-25 5:34 ` Jamin Lin 2022-05-25 7:54 ` Cédric Le Goater 2022-05-25 5:34 ` [PATCH v2 4/4] hw/gpio: replace HWADDR_PRIx with PRIx64 Jamin Lin 3 siblings, 1 reply; 8+ messages in thread From: Jamin Lin @ 2022-05-25 5:34 UTC (permalink / raw) To: Cédric Le Goater, Peter Maydell, Andrew Jeffery, Joel Stanley, open list:ASPEED BMCs, open list:All patches CC here Cc: steven_lee, troy_lee, jamin_lin It did not support GPIO index mode for read operation. Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com> --- hw/gpio/aspeed_gpio.c | 168 ++++++++++++++++++++++++++++++++++ include/hw/gpio/aspeed_gpio.h | 14 +++ 2 files changed, 182 insertions(+) diff --git a/hw/gpio/aspeed_gpio.c b/hw/gpio/aspeed_gpio.c index 5138fe812b..c834bf19f5 100644 --- a/hw/gpio/aspeed_gpio.c +++ b/hw/gpio/aspeed_gpio.c @@ -16,6 +16,7 @@ #include "hw/irq.h" #include "migration/vmstate.h" #include "trace.h" +#include "hw/registerfields.h" #define GPIOS_PER_GROUP 8 @@ -204,6 +205,28 @@ #define GPIO_1_8V_MEM_SIZE 0x1D8 #define GPIO_1_8V_REG_ARRAY_SIZE (GPIO_1_8V_MEM_SIZE >> 2) +/* + * GPIO index mode support + * It only supports write operation + */ +REG32(GPIO_INDEX_REG, 0x2AC) + FIELD(GPIO_INDEX_REG, NUMBER, 0, 8) + FIELD(GPIO_INDEX_REG, COMMAND, 12, 1) + FIELD(GPIO_INDEX_REG, TYPE, 16, 4) + FIELD(GPIO_INDEX_REG, DATA_VALUE, 20, 1) + FIELD(GPIO_INDEX_REG, DIRECTION, 20, 1) + FIELD(GPIO_INDEX_REG, INT_ENABLE, 20, 1) + FIELD(GPIO_INDEX_REG, INT_SENS_0, 21, 1) + FIELD(GPIO_INDEX_REG, INT_SENS_1, 22, 1) + FIELD(GPIO_INDEX_REG, INT_SENS_2, 23, 1) + FIELD(GPIO_INDEX_REG, INT_STATUS, 24, 1) + FIELD(GPIO_INDEX_REG, DEBOUNCE_1, 20, 1) + FIELD(GPIO_INDEX_REG, DEBOUNCE_2, 21, 1) + FIELD(GPIO_INDEX_REG, RESET_TOLERANT, 20, 1) + FIELD(GPIO_INDEX_REG, COMMAND_SRC_0, 20, 1) + FIELD(GPIO_INDEX_REG, COMMAND_SRC_1, 21, 1) + FIELD(GPIO_INDEX_REG, INPUT_MASK, 20, 1) + static int aspeed_evaluate_irq(GPIOSets *regs, int gpio_prev_high, int gpio) { uint32_t falling_edge = 0, rising_edge = 0; @@ -596,6 +619,144 @@ static uint64_t aspeed_gpio_read(void *opaque, hwaddr offset, uint32_t size) return value; } +static void aspeed_gpio_write_index_mode(void *opaque, hwaddr offset, + uint64_t data, uint32_t size) +{ + + AspeedGPIOState *s = ASPEED_GPIO(opaque); + AspeedGPIOClass *agc = ASPEED_GPIO_GET_CLASS(s); + const GPIOSetProperties *props; + GPIOSets *set; + uint32_t reg_idx_number = FIELD_EX32(data, GPIO_INDEX_REG, NUMBER); + uint32_t reg_idx_type = FIELD_EX32(data, GPIO_INDEX_REG, TYPE); + uint32_t reg_idx_command = FIELD_EX32(data, GPIO_INDEX_REG, COMMAND); + uint32_t set_idx = reg_idx_number / ASPEED_GPIOS_PER_SET; + uint32_t pin_idx = reg_idx_number % ASPEED_GPIOS_PER_SET; + uint32_t group_idx = pin_idx / GPIOS_PER_GROUP; + uint32_t reg_value = 0; + uint32_t cleared; + + set = &s->sets[set_idx]; + props = &agc->props[set_idx]; + + if (reg_idx_command) + qemu_log_mask(LOG_GUEST_ERROR, "%s: offset 0x%" PRIx64 "data 0x%" + PRIx64 "index mode wrong command 0x%x\n", + __func__, offset, data, reg_idx_command); + + switch (reg_idx_type) { + case gpio_reg_idx_data: + reg_value = set->data_read; + reg_value = deposit32(reg_value, pin_idx, 1, + FIELD_EX32(data, GPIO_INDEX_REG, DATA_VALUE)); + reg_value &= props->output; + reg_value = update_value_control_source(set, set->data_value, + reg_value); + set->data_read = reg_value; + aspeed_gpio_update(s, set, reg_value); + return; + case gpio_reg_idx_direction: + reg_value = set->direction; + reg_value = deposit32(reg_value, pin_idx, 1, + FIELD_EX32(data, GPIO_INDEX_REG, DIRECTION)); + /* + * where data is the value attempted to be written to the pin: + * pin type | input mask | output mask | expected value + * ------------------------------------------------------------ + * bidirectional | 1 | 1 | data + * input only | 1 | 0 | 0 + * output only | 0 | 1 | 1 + * no pin | 0 | 0 | 0 + * + * which is captured by: + * data = ( data | ~input) & output; + */ + reg_value = (reg_value | ~props->input) & props->output; + set->direction = update_value_control_source(set, set->direction, + reg_value); + break; + case gpio_reg_idx_interrupt: + reg_value = set->int_enable; + reg_value = deposit32(reg_value, pin_idx, 1, + FIELD_EX32(data, GPIO_INDEX_REG, INT_ENABLE)); + set->int_enable = update_value_control_source(set, set->int_enable, + reg_value); + reg_value = set->int_sens_0; + reg_value = deposit32(reg_value, pin_idx, 1, + FIELD_EX32(data, GPIO_INDEX_REG, INT_SENS_0)); + set->int_sens_0 = update_value_control_source(set, set->int_sens_0, + reg_value); + reg_value = set->int_sens_1; + reg_value = deposit32(reg_value, pin_idx, 1, + FIELD_EX32(data, GPIO_INDEX_REG, INT_SENS_1)); + set->int_sens_1 = update_value_control_source(set, set->int_sens_1, + reg_value); + reg_value = set->int_sens_2; + reg_value = deposit32(reg_value, pin_idx, 1, + FIELD_EX32(data, GPIO_INDEX_REG, INT_SENS_2)); + set->int_sens_2 = update_value_control_source(set, set->int_sens_2, + reg_value); + /* set interrupt status */ + reg_value = set->int_status; + reg_value = deposit32(reg_value, pin_idx, 1, + FIELD_EX32(data, GPIO_INDEX_REG, INT_STATUS)); + cleared = ctpop32(reg_value & set->int_status); + if (s->pending && cleared) { + assert(s->pending >= cleared); + s->pending -= cleared; + } + set->int_status &= ~reg_value; + break; + case gpio_reg_idx_debounce: + reg_value = set->debounce_1; + reg_value = deposit32(reg_value, pin_idx, 1, + FIELD_EX32(data, GPIO_INDEX_REG, DEBOUNCE_1)); + set->debounce_1 = update_value_control_source(set, set->debounce_1, + reg_value); + reg_value = set->debounce_2; + reg_value = deposit32(reg_value, pin_idx, 1, + FIELD_EX32(data, GPIO_INDEX_REG, DEBOUNCE_2)); + set->debounce_2 = update_value_control_source(set, set->debounce_2, + reg_value); + return; + case gpio_reg_idx_tolerance: + reg_value = set->reset_tol; + reg_value = deposit32(reg_value, pin_idx, 1, + FIELD_EX32(data, GPIO_INDEX_REG, RESET_TOLERANT)); + set->reset_tol = update_value_control_source(set, set->reset_tol, + reg_value); + return; + case gpio_reg_idx_cmd_src: + reg_value = set->cmd_source_0; + reg_value = deposit32(reg_value, GPIOS_PER_GROUP * group_idx, 1, + FIELD_EX32(data, GPIO_INDEX_REG, COMMAND_SRC_0)); + set->cmd_source_0 = reg_value & ASPEED_CMD_SRC_MASK; + reg_value = set->cmd_source_1; + reg_value = deposit32(reg_value, GPIOS_PER_GROUP * group_idx, 1, + FIELD_EX32(data, GPIO_INDEX_REG, COMMAND_SRC_1)); + set->cmd_source_1 = reg_value & ASPEED_CMD_SRC_MASK; + return; + case gpio_reg_idx_input_mask: + reg_value = set->input_mask; + reg_value = deposit32(reg_value, pin_idx, 1, + FIELD_EX32(data, GPIO_INDEX_REG, INPUT_MASK)); + /* + * feeds into interrupt generation + * 0: read from data value reg will be updated + * 1: read from data value reg will not be updated + */ + set->input_mask = reg_value & props->input; + break; + default: + qemu_log_mask(LOG_GUEST_ERROR, "%s: offset 0x%" PRIx64 "data 0x%" + PRIx64 "index mode wrong type 0x%x\n", + __func__, offset, data, reg_idx_type); + return; + } + aspeed_gpio_update(s, set, set->data_value); + return; +} + static void aspeed_gpio_write(void *opaque, hwaddr offset, uint64_t data, uint32_t size) { @@ -610,6 +771,13 @@ static void aspeed_gpio_write(void *opaque, hwaddr offset, uint64_t data, trace_aspeed_gpio_write(offset, data); idx = offset >> 2; + + /* check gpio index mode */ + if (idx == R_GPIO_INDEX_REG) { + aspeed_gpio_write_index_mode(opaque, offset, data, size); + return; + } + if (idx >= GPIO_DEBOUNCE_TIME_1 && idx <= GPIO_DEBOUNCE_TIME_3) { idx -= GPIO_DEBOUNCE_TIME_1; s->debounce_regs[idx] = (uint32_t) data; diff --git a/include/hw/gpio/aspeed_gpio.h b/include/hw/gpio/aspeed_gpio.h index 6dee3cd438..41b36524d0 100644 --- a/include/hw/gpio/aspeed_gpio.h +++ b/include/hw/gpio/aspeed_gpio.h @@ -50,6 +50,20 @@ enum GPIORegType { gpio_reg_input_mask, }; +/* GPIO index mode */ +enum GPIORegIndexType { + gpio_reg_idx_data = 0, + gpio_reg_idx_direction, + gpio_reg_idx_interrupt, + gpio_reg_idx_debounce, + gpio_reg_idx_tolerance, + gpio_reg_idx_cmd_src, + gpio_reg_idx_input_mask, + gpio_reg_idx_reserved, + gpio_reg_idx_new_w_cmd_src, + gpio_reg_idx_new_r_cmd_src, +}; + typedef struct AspeedGPIOReg { uint16_t set_idx; enum GPIORegType type; -- 2.17.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 3/4] hw/gpio support GPIO index mode for write operation. 2022-05-25 5:34 ` [PATCH v2 3/4] hw/gpio support GPIO index mode for write operation Jamin Lin @ 2022-05-25 7:54 ` Cédric Le Goater 0 siblings, 0 replies; 8+ messages in thread From: Cédric Le Goater @ 2022-05-25 7:54 UTC (permalink / raw) To: Jamin Lin, Peter Maydell, Andrew Jeffery, Joel Stanley, open list:ASPEED BMCs, open list:All patches CC here Cc: steven_lee, troy_lee On 5/25/22 07:34, Jamin Lin wrote: > It did not support GPIO index mode for read operation. > > Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com> Reviewed-by: Cédric Le Goater <clg@kaod.org> Thanks, C. > --- > hw/gpio/aspeed_gpio.c | 168 ++++++++++++++++++++++++++++++++++ > include/hw/gpio/aspeed_gpio.h | 14 +++ > 2 files changed, 182 insertions(+) > > diff --git a/hw/gpio/aspeed_gpio.c b/hw/gpio/aspeed_gpio.c > index 5138fe812b..c834bf19f5 100644 > --- a/hw/gpio/aspeed_gpio.c > +++ b/hw/gpio/aspeed_gpio.c > @@ -16,6 +16,7 @@ > #include "hw/irq.h" > #include "migration/vmstate.h" > #include "trace.h" > +#include "hw/registerfields.h" > > #define GPIOS_PER_GROUP 8 > > @@ -204,6 +205,28 @@ > #define GPIO_1_8V_MEM_SIZE 0x1D8 > #define GPIO_1_8V_REG_ARRAY_SIZE (GPIO_1_8V_MEM_SIZE >> 2) > > +/* > + * GPIO index mode support > + * It only supports write operation > + */ > +REG32(GPIO_INDEX_REG, 0x2AC) > + FIELD(GPIO_INDEX_REG, NUMBER, 0, 8) > + FIELD(GPIO_INDEX_REG, COMMAND, 12, 1) > + FIELD(GPIO_INDEX_REG, TYPE, 16, 4) > + FIELD(GPIO_INDEX_REG, DATA_VALUE, 20, 1) > + FIELD(GPIO_INDEX_REG, DIRECTION, 20, 1) > + FIELD(GPIO_INDEX_REG, INT_ENABLE, 20, 1) > + FIELD(GPIO_INDEX_REG, INT_SENS_0, 21, 1) > + FIELD(GPIO_INDEX_REG, INT_SENS_1, 22, 1) > + FIELD(GPIO_INDEX_REG, INT_SENS_2, 23, 1) > + FIELD(GPIO_INDEX_REG, INT_STATUS, 24, 1) > + FIELD(GPIO_INDEX_REG, DEBOUNCE_1, 20, 1) > + FIELD(GPIO_INDEX_REG, DEBOUNCE_2, 21, 1) > + FIELD(GPIO_INDEX_REG, RESET_TOLERANT, 20, 1) > + FIELD(GPIO_INDEX_REG, COMMAND_SRC_0, 20, 1) > + FIELD(GPIO_INDEX_REG, COMMAND_SRC_1, 21, 1) > + FIELD(GPIO_INDEX_REG, INPUT_MASK, 20, 1) > + > static int aspeed_evaluate_irq(GPIOSets *regs, int gpio_prev_high, int gpio) > { > uint32_t falling_edge = 0, rising_edge = 0; > @@ -596,6 +619,144 @@ static uint64_t aspeed_gpio_read(void *opaque, hwaddr offset, uint32_t size) > return value; > } > > +static void aspeed_gpio_write_index_mode(void *opaque, hwaddr offset, > + uint64_t data, uint32_t size) > +{ > + > + AspeedGPIOState *s = ASPEED_GPIO(opaque); > + AspeedGPIOClass *agc = ASPEED_GPIO_GET_CLASS(s); > + const GPIOSetProperties *props; > + GPIOSets *set; > + uint32_t reg_idx_number = FIELD_EX32(data, GPIO_INDEX_REG, NUMBER); > + uint32_t reg_idx_type = FIELD_EX32(data, GPIO_INDEX_REG, TYPE); > + uint32_t reg_idx_command = FIELD_EX32(data, GPIO_INDEX_REG, COMMAND); > + uint32_t set_idx = reg_idx_number / ASPEED_GPIOS_PER_SET; > + uint32_t pin_idx = reg_idx_number % ASPEED_GPIOS_PER_SET; > + uint32_t group_idx = pin_idx / GPIOS_PER_GROUP; > + uint32_t reg_value = 0; > + uint32_t cleared; > + > + set = &s->sets[set_idx]; > + props = &agc->props[set_idx]; > + > + if (reg_idx_command) > + qemu_log_mask(LOG_GUEST_ERROR, "%s: offset 0x%" PRIx64 "data 0x%" > + PRIx64 "index mode wrong command 0x%x\n", > + __func__, offset, data, reg_idx_command); > + > + switch (reg_idx_type) { > + case gpio_reg_idx_data: > + reg_value = set->data_read; > + reg_value = deposit32(reg_value, pin_idx, 1, > + FIELD_EX32(data, GPIO_INDEX_REG, DATA_VALUE)); > + reg_value &= props->output; > + reg_value = update_value_control_source(set, set->data_value, > + reg_value); > + set->data_read = reg_value; > + aspeed_gpio_update(s, set, reg_value); > + return; > + case gpio_reg_idx_direction: > + reg_value = set->direction; > + reg_value = deposit32(reg_value, pin_idx, 1, > + FIELD_EX32(data, GPIO_INDEX_REG, DIRECTION)); > + /* > + * where data is the value attempted to be written to the pin: > + * pin type | input mask | output mask | expected value > + * ------------------------------------------------------------ > + * bidirectional | 1 | 1 | data > + * input only | 1 | 0 | 0 > + * output only | 0 | 1 | 1 > + * no pin | 0 | 0 | 0 > + * > + * which is captured by: > + * data = ( data | ~input) & output; > + */ > + reg_value = (reg_value | ~props->input) & props->output; > + set->direction = update_value_control_source(set, set->direction, > + reg_value); > + break; > + case gpio_reg_idx_interrupt: > + reg_value = set->int_enable; > + reg_value = deposit32(reg_value, pin_idx, 1, > + FIELD_EX32(data, GPIO_INDEX_REG, INT_ENABLE)); > + set->int_enable = update_value_control_source(set, set->int_enable, > + reg_value); > + reg_value = set->int_sens_0; > + reg_value = deposit32(reg_value, pin_idx, 1, > + FIELD_EX32(data, GPIO_INDEX_REG, INT_SENS_0)); > + set->int_sens_0 = update_value_control_source(set, set->int_sens_0, > + reg_value); > + reg_value = set->int_sens_1; > + reg_value = deposit32(reg_value, pin_idx, 1, > + FIELD_EX32(data, GPIO_INDEX_REG, INT_SENS_1)); > + set->int_sens_1 = update_value_control_source(set, set->int_sens_1, > + reg_value); > + reg_value = set->int_sens_2; > + reg_value = deposit32(reg_value, pin_idx, 1, > + FIELD_EX32(data, GPIO_INDEX_REG, INT_SENS_2)); > + set->int_sens_2 = update_value_control_source(set, set->int_sens_2, > + reg_value); > + /* set interrupt status */ > + reg_value = set->int_status; > + reg_value = deposit32(reg_value, pin_idx, 1, > + FIELD_EX32(data, GPIO_INDEX_REG, INT_STATUS)); > + cleared = ctpop32(reg_value & set->int_status); > + if (s->pending && cleared) { > + assert(s->pending >= cleared); > + s->pending -= cleared; > + } > + set->int_status &= ~reg_value; > + break; > + case gpio_reg_idx_debounce: > + reg_value = set->debounce_1; > + reg_value = deposit32(reg_value, pin_idx, 1, > + FIELD_EX32(data, GPIO_INDEX_REG, DEBOUNCE_1)); > + set->debounce_1 = update_value_control_source(set, set->debounce_1, > + reg_value); > + reg_value = set->debounce_2; > + reg_value = deposit32(reg_value, pin_idx, 1, > + FIELD_EX32(data, GPIO_INDEX_REG, DEBOUNCE_2)); > + set->debounce_2 = update_value_control_source(set, set->debounce_2, > + reg_value); > + return; > + case gpio_reg_idx_tolerance: > + reg_value = set->reset_tol; > + reg_value = deposit32(reg_value, pin_idx, 1, > + FIELD_EX32(data, GPIO_INDEX_REG, RESET_TOLERANT)); > + set->reset_tol = update_value_control_source(set, set->reset_tol, > + reg_value); > + return; > + case gpio_reg_idx_cmd_src: > + reg_value = set->cmd_source_0; > + reg_value = deposit32(reg_value, GPIOS_PER_GROUP * group_idx, 1, > + FIELD_EX32(data, GPIO_INDEX_REG, COMMAND_SRC_0)); > + set->cmd_source_0 = reg_value & ASPEED_CMD_SRC_MASK; > + reg_value = set->cmd_source_1; > + reg_value = deposit32(reg_value, GPIOS_PER_GROUP * group_idx, 1, > + FIELD_EX32(data, GPIO_INDEX_REG, COMMAND_SRC_1)); > + set->cmd_source_1 = reg_value & ASPEED_CMD_SRC_MASK; > + return; > + case gpio_reg_idx_input_mask: > + reg_value = set->input_mask; > + reg_value = deposit32(reg_value, pin_idx, 1, > + FIELD_EX32(data, GPIO_INDEX_REG, INPUT_MASK)); > + /* > + * feeds into interrupt generation > + * 0: read from data value reg will be updated > + * 1: read from data value reg will not be updated > + */ > + set->input_mask = reg_value & props->input; > + break; > + default: > + qemu_log_mask(LOG_GUEST_ERROR, "%s: offset 0x%" PRIx64 "data 0x%" > + PRIx64 "index mode wrong type 0x%x\n", > + __func__, offset, data, reg_idx_type); > + return; > + } > + aspeed_gpio_update(s, set, set->data_value); > + return; > +} > + > static void aspeed_gpio_write(void *opaque, hwaddr offset, uint64_t data, > uint32_t size) > { > @@ -610,6 +771,13 @@ static void aspeed_gpio_write(void *opaque, hwaddr offset, uint64_t data, > trace_aspeed_gpio_write(offset, data); > > idx = offset >> 2; > + > + /* check gpio index mode */ > + if (idx == R_GPIO_INDEX_REG) { > + aspeed_gpio_write_index_mode(opaque, offset, data, size); > + return; > + } > + > if (idx >= GPIO_DEBOUNCE_TIME_1 && idx <= GPIO_DEBOUNCE_TIME_3) { > idx -= GPIO_DEBOUNCE_TIME_1; > s->debounce_regs[idx] = (uint32_t) data; > diff --git a/include/hw/gpio/aspeed_gpio.h b/include/hw/gpio/aspeed_gpio.h > index 6dee3cd438..41b36524d0 100644 > --- a/include/hw/gpio/aspeed_gpio.h > +++ b/include/hw/gpio/aspeed_gpio.h > @@ -50,6 +50,20 @@ enum GPIORegType { > gpio_reg_input_mask, > }; > > +/* GPIO index mode */ > +enum GPIORegIndexType { > + gpio_reg_idx_data = 0, > + gpio_reg_idx_direction, > + gpio_reg_idx_interrupt, > + gpio_reg_idx_debounce, > + gpio_reg_idx_tolerance, > + gpio_reg_idx_cmd_src, > + gpio_reg_idx_input_mask, > + gpio_reg_idx_reserved, > + gpio_reg_idx_new_w_cmd_src, > + gpio_reg_idx_new_r_cmd_src, > +}; > + > typedef struct AspeedGPIOReg { > uint16_t set_idx; > enum GPIORegType type; ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 4/4] hw/gpio: replace HWADDR_PRIx with PRIx64 2022-05-25 5:34 [PATCH v2 0/4] hw/gpio Add ASPEED GPIO model for AST1030 Jamin Lin ` (2 preceding siblings ...) 2022-05-25 5:34 ` [PATCH v2 3/4] hw/gpio support GPIO index mode for write operation Jamin Lin @ 2022-05-25 5:34 ` Jamin Lin 2022-05-25 6:26 ` Cédric Le Goater 3 siblings, 1 reply; 8+ messages in thread From: Jamin Lin @ 2022-05-25 5:34 UTC (permalink / raw) To: Cédric Le Goater, Peter Maydell, Andrew Jeffery, Joel Stanley, open list:ASPEED BMCs, open list:All patches CC here Cc: steven_lee, troy_lee, jamin_lin 1. replace HWADDR_PRIx with PRIx64 2. fix indent issue Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com> --- hw/gpio/aspeed_gpio.c | 8 ++++---- include/hw/gpio/aspeed_gpio.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/gpio/aspeed_gpio.c b/hw/gpio/aspeed_gpio.c index c834bf19f5..a62a673857 100644 --- a/hw/gpio/aspeed_gpio.c +++ b/hw/gpio/aspeed_gpio.c @@ -561,7 +561,7 @@ static uint64_t aspeed_gpio_read(void *opaque, hwaddr offset, uint32_t size) reg = &agc->reg_table[idx]; if (reg->set_idx >= agc->nr_gpio_sets) { qemu_log_mask(LOG_GUEST_ERROR, "%s: no getter for offset 0x%" - HWADDR_PRIx"\n", __func__, offset); + PRIx64"\n", __func__, offset); return 0; } @@ -611,7 +611,7 @@ static uint64_t aspeed_gpio_read(void *opaque, hwaddr offset, uint32_t size) break; default: qemu_log_mask(LOG_GUEST_ERROR, "%s: no getter for offset 0x%" - HWADDR_PRIx"\n", __func__, offset); + PRIx64"\n", __func__, offset); return 0; } @@ -787,7 +787,7 @@ static void aspeed_gpio_write(void *opaque, hwaddr offset, uint64_t data, reg = &agc->reg_table[idx]; if (reg->set_idx >= agc->nr_gpio_sets) { qemu_log_mask(LOG_GUEST_ERROR, "%s: no setter for offset 0x%" - HWADDR_PRIx"\n", __func__, offset); + PRIx64"\n", __func__, offset); return; } @@ -872,7 +872,7 @@ static void aspeed_gpio_write(void *opaque, hwaddr offset, uint64_t data, break; default: qemu_log_mask(LOG_GUEST_ERROR, "%s: no setter for offset 0x%" - HWADDR_PRIx"\n", __func__, offset); + PRIx64"\n", __func__, offset); return; } aspeed_gpio_update(s, set, set->data_value); diff --git a/include/hw/gpio/aspeed_gpio.h b/include/hw/gpio/aspeed_gpio.h index 41b36524d0..904eecf62c 100644 --- a/include/hw/gpio/aspeed_gpio.h +++ b/include/hw/gpio/aspeed_gpio.h @@ -67,7 +67,7 @@ enum GPIORegIndexType { typedef struct AspeedGPIOReg { uint16_t set_idx; enum GPIORegType type; - } AspeedGPIOReg; +} AspeedGPIOReg; struct AspeedGPIOClass { SysBusDevice parent_obj; -- 2.17.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 4/4] hw/gpio: replace HWADDR_PRIx with PRIx64 2022-05-25 5:34 ` [PATCH v2 4/4] hw/gpio: replace HWADDR_PRIx with PRIx64 Jamin Lin @ 2022-05-25 6:26 ` Cédric Le Goater 0 siblings, 0 replies; 8+ messages in thread From: Cédric Le Goater @ 2022-05-25 6:26 UTC (permalink / raw) To: Jamin Lin, Peter Maydell, Andrew Jeffery, Joel Stanley, open list:ASPEED BMCs, open list:All patches CC here Cc: steven_lee, troy_lee On 5/25/22 07:34, Jamin Lin wrote: > 1. replace HWADDR_PRIx with PRIx64 > 2. fix indent issue > > Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com> Reviewed-by: Cédric Le Goater <clg@kaod.org> Thanks, C. > --- > hw/gpio/aspeed_gpio.c | 8 ++++---- > include/hw/gpio/aspeed_gpio.h | 2 +- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/hw/gpio/aspeed_gpio.c b/hw/gpio/aspeed_gpio.c > index c834bf19f5..a62a673857 100644 > --- a/hw/gpio/aspeed_gpio.c > +++ b/hw/gpio/aspeed_gpio.c > @@ -561,7 +561,7 @@ static uint64_t aspeed_gpio_read(void *opaque, hwaddr offset, uint32_t size) > reg = &agc->reg_table[idx]; > if (reg->set_idx >= agc->nr_gpio_sets) { > qemu_log_mask(LOG_GUEST_ERROR, "%s: no getter for offset 0x%" > - HWADDR_PRIx"\n", __func__, offset); > + PRIx64"\n", __func__, offset); > return 0; > } > > @@ -611,7 +611,7 @@ static uint64_t aspeed_gpio_read(void *opaque, hwaddr offset, uint32_t size) > break; > default: > qemu_log_mask(LOG_GUEST_ERROR, "%s: no getter for offset 0x%" > - HWADDR_PRIx"\n", __func__, offset); > + PRIx64"\n", __func__, offset); > return 0; > } > > @@ -787,7 +787,7 @@ static void aspeed_gpio_write(void *opaque, hwaddr offset, uint64_t data, > reg = &agc->reg_table[idx]; > if (reg->set_idx >= agc->nr_gpio_sets) { > qemu_log_mask(LOG_GUEST_ERROR, "%s: no setter for offset 0x%" > - HWADDR_PRIx"\n", __func__, offset); > + PRIx64"\n", __func__, offset); > return; > } > > @@ -872,7 +872,7 @@ static void aspeed_gpio_write(void *opaque, hwaddr offset, uint64_t data, > break; > default: > qemu_log_mask(LOG_GUEST_ERROR, "%s: no setter for offset 0x%" > - HWADDR_PRIx"\n", __func__, offset); > + PRIx64"\n", __func__, offset); > return; > } > aspeed_gpio_update(s, set, set->data_value); > diff --git a/include/hw/gpio/aspeed_gpio.h b/include/hw/gpio/aspeed_gpio.h > index 41b36524d0..904eecf62c 100644 > --- a/include/hw/gpio/aspeed_gpio.h > +++ b/include/hw/gpio/aspeed_gpio.h > @@ -67,7 +67,7 @@ enum GPIORegIndexType { > typedef struct AspeedGPIOReg { > uint16_t set_idx; > enum GPIORegType type; > - } AspeedGPIOReg; > +} AspeedGPIOReg; > > struct AspeedGPIOClass { > SysBusDevice parent_obj; ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-05-25 7:58 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-05-25 5:34 [PATCH v2 0/4] hw/gpio Add ASPEED GPIO model for AST1030 Jamin Lin 2022-05-25 5:34 ` [PATCH v2 1/4] hw/gpio Add GPIO read/write trace event Jamin Lin 2022-05-25 5:34 ` [PATCH v2 2/4] hw/gpio: Add ASPEED GPIO model for AST1030 Jamin Lin 2022-05-25 6:26 ` Cédric Le Goater 2022-05-25 5:34 ` [PATCH v2 3/4] hw/gpio support GPIO index mode for write operation Jamin Lin 2022-05-25 7:54 ` Cédric Le Goater 2022-05-25 5:34 ` [PATCH v2 4/4] hw/gpio: replace HWADDR_PRIx with PRIx64 Jamin Lin 2022-05-25 6:26 ` Cédric Le Goater
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).