qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: Ilya Leoshkevich <iii@linux.ibm.com>,
	Ulrich Weigand <ulrich.weigand@de.ibm.com>,
	David Hildenbrand <david@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	Laurent Vivier <laurent@vivier.eu>
Subject: [PULL 6/8] linux-user/s390x: Fix unwinding from signal handlers
Date: Wed, 25 May 2022 12:40:55 +0200	[thread overview]
Message-ID: <20220525104057.543354-7-laurent@vivier.eu> (raw)
In-Reply-To: <20220525104057.543354-1-laurent@vivier.eu>

From: Ilya Leoshkevich <iii@linux.ibm.com>

Commit 31330e6cecfd ("linux-user/s390x: Implement setup_sigtramp")
removed an unused field from rt_sigframe, disturbing offsets of other
fields and breaking unwinding from signal handlers (e.g. libgcc's
s390_fallback_frame() relies on this struct having a specific layout).
Restore the field and add a comment.

Reported-by: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Fixes: 31330e6cecfd ("linux-user/s390x: Implement setup_sigtramp")
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220503225157.1696774-2-iii@linux.ibm.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 linux-user/s390x/signal.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/linux-user/s390x/signal.c b/linux-user/s390x/signal.c
index f47713e04a07..4979c4b01791 100644
--- a/linux-user/s390x/signal.c
+++ b/linux-user/s390x/signal.c
@@ -84,6 +84,11 @@ struct target_ucontext {
 
 typedef struct {
     uint8_t callee_used_stack[__SIGNAL_FRAMESIZE];
+    /*
+     * This field is no longer initialized by the kernel, but it's still a part
+     * of the ABI.
+     */
+    uint16_t svc_insn;
     struct target_siginfo info;
     struct target_ucontext uc;
 } rt_sigframe;
-- 
2.36.1



  parent reply	other threads:[~2022-05-25 10:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-25 10:40 [PULL 0/8] Linux user for 7.1 patches Laurent Vivier
2022-05-25 10:40 ` [PULL 1/8] linux-user: Clean up arg_start/arg_end confusion Laurent Vivier
2022-05-25 10:40 ` [PULL 2/8] linux-user/syscall.c: fix build without RLIMIT_RTTIME Laurent Vivier
2022-05-25 10:40 ` [PULL 3/8] linux-user/elfload: Remove pointless non-const CPUArchState cast Laurent Vivier
2022-05-25 10:40 ` [PULL 4/8] linux-user: Have do_syscall() use CPUArchState* instead of void* Laurent Vivier
2022-05-25 10:40 ` [PULL 5/8] linux-user: Remove pointless CPU{ARCH}State casts Laurent Vivier
2022-05-25 10:40 ` Laurent Vivier [this message]
2022-05-25 10:40 ` [PULL 7/8] tests/tcg/s390x: Test unwinding from signal handlers Laurent Vivier
2022-05-25 10:40 ` [PULL 8/8] linux-user/host/s390: Treat EX and EXRL as writes Laurent Vivier
2022-05-25 18:16 ` [PULL 0/8] Linux user for 7.1 patches Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220525104057.543354-7-laurent@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=david@redhat.com \
    --cc=iii@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=ulrich.weigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).