qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Bernhard Beschow <shentey@gmail.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, "Bernhard Beschow" <shentey@gmail.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Hervé Poussineau" <hpoussin@reactos.org>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Aurelien Jarno" <aurelien@aurel32.net>
Subject: [PATCH v3 2/7] hw/isa/piix4: Use object_initialize_child() for embedded struct
Date: Sat, 28 May 2022 21:20:51 +0200	[thread overview]
Message-ID: <20220528192057.30910-3-shentey@gmail.com> (raw)
In-Reply-To: <20220528192057.30910-1-shentey@gmail.com>

Found-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
 hw/isa/piix4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c
index 9a6d981037..1d04fb6a55 100644
--- a/hw/isa/piix4.c
+++ b/hw/isa/piix4.c
@@ -224,7 +224,7 @@ static void piix4_init(Object *obj)
 {
     PIIX4State *s = PIIX4_PCI_DEVICE(obj);
 
-    object_initialize(&s->rtc, sizeof(s->rtc), TYPE_MC146818_RTC);
+    object_initialize_child(obj, "rtc", &s->rtc, TYPE_MC146818_RTC);
 }
 
 static void piix4_class_init(ObjectClass *klass, void *data)
-- 
2.36.1



  parent reply	other threads:[~2022-05-28 19:24 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-28 19:20 [PATCH v3 0/7] QOM'ify PIIX southbridge creation Bernhard Beschow
2022-05-28 19:20 ` [PATCH v3 1/7] include/hw/southbridge/piix: Aggregate all PIIX soughbridge type names Bernhard Beschow
2022-05-29  9:05   ` Mark Cave-Ayland
2022-05-29 18:09     ` Bernhard Beschow
2022-05-30 13:19       ` Philippe Mathieu-Daudé via
2022-06-01 21:34         ` Bernhard Beschow
2022-05-28 19:20 ` Bernhard Beschow [this message]
2022-05-30 11:38   ` [PATCH v3 2/7] hw/isa/piix4: Use object_initialize_child() for embedded struct Philippe Mathieu-Daudé via
2022-06-01 21:36     ` Bernhard Beschow
2022-05-28 19:20 ` [PATCH v3 3/7] hw/isa/piix{3, 4}: Move pci_map_irq_fn's near pci_set_irq_fn's Bernhard Beschow
2022-05-28 19:20 ` [PATCH v3 4/7] hw/isa/piix{3, 4}: QOM'ify PCI device creation and wiring Bernhard Beschow
2022-05-30 13:17   ` Philippe Mathieu-Daudé via
2022-05-30 21:00     ` [PATCH v3 4/7] hw/isa/piix{3,4}: " Bernhard Beschow
2022-05-28 19:20 ` [PATCH v3 5/7] hw/isa/piix{3, 4}: Factor out ISABus retrieval from create() functions Bernhard Beschow
2022-05-28 19:20 ` [PATCH v3 6/7] hw/isa/piix4: QOM'ify PIIX4 PM creation Bernhard Beschow
2022-05-29  9:25   ` Mark Cave-Ayland
2022-05-29 18:05     ` Bernhard Beschow
2022-05-30 19:58       ` Mark Cave-Ayland
2022-06-01 21:39         ` Bernhard Beschow
2022-05-28 19:20 ` [PATCH v3 7/7] hw/isa/piix{3, 4}: Inline and remove create() functions Bernhard Beschow
2022-05-29  9:46 ` [PATCH v3 0/7] QOM'ify PIIX southbridge creation Mark Cave-Ayland
2022-05-29 10:06   ` Mark Cave-Ayland
2022-05-29 13:02     ` Bernhard Beschow
2022-05-30 19:11       ` Mark Cave-Ayland
2022-05-30 19:45         ` Philippe Mathieu-Daudé via
2022-06-04  8:36           ` Bernhard Beschow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220528192057.30910-3-shentey@gmail.com \
    --to=shentey@gmail.com \
    --cc=aurelien@aurel32.net \
    --cc=f4bug@amsat.org \
    --cc=hpoussin@reactos.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).