From: Julia Suvorova <jusual@redhat.com>
To: qemu-devel@nongnu.org
Cc: Xiao Guangrong <xiaoguangrong.eric@gmail.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Julia Suvorova <jusual@redhat.com>
Subject: [PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag
Date: Tue, 31 May 2022 16:51:47 +0200 [thread overview]
Message-ID: <20220531145147.61112-1-jusual@redhat.com> (raw)
In the ACPI specification [1], the 'unarmed' bit is set when a device
cannot accept a persistent write. This means that when a memdev is
read-only, the 'unarmed' flag must be turned on. The logic is correct,
just changing the error message.
[1] ACPI NFIT NVDIMM Region Mapping Structure "NVDIMM State Flags" Bit 3
Signed-off-by: Julia Suvorova <jusual@redhat.com>
---
hw/mem/nvdimm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c
index 7c7d777781..bfb76818c1 100644
--- a/hw/mem/nvdimm.c
+++ b/hw/mem/nvdimm.c
@@ -149,7 +149,7 @@ static void nvdimm_prepare_memory_region(NVDIMMDevice *nvdimm, Error **errp)
if (!nvdimm->unarmed && memory_region_is_rom(mr)) {
HostMemoryBackend *hostmem = dimm->hostmem;
- error_setg(errp, "'unarmed' property must be off since memdev %s "
+ error_setg(errp, "'unarmed' property must be on since memdev %s "
"is read-only",
object_get_canonical_path_component(OBJECT(hostmem)));
return;
--
2.35.1
next reply other threads:[~2022-05-31 14:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 14:51 Julia Suvorova [this message]
2022-05-31 15:32 ` [PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag Stefan Hajnoczi
2022-06-13 15:01 ` Julia Suvorova
2022-06-13 15:09 ` Stefan Hajnoczi
2022-06-14 8:54 ` Igor Mammedov
2022-06-14 9:50 ` David Hildenbrand
2022-06-14 12:13 ` Julia Suvorova
2022-06-15 8:24 ` David Hildenbrand
2022-06-15 11:17 ` Xiao Guangrong
2022-06-15 11:49 ` David Hildenbrand
2022-06-17 12:03 ` Xiao Guangrong
2022-06-14 14:08 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220531145147.61112-1-jusual@redhat.com \
--to=jusual@redhat.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=xiaoguangrong.eric@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).