From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: laurent@vivier.eu, "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [PATCH v6 15/17] linux-user/strace: Use is_error in print_syscall_err
Date: Wed, 1 Jun 2022 18:33:59 -0700 [thread overview]
Message-ID: <20220602013401.303699-16-richard.henderson@linaro.org> (raw)
In-Reply-To: <20220602013401.303699-1-richard.henderson@linaro.org>
Errors are not all negative numbers: use is_error.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/strace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/strace.c b/linux-user/strace.c
index 9fa681dea9..7d882526da 100644
--- a/linux-user/strace.c
+++ b/linux-user/strace.c
@@ -689,7 +689,7 @@ print_syscall_err(abi_long ret)
const char *errstr;
qemu_log(" = ");
- if (ret < 0) {
+ if (is_error(ret)) {
errstr = target_strerror(-ret);
if (errstr) {
qemu_log("-1 errno=%d (%s)", (int)-ret, errstr);
--
2.34.1
next prev parent reply other threads:[~2022-06-02 1:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 1:33 [PATCH v6 00/17] target/m68k: Conditional traps + trap cleanup Richard Henderson
2022-06-02 1:33 ` [PATCH v6 01/17] target/m68k: Raise the TRAPn exception with the correct pc Richard Henderson
2022-06-02 1:33 ` [PATCH v6 02/17] target/m68k: Switch over exception type in m68k_interrupt_all Richard Henderson
2022-06-02 1:33 ` [PATCH v6 03/17] target/m68k: Fix coding style " Richard Henderson
2022-06-02 1:33 ` [PATCH v6 04/17] linux-user/m68k: Handle EXCP_TRAP1 through EXCP_TRAP15 Richard Henderson
2022-06-02 1:33 ` [PATCH v6 05/17] target/m68k: Remove retaddr in m68k_interrupt_all Richard Henderson
2022-06-02 1:33 ` [PATCH v6 06/17] target/m68k: Fix address argument for EXCP_CHK Richard Henderson
2022-06-02 1:33 ` [PATCH v6 07/17] target/m68k: Fix pc, c flag, and address argument for EXCP_DIV0 Richard Henderson
2022-06-02 1:33 ` [PATCH v6 08/17] target/m68k: Fix address argument for EXCP_TRACE Richard Henderson
2022-06-02 1:33 ` [PATCH v6 09/17] target/m68k: Fix stack frame for EXCP_ILLEGAL Richard Henderson
2022-06-02 1:33 ` [PATCH v6 10/17] target/m68k: Implement TRAPcc Richard Henderson
2022-06-02 1:33 ` [PATCH v6 11/17] target/m68k: Implement TPF in terms of TRAPcc Richard Henderson
2022-06-02 1:33 ` [PATCH v6 12/17] target/m68k: Implement TRAPV Richard Henderson
2022-06-02 1:33 ` [PATCH v6 13/17] target/m68k: Implement FTRAPcc Richard Henderson
2022-06-02 1:33 ` [PATCH v6 14/17] tests/tcg/m68k: Add trap.c Richard Henderson
2022-06-02 1:33 ` Richard Henderson [this message]
2022-06-02 1:34 ` [PATCH v6 16/17] linux-user/strace: Adjust get_thread_area for m68k Richard Henderson
2022-06-02 1:34 ` [PATCH v6 17/17] target/m68k: Mark helper_raise_exception as noreturn Richard Henderson
2022-06-02 7:35 ` [PATCH v6 00/17] target/m68k: Conditional traps + trap cleanup Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220602013401.303699-16-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=f4bug@amsat.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).