qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: "Laurent Vivier" <laurent@vivier.eu>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [PULL 13/19] target/m68k: Implement TPF in terms of TRAPcc
Date: Thu,  2 Jun 2022 13:58:31 +0200	[thread overview]
Message-ID: <20220602115837.2013918-14-laurent@vivier.eu> (raw)
In-Reply-To: <20220602115837.2013918-1-laurent@vivier.eu>

From: Richard Henderson <richard.henderson@linaro.org>

TPF stands for "trap false", and is a long-form nop for ColdFire.
Re-use the immediate consumption code from trapcc; the insn will
already expand to a nop because of the TCG_COND_NEVER test
within do_trapcc.

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220602013401.303699-12-richard.henderson@linaro.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 target/m68k/translate.c | 19 ++-----------------
 1 file changed, 2 insertions(+), 17 deletions(-)

diff --git a/target/m68k/translate.c b/target/m68k/translate.c
index e9aa96d7684b..8b2157c31f54 100644
--- a/target/m68k/translate.c
+++ b/target/m68k/translate.c
@@ -3075,22 +3075,6 @@ DISAS_INSN(addsubq)
     tcg_temp_free(dest);
 }
 
-DISAS_INSN(tpf)
-{
-    switch (insn & 7) {
-    case 2: /* One extension word.  */
-        s->pc += 2;
-        break;
-    case 3: /* Two extension words.  */
-        s->pc += 4;
-        break;
-    case 4: /* No extension words.  */
-        break;
-    default:
-        disas_undef(env, s, insn);
-    }
-}
-
 DISAS_INSN(branch)
 {
     int32_t offset;
@@ -6100,7 +6084,8 @@ void register_m68k_insns (CPUM68KState *env)
     INSN(dbcc,      50c8, f0f8, M68000);
     INSN(trapcc,    50fa, f0fe, TRAPCC);   /* opmode 010, 011 */
     INSN(trapcc,    50fc, f0ff, TRAPCC);   /* opmode 100 */
-    INSN(tpf,       51f8, fff8, CF_ISA_A);
+    INSN(trapcc,    51fa, fffe, CF_ISA_A); /* TPF (trapf) opmode 010, 011 */
+    INSN(trapcc,    51fc, ffff, CF_ISA_A); /* TPF (trapf) opmode 100 */
 
     /* Branch instructions.  */
     BASE(branch,    6000, f000);
-- 
2.36.1



  parent reply	other threads:[~2022-06-02 12:27 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-02 11:58 [PULL 00/19] M68k for 7.1 patches Laurent Vivier
2022-06-02 11:58 ` [PULL 01/19] target/m68k: Clear mach in m68k_cpu_disas_set_info Laurent Vivier
2022-06-02 11:58 ` [PULL 02/19] target/m68k: Enable halt insn for 68060 Laurent Vivier
2022-06-02 11:58 ` [PULL 03/19] target/m68k: Raise the TRAPn exception with the correct pc Laurent Vivier
2022-06-02 11:58 ` [PULL 04/19] target/m68k: Switch over exception type in m68k_interrupt_all Laurent Vivier
2022-06-02 11:58 ` [PULL 05/19] target/m68k: Fix coding style " Laurent Vivier
2022-06-02 11:58 ` [PULL 06/19] linux-user/m68k: Handle EXCP_TRAP1 through EXCP_TRAP15 Laurent Vivier
2022-06-02 11:58 ` [PULL 07/19] target/m68k: Remove retaddr in m68k_interrupt_all Laurent Vivier
2022-06-02 11:58 ` [PULL 08/19] target/m68k: Fix address argument for EXCP_CHK Laurent Vivier
2022-06-02 11:58 ` [PULL 09/19] target/m68k: Fix pc, c flag, and address argument for EXCP_DIV0 Laurent Vivier
2022-06-02 11:58 ` [PULL 10/19] target/m68k: Fix address argument for EXCP_TRACE Laurent Vivier
2022-06-02 11:58 ` [PULL 11/19] target/m68k: Fix stack frame for EXCP_ILLEGAL Laurent Vivier
2022-06-02 11:58 ` [PULL 12/19] target/m68k: Implement TRAPcc Laurent Vivier
2022-06-02 11:58 ` Laurent Vivier [this message]
2022-06-02 11:58 ` [PULL 14/19] target/m68k: Implement TRAPV Laurent Vivier
2022-06-02 11:58 ` [PULL 15/19] target/m68k: Implement FTRAPcc Laurent Vivier
2022-06-02 11:58 ` [PULL 16/19] tests/tcg/m68k: Add trap.c Laurent Vivier
2022-06-02 11:58 ` [PULL 17/19] linux-user/strace: Use is_error in print_syscall_err Laurent Vivier
2022-06-02 11:58 ` [PULL 18/19] linux-user/strace: Adjust get_thread_area for m68k Laurent Vivier
2022-06-02 11:58 ` [PULL 19/19] target/m68k: Mark helper_raise_exception as noreturn Laurent Vivier
2022-06-02 15:00 ` [PULL 00/19] M68k for 7.1 patches Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220602115837.2013918-14-laurent@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=f4bug@amsat.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).