qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org
Subject: [PATCH 43/71] target/arm: Implement SME RDSVL, ADDSVL, ADDSPL
Date: Thu,  2 Jun 2022 14:48:25 -0700	[thread overview]
Message-ID: <20220602214853.496211-44-richard.henderson@linaro.org> (raw)
In-Reply-To: <20220602214853.496211-1-richard.henderson@linaro.org>

These SME instructions are nominally within the SVE decode space,
so we add them to sve.decode and translate-sve.c.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/arm/translate-a64.h |  1 +
 target/arm/sve.decode      |  5 ++++-
 target/arm/translate-a64.c | 15 +++++++++++++++
 target/arm/translate-sve.c | 38 ++++++++++++++++++++++++++++++++++++++
 4 files changed, 58 insertions(+), 1 deletion(-)

diff --git a/target/arm/translate-a64.h b/target/arm/translate-a64.h
index 789b6e8e78..6bd1b2eb4b 100644
--- a/target/arm/translate-a64.h
+++ b/target/arm/translate-a64.h
@@ -29,6 +29,7 @@ void write_fp_dreg(DisasContext *s, int reg, TCGv_i64 v);
 bool logic_imm_decode_wmask(uint64_t *result, unsigned int immn,
                             unsigned int imms, unsigned int immr);
 bool sve_access_check(DisasContext *s);
+bool sme_enabled_check(DisasContext *s);
 TCGv_i64 clean_data_tbi(DisasContext *s, TCGv_i64 addr);
 TCGv_i64 gen_mte_check1(DisasContext *s, TCGv_i64 addr, bool is_write,
                         bool tag_checked, int log2_size);
diff --git a/target/arm/sve.decode b/target/arm/sve.decode
index a54feb2f61..bbdaac6ac7 100644
--- a/target/arm/sve.decode
+++ b/target/arm/sve.decode
@@ -449,14 +449,17 @@ INDEX_ri        00000100 esz:2 1 imm:s5 010001 rn:5 rd:5
 # SVE index generation (register start, register increment)
 INDEX_rr        00000100 .. 1 ..... 010011 ..... .....          @rd_rn_rm
 
-### SVE Stack Allocation Group
+### SVE / Streaming SVE Stack Allocation Group
 
 # SVE stack frame adjustment
 ADDVL           00000100 001 ..... 01010 ...... .....           @rd_rn_i6
+ADDSVL          00000100 001 ..... 01011 ...... .....           @rd_rn_i6
 ADDPL           00000100 011 ..... 01010 ...... .....           @rd_rn_i6
+ADDSPL          00000100 011 ..... 01011 ...... .....           @rd_rn_i6
 
 # SVE stack frame size
 RDVL            00000100 101 11111 01010 imm:s6 rd:5
+RDSVL           00000100 101 11111 01011 imm:s6 rd:5
 
 ### SVE Bitwise Shift - Unpredicated Group
 
diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
index 029c0a917c..222f93d42d 100644
--- a/target/arm/translate-a64.c
+++ b/target/arm/translate-a64.c
@@ -1216,6 +1216,21 @@ static bool sme_access_check(DisasContext *s)
     return true;
 }
 
+/* Note that this function corresponds to CheckSMEEnabled. */
+bool sme_enabled_check(DisasContext *s)
+{
+    /*
+     * Note that unlike sve_excp_el, we have not constrained sme_excp_el
+     * to be zero when fp_excp_el has priority.  This is because we need
+     * sme_excp_el by itself for cpregs access checks.
+     */
+    if (!s->fp_excp_el || s->sme_excp_el < s->fp_excp_el) {
+        s->fp_access_checked = true;
+        return sme_access_check(s);
+    }
+    return fp_access_check_only(s);
+}
+
 /*
  * This utility function is for doing register extension with an
  * optional shift. You will likely want to pass a temporary for the
diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c
index 62b5f3040c..13bdd027a5 100644
--- a/target/arm/translate-sve.c
+++ b/target/arm/translate-sve.c
@@ -1286,6 +1286,19 @@ static bool trans_ADDVL(DisasContext *s, arg_ADDVL *a)
     return true;
 }
 
+static bool trans_ADDSVL(DisasContext *s, arg_ADDSVL *a)
+{
+    if (!dc_isar_feature(aa64_sme, s)) {
+        return false;
+    }
+    if (sme_enabled_check(s)) {
+        TCGv_i64 rd = cpu_reg_sp(s, a->rd);
+        TCGv_i64 rn = cpu_reg_sp(s, a->rn);
+        tcg_gen_addi_i64(rd, rn, a->imm * s->svl);
+    }
+    return true;
+}
+
 static bool trans_ADDPL(DisasContext *s, arg_ADDPL *a)
 {
     if (!dc_isar_feature(aa64_sve, s)) {
@@ -1299,6 +1312,19 @@ static bool trans_ADDPL(DisasContext *s, arg_ADDPL *a)
     return true;
 }
 
+static bool trans_ADDSPL(DisasContext *s, arg_ADDSPL *a)
+{
+    if (!dc_isar_feature(aa64_sme, s)) {
+        return false;
+    }
+    if (sme_enabled_check(s)) {
+        TCGv_i64 rd = cpu_reg_sp(s, a->rd);
+        TCGv_i64 rn = cpu_reg_sp(s, a->rn);
+        tcg_gen_addi_i64(rd, rn, a->imm * (s->svl / 8));
+    }
+    return true;
+}
+
 static bool trans_RDVL(DisasContext *s, arg_RDVL *a)
 {
     if (!dc_isar_feature(aa64_sve, s)) {
@@ -1311,6 +1337,18 @@ static bool trans_RDVL(DisasContext *s, arg_RDVL *a)
     return true;
 }
 
+static bool trans_RDSVL(DisasContext *s, arg_RDSVL *a)
+{
+    if (!dc_isar_feature(aa64_sme, s)) {
+        return false;
+    }
+    if (sme_enabled_check(s)) {
+        TCGv_i64 reg = cpu_reg(s, a->rd);
+        tcg_gen_movi_i64(reg, a->imm * s->svl);
+    }
+    return true;
+}
+
 /*
  *** SVE Compute Vector Address Group
  */
-- 
2.34.1



  parent reply	other threads:[~2022-06-02 22:24 UTC|newest]

Thread overview: 109+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-02 21:47 [PATCH 00/71] target/arm: Scalable Matrix Extension Richard Henderson
2022-06-02 21:47 ` [PATCH 01/71] target/arm: Rename TBFLAG_A64 ZCR_LEN to VL Richard Henderson
2022-06-02 21:47 ` [PATCH 02/71] linux-user/aarch64: Introduce sve_vq_cached Richard Henderson
2022-06-06 10:31   ` Peter Maydell
2022-06-02 21:47 ` [PATCH 03/71] target/arm: Remove route_to_el2 check from sve_exception_el Richard Henderson
2022-06-06 12:13   ` Peter Maydell
2022-06-02 21:47 ` [PATCH 04/71] target/arm: Remove fp checks " Richard Henderson
2022-06-06 12:23   ` Peter Maydell
2022-06-02 21:47 ` [PATCH 05/71] target/arm: Add el_is_in_host Richard Henderson
2022-06-02 21:47 ` [PATCH 06/71] target/arm: Use el_is_in_host for sve_zcr_len_for_el Richard Henderson
2022-06-02 21:47 ` [PATCH 07/71] target/arm: Use el_is_in_host for sve_exception_el Richard Henderson
2022-06-06 12:24   ` Peter Maydell
2022-06-02 21:47 ` [PATCH 08/71] target/arm: Hoist arm_is_el2_enabled check in sve_exception_el Richard Henderson
2022-06-06 12:27   ` Peter Maydell
2022-06-02 21:47 ` [PATCH 09/71] target/arm: Do not use aarch64_sve_zcr_get_valid_len in reset Richard Henderson
2022-06-06 12:27   ` Peter Maydell
2022-06-02 21:47 ` [PATCH 10/71] target/arm: Merge aarch64_sve_zcr_get_valid_len into caller Richard Henderson
2022-06-06 12:30   ` Peter Maydell
2022-06-02 21:47 ` [PATCH 11/71] target/arm: Use uint32_t instead of bitmap for sve vq's Richard Henderson
2022-06-02 21:47 ` [PATCH 12/71] target/arm: Rename sve_zcr_len_for_el to sve_vqm1_for_el Richard Henderson
2022-06-02 21:47 ` [PATCH 13/71] target/arm: Split out load/store primitives to sve_ldst_internal.h Richard Henderson
2022-06-02 21:47 ` [PATCH 14/71] target/arm: Export sve contiguous ldst support functions Richard Henderson
2022-06-02 21:47 ` [PATCH 15/71] target/arm: Move expand_pred_b to vec_internal.h Richard Henderson
2022-06-02 21:47 ` [PATCH 16/71] target/arm: Use expand_pred_b in mve_helper.c Richard Henderson
2022-06-02 21:47 ` [PATCH 17/71] target/arm: Move expand_pred_h to vec_internal.h Richard Henderson
2022-06-02 21:48 ` [PATCH 18/71] target/arm: Export bfdotadd from vec_helper.c Richard Henderson
2022-06-02 21:48 ` [PATCH 19/71] target/arm: Add isar_feature_aa64_sme Richard Henderson
2022-06-06 12:31   ` Peter Maydell
2022-06-02 21:48 ` [PATCH 20/71] target/arm: Add ID_AA64SMFR0_EL1 Richard Henderson
2022-06-06 13:05   ` Peter Maydell
2022-06-06 16:19     ` Richard Henderson
2022-06-02 21:48 ` [PATCH 21/71] target/arm: Implement TPIDR2_EL0 Richard Henderson
2022-06-06 13:18   ` Peter Maydell
2022-06-06 14:38     ` Richard Henderson
2022-06-02 21:48 ` [PATCH 22/71] target/arm: Add SMEEXC_EL to TB flags Richard Henderson
2022-06-06 13:25   ` Peter Maydell
2022-06-02 21:48 ` [PATCH 23/71] target/arm: Add syn_smetrap Richard Henderson
2022-06-06 13:28   ` Peter Maydell
2022-06-02 21:48 ` [PATCH 24/71] target/arm: Add ARM_CP_SME Richard Henderson
2022-06-06 13:32   ` Peter Maydell
2022-06-02 21:48 ` [PATCH 25/71] target/arm: Add SVCR Richard Henderson
2022-06-06 13:40   ` Peter Maydell
2022-06-06 14:41     ` Richard Henderson
2022-06-02 21:48 ` [PATCH 26/71] target/arm: Add SMCR_ELx Richard Henderson
2022-06-06 13:42   ` Peter Maydell
2022-06-02 21:48 ` [PATCH 27/71] target/arm: Add SMIDR_EL1, SMPRI_EL1, SMPRIMAP_EL2 Richard Henderson
2022-06-06 15:55   ` Peter Maydell
2022-06-02 21:48 ` [PATCH 28/71] target/arm: Add PSTATE.{SM,ZA} to TB flags Richard Henderson
2022-06-06 15:58   ` Peter Maydell
2022-06-06 16:50     ` Richard Henderson
2022-06-02 21:48 ` [PATCH 29/71] target/arm: Add the SME ZA storage to CPUARMState Richard Henderson
2022-06-06 16:13   ` Peter Maydell
2022-06-02 21:48 ` [PATCH 30/71] target/arm: Implement SMSTART, SMSTOP Richard Henderson
2022-06-06 16:50   ` Peter Maydell
2022-06-02 21:48 ` [PATCH 31/71] target/arm: Move error for sve%d property to arm_cpu_sve_finalize Richard Henderson
2022-06-07  8:44   ` Peter Maydell
2022-06-02 21:48 ` [PATCH 32/71] target/arm: Create ARMVQMap Richard Henderson
2022-06-07  8:45   ` Peter Maydell
2022-06-02 21:48 ` [PATCH 33/71] target/arm: Generalize cpu_arm_{get,set}_vq Richard Henderson
2022-06-07  8:48   ` Peter Maydell
2022-06-02 21:48 ` [PATCH 34/71] target/arm: Generalize cpu_arm_{get, set}_default_vec_len Richard Henderson
2022-06-07  8:49   ` Peter Maydell
2022-06-02 21:48 ` [PATCH 35/71] target/arm: Move arm_cpu_*_finalize to internals.h Richard Henderson
2022-06-07  8:50   ` Peter Maydell
2022-06-02 21:48 ` [PATCH 36/71] target/arm: Unexport aarch64_add_*_properties Richard Henderson
2022-06-07  8:51   ` Peter Maydell
2022-06-02 21:48 ` [PATCH 37/71] target/arm: Add cpu properties for SME Richard Henderson
2022-06-07  9:47   ` Peter Maydell
2022-06-07 14:45     ` Richard Henderson
2022-06-02 21:48 ` [PATCH 38/71] target/arm: Introduce sve_vqm1_for_el_sm Richard Henderson
2022-06-07  9:54   ` Peter Maydell
2022-06-02 21:48 ` [PATCH 39/71] target/arm: Add SVL to TB flags Richard Henderson
2022-06-07  9:58   ` Peter Maydell
2022-06-07 14:49     ` Richard Henderson
2022-06-02 21:48 ` [PATCH 40/71] target/arm: Move pred_{full, gvec}_reg_{offset, size} to translate-a64.h Richard Henderson
2022-06-07  9:58   ` Peter Maydell
2022-06-02 21:48 ` [PATCH 41/71] target/arm: Add infrastructure for disas_sme Richard Henderson
2022-06-07 10:03   ` Peter Maydell
2022-06-07 14:52     ` Richard Henderson
2022-06-02 21:48 ` [PATCH 42/71] target/arm: Trap AdvSIMD usage when Streaming SVE is active Richard Henderson
2022-06-02 21:48 ` Richard Henderson [this message]
2022-06-02 21:48 ` [PATCH 44/71] target/arm: Implement SME ZERO Richard Henderson
2022-06-02 21:48 ` [PATCH 45/71] target/arm: Implement SME MOVA Richard Henderson
2022-06-02 21:48 ` [PATCH 46/71] target/arm: Implement SME LD1, ST1 Richard Henderson
2022-06-02 21:48 ` [PATCH 47/71] target/arm: Export unpredicated ld/st from translate-sve.c Richard Henderson
2022-06-02 21:48 ` [PATCH 48/71] target/arm: Implement SME LDR, STR Richard Henderson
2022-06-02 21:48 ` [PATCH 49/71] target/arm: Implement SME ADDHA, ADDVA Richard Henderson
2022-06-02 21:48 ` [PATCH 50/71] target/arm: Implement FMOPA, FMOPS (non-widening) Richard Henderson
2022-06-02 21:48 ` [PATCH 51/71] target/arm: Implement BFMOPA, BFMOPS Richard Henderson
2022-06-02 21:48 ` [PATCH 52/71] target/arm: Implement FMOPA, FMOPS (widening) Richard Henderson
2022-06-02 21:48 ` [PATCH 53/71] target/arm: Implement SME integer outer product Richard Henderson
2022-06-02 21:48 ` [PATCH 54/71] target/arm: Implement PSEL Richard Henderson
2022-06-02 21:48 ` [PATCH 55/71] target/arm: Implement REVD Richard Henderson
2022-06-02 21:48 ` [PATCH 56/71] target/arm: Implement SCLAMP, UCLAMP Richard Henderson
2022-06-02 21:48 ` [PATCH 57/71] target/arm: Reset streaming sve state on exception boundaries Richard Henderson
2022-06-02 21:48 ` [PATCH 58/71] target/arm: Enable SME for -cpu max Richard Henderson
2022-06-02 21:48 ` [PATCH 59/71] linux-user/aarch64: Clear tpidr2_el0 if CLONE_SETTLS Richard Henderson
2022-06-02 21:48 ` [PATCH 60/71] linux-user/aarch64: Reset PSTATE.SM on syscalls Richard Henderson
2022-06-02 21:48 ` [PATCH 61/71] linux-user/aarch64: Add SM bit to SVE signal context Richard Henderson
2022-06-02 21:48 ` [PATCH 62/71] linux-user/aarch64: Tidy target_restore_sigframe error return Richard Henderson
2022-06-02 21:48 ` [PATCH 63/71] linux-user/aarch64: Do not allow duplicate or short sve records Richard Henderson
2022-06-02 21:48 ` [PATCH 64/71] linux-user/aarch64: Verify extra record lock succeeded Richard Henderson
2022-06-02 21:48 ` [PATCH 65/71] linux-user/aarch64: Move sve record checks into restore Richard Henderson
2022-06-02 21:48 ` [PATCH 66/71] linux-user/aarch64: Implement SME signal handling Richard Henderson
2022-06-02 21:48 ` [PATCH 67/71] linux-user: Rename sve prctls Richard Henderson
2022-06-02 21:48 ` [PATCH 68/71] linux-user/aarch64: Implement PR_SME_GET_VL, PR_SME_SET_VL Richard Henderson
2022-06-02 21:48 ` [PATCH 69/71] target/arm: Only set ZEN in reset if SVE present Richard Henderson
2022-06-02 21:48 ` [PATCH 70/71] target/arm: Enable SME for user-only Richard Henderson
2022-06-02 21:48 ` [PATCH 71/71] linux-user/aarch64: Add SME related hwcap entries Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220602214853.496211-44-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).