* [PATCH] ppc/pnv: fix extra indent spaces with DEFINE_PROP*
@ 2022-06-02 21:53 Daniel Henrique Barboza
2022-06-06 12:18 ` Mark Cave-Ayland
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Henrique Barboza @ 2022-06-02 21:53 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-ppc, clg, Daniel Henrique Barboza, Mark Cave-Ayland
The DEFINE_PROP* macros in pnv files are using extra spaces for no good
reason.
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---
hw/pci-host/pnv_phb3.c | 8 ++++----
hw/pci-host/pnv_phb4.c | 10 +++++-----
hw/pci-host/pnv_phb4_pec.c | 10 +++++-----
3 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/hw/pci-host/pnv_phb3.c b/hw/pci-host/pnv_phb3.c
index 3f03467dde..26ac9b7123 100644
--- a/hw/pci-host/pnv_phb3.c
+++ b/hw/pci-host/pnv_phb3.c
@@ -1088,10 +1088,10 @@ static const char *pnv_phb3_root_bus_path(PCIHostState *host_bridge,
}
static Property pnv_phb3_properties[] = {
- DEFINE_PROP_UINT32("index", PnvPHB3, phb_id, 0),
- DEFINE_PROP_UINT32("chip-id", PnvPHB3, chip_id, 0),
- DEFINE_PROP_LINK("chip", PnvPHB3, chip, TYPE_PNV_CHIP, PnvChip *),
- DEFINE_PROP_END_OF_LIST(),
+ DEFINE_PROP_UINT32("index", PnvPHB3, phb_id, 0),
+ DEFINE_PROP_UINT32("chip-id", PnvPHB3, chip_id, 0),
+ DEFINE_PROP_LINK("chip", PnvPHB3, chip, TYPE_PNV_CHIP, PnvChip *),
+ DEFINE_PROP_END_OF_LIST(),
};
static void pnv_phb3_class_init(ObjectClass *klass, void *data)
diff --git a/hw/pci-host/pnv_phb4.c b/hw/pci-host/pnv_phb4.c
index 13ba9e45d8..6594016121 100644
--- a/hw/pci-host/pnv_phb4.c
+++ b/hw/pci-host/pnv_phb4.c
@@ -1692,11 +1692,11 @@ static void pnv_phb4_xive_notify(XiveNotifier *xf, uint32_t srcno,
}
static Property pnv_phb4_properties[] = {
- DEFINE_PROP_UINT32("index", PnvPHB4, phb_id, 0),
- DEFINE_PROP_UINT32("chip-id", PnvPHB4, chip_id, 0),
- DEFINE_PROP_LINK("pec", PnvPHB4, pec, TYPE_PNV_PHB4_PEC,
- PnvPhb4PecState *),
- DEFINE_PROP_END_OF_LIST(),
+ DEFINE_PROP_UINT32("index", PnvPHB4, phb_id, 0),
+ DEFINE_PROP_UINT32("chip-id", PnvPHB4, chip_id, 0),
+ DEFINE_PROP_LINK("pec", PnvPHB4, pec, TYPE_PNV_PHB4_PEC,
+ PnvPhb4PecState *),
+ DEFINE_PROP_END_OF_LIST(),
};
static void pnv_phb4_class_init(ObjectClass *klass, void *data)
diff --git a/hw/pci-host/pnv_phb4_pec.c b/hw/pci-host/pnv_phb4_pec.c
index 61bc0b503e..8b7e823fa5 100644
--- a/hw/pci-host/pnv_phb4_pec.c
+++ b/hw/pci-host/pnv_phb4_pec.c
@@ -215,11 +215,11 @@ static int pnv_pec_dt_xscom(PnvXScomInterface *dev, void *fdt,
}
static Property pnv_pec_properties[] = {
- DEFINE_PROP_UINT32("index", PnvPhb4PecState, index, 0),
- DEFINE_PROP_UINT32("chip-id", PnvPhb4PecState, chip_id, 0),
- DEFINE_PROP_LINK("chip", PnvPhb4PecState, chip, TYPE_PNV_CHIP,
- PnvChip *),
- DEFINE_PROP_END_OF_LIST(),
+ DEFINE_PROP_UINT32("index", PnvPhb4PecState, index, 0),
+ DEFINE_PROP_UINT32("chip-id", PnvPhb4PecState, chip_id, 0),
+ DEFINE_PROP_LINK("chip", PnvPhb4PecState, chip, TYPE_PNV_CHIP,
+ PnvChip *),
+ DEFINE_PROP_END_OF_LIST(),
};
static uint32_t pnv_pec_xscom_pci_base(PnvPhb4PecState *pec)
--
2.36.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ppc/pnv: fix extra indent spaces with DEFINE_PROP*
2022-06-02 21:53 [PATCH] ppc/pnv: fix extra indent spaces with DEFINE_PROP* Daniel Henrique Barboza
@ 2022-06-06 12:18 ` Mark Cave-Ayland
0 siblings, 0 replies; 2+ messages in thread
From: Mark Cave-Ayland @ 2022-06-06 12:18 UTC (permalink / raw)
To: Daniel Henrique Barboza, qemu-devel; +Cc: qemu-ppc, clg
On 02/06/2022 22:53, Daniel Henrique Barboza wrote:
> The DEFINE_PROP* macros in pnv files are using extra spaces for no good
> reason.
>
> Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
> ---
> hw/pci-host/pnv_phb3.c | 8 ++++----
> hw/pci-host/pnv_phb4.c | 10 +++++-----
> hw/pci-host/pnv_phb4_pec.c | 10 +++++-----
> 3 files changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/hw/pci-host/pnv_phb3.c b/hw/pci-host/pnv_phb3.c
> index 3f03467dde..26ac9b7123 100644
> --- a/hw/pci-host/pnv_phb3.c
> +++ b/hw/pci-host/pnv_phb3.c
> @@ -1088,10 +1088,10 @@ static const char *pnv_phb3_root_bus_path(PCIHostState *host_bridge,
> }
>
> static Property pnv_phb3_properties[] = {
> - DEFINE_PROP_UINT32("index", PnvPHB3, phb_id, 0),
> - DEFINE_PROP_UINT32("chip-id", PnvPHB3, chip_id, 0),
> - DEFINE_PROP_LINK("chip", PnvPHB3, chip, TYPE_PNV_CHIP, PnvChip *),
> - DEFINE_PROP_END_OF_LIST(),
> + DEFINE_PROP_UINT32("index", PnvPHB3, phb_id, 0),
> + DEFINE_PROP_UINT32("chip-id", PnvPHB3, chip_id, 0),
> + DEFINE_PROP_LINK("chip", PnvPHB3, chip, TYPE_PNV_CHIP, PnvChip *),
> + DEFINE_PROP_END_OF_LIST(),
> };
>
> static void pnv_phb3_class_init(ObjectClass *klass, void *data)
> diff --git a/hw/pci-host/pnv_phb4.c b/hw/pci-host/pnv_phb4.c
> index 13ba9e45d8..6594016121 100644
> --- a/hw/pci-host/pnv_phb4.c
> +++ b/hw/pci-host/pnv_phb4.c
> @@ -1692,11 +1692,11 @@ static void pnv_phb4_xive_notify(XiveNotifier *xf, uint32_t srcno,
> }
>
> static Property pnv_phb4_properties[] = {
> - DEFINE_PROP_UINT32("index", PnvPHB4, phb_id, 0),
> - DEFINE_PROP_UINT32("chip-id", PnvPHB4, chip_id, 0),
> - DEFINE_PROP_LINK("pec", PnvPHB4, pec, TYPE_PNV_PHB4_PEC,
> - PnvPhb4PecState *),
> - DEFINE_PROP_END_OF_LIST(),
> + DEFINE_PROP_UINT32("index", PnvPHB4, phb_id, 0),
> + DEFINE_PROP_UINT32("chip-id", PnvPHB4, chip_id, 0),
> + DEFINE_PROP_LINK("pec", PnvPHB4, pec, TYPE_PNV_PHB4_PEC,
> + PnvPhb4PecState *),
> + DEFINE_PROP_END_OF_LIST(),
> };
>
> static void pnv_phb4_class_init(ObjectClass *klass, void *data)
> diff --git a/hw/pci-host/pnv_phb4_pec.c b/hw/pci-host/pnv_phb4_pec.c
> index 61bc0b503e..8b7e823fa5 100644
> --- a/hw/pci-host/pnv_phb4_pec.c
> +++ b/hw/pci-host/pnv_phb4_pec.c
> @@ -215,11 +215,11 @@ static int pnv_pec_dt_xscom(PnvXScomInterface *dev, void *fdt,
> }
>
> static Property pnv_pec_properties[] = {
> - DEFINE_PROP_UINT32("index", PnvPhb4PecState, index, 0),
> - DEFINE_PROP_UINT32("chip-id", PnvPhb4PecState, chip_id, 0),
> - DEFINE_PROP_LINK("chip", PnvPhb4PecState, chip, TYPE_PNV_CHIP,
> - PnvChip *),
> - DEFINE_PROP_END_OF_LIST(),
> + DEFINE_PROP_UINT32("index", PnvPhb4PecState, index, 0),
> + DEFINE_PROP_UINT32("chip-id", PnvPhb4PecState, chip_id, 0),
> + DEFINE_PROP_LINK("chip", PnvPhb4PecState, chip, TYPE_PNV_CHIP,
> + PnvChip *),
> + DEFINE_PROP_END_OF_LIST(),
> };
>
> static uint32_t pnv_pec_xscom_pci_base(PnvPhb4PecState *pec)
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
ATB,
Mark.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-06 12:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-02 21:53 [PATCH] ppc/pnv: fix extra indent spaces with DEFINE_PROP* Daniel Henrique Barboza
2022-06-06 12:18 ` Mark Cave-Ayland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).