From: Bernhard Beschow <shentey@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Aurelien Jarno" <aurelien@aurel32.net>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Bernhard Beschow" <shentey@gmail.com>,
"Peter Maydell" <peter.maydell@linaro.org>
Subject: [PATCH v4 02/11] hw/isa/piix4: Use object_initialize_child() for embedded struct
Date: Fri, 3 Jun 2022 20:50:36 +0200 [thread overview]
Message-ID: <20220603185045.143789-3-shentey@gmail.com> (raw)
In-Reply-To: <20220603185045.143789-1-shentey@gmail.com>
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/isa/piix4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c
index 9a6d981037..1d04fb6a55 100644
--- a/hw/isa/piix4.c
+++ b/hw/isa/piix4.c
@@ -224,7 +224,7 @@ static void piix4_init(Object *obj)
{
PIIX4State *s = PIIX4_PCI_DEVICE(obj);
- object_initialize(&s->rtc, sizeof(s->rtc), TYPE_MC146818_RTC);
+ object_initialize_child(obj, "rtc", &s->rtc, TYPE_MC146818_RTC);
}
static void piix4_class_init(ObjectClass *klass, void *data)
--
2.36.1
next prev parent reply other threads:[~2022-06-03 18:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 18:50 [PATCH v4 00/11] QOM'ify PIIX southbridge creation Bernhard Beschow
2022-06-03 18:50 ` [PATCH v4 01/11] hw/southbridge/piix: Aggregate all PIIX southbridge type names Bernhard Beschow
2022-06-03 18:50 ` Bernhard Beschow [this message]
2022-06-03 18:50 ` [PATCH v4 03/11] hw/isa/piix4: Move pci_map_irq_fn' near pci_set_irq_fn Bernhard Beschow
2022-06-03 18:50 ` [PATCH v4 04/11] hw/isa/piix4: QOM'ify PCI device creation and wiring Bernhard Beschow
2022-06-03 18:50 ` [PATCH v4 05/11] hw/isa/piix4: Factor out ISABus retrieval from piix4_create() Bernhard Beschow
2022-06-03 18:50 ` [PATCH v4 06/11] hw/isa/piix4: QOM'ify PIIX4 PM creation Bernhard Beschow
2022-06-03 18:50 ` [PATCH v4 07/11] hw/isa/piix4: Inline and remove piix4_create() Bernhard Beschow
2022-06-03 18:50 ` [PATCH v4 08/11] hw/isa/piix3: Move pci_map_irq_fn near pci_set_irq_fn Bernhard Beschow
2022-06-03 18:50 ` [PATCH v4 09/11] hw/isa/piix3: QOM'ify PCI device creation and wiring Bernhard Beschow
2022-06-03 18:50 ` [PATCH v4 10/11] hw/isa/piix3: Factor out ISABus retrieval from piix3_create() Bernhard Beschow
2022-06-03 18:50 ` [PATCH v4 11/11] hw/isa/piix3: Inline and remove piix3_create() Bernhard Beschow
2022-06-06 10:38 ` [PATCH v4 00/11] QOM'ify PIIX southbridge creation Mark Cave-Ayland
2022-06-11 9:47 ` Philippe Mathieu-Daudé via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220603185045.143789-3-shentey@gmail.com \
--to=shentey@gmail.com \
--cc=aurelien@aurel32.net \
--cc=eduardo@habkost.net \
--cc=f4bug@amsat.org \
--cc=hpoussin@reactos.org \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).